openstack
/
nova
Code Issues Proposed changes
OpenStack Compute (Nova)
48,363 Commits 9 Branches 80 Tags 1.6 GiB
Python 97.7%
Smarty 2.2%
Shell 0.1%
Go to file
Lee Yarwood 2faf17995d libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration 
The VIR_MIGRATE_PARAM_PERSIST_XML parameter was introduced in libvirt
v1.3.4 and is used to provide the new persistent configuration for the
destination during a live migration:

https://libvirt.org/html/libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_PERSIST_XML

Without this parameter the persistent configuration on the destination
will be the same as the original persistent configuration on the source
when the VIR_MIGRATE_PERSIST_DEST flag is provided.

As Nova does not currently provide the VIR_MIGRATE_PARAM_PERSIST_XML
param but does provide the VIR_MIGRATE_PERSIST_DEST flag this means that
a soft reboot by Nova of the instance after a live migration can revert
the domain back to the original persistent configuration from the
source.

Note that this is only possible in Nova as a soft reboot actually
results in the virDomainShutdown and virDomainLaunch libvirt APIs being
called that recreate the domain using the persistent configuration.
virDomainReboot does not result in this but is not called at this time.

The impact of this on the instance after the soft reboot is pretty
severe, host devices referenced in the original persistent configuration
on the source may not exist or could even be used by other users on the
destination. CPU and NUMA affinity could also differ drastically between
the two hosts resulting in the instance being unable to start etc.

As MIN_LIBVIRT_VERSION is now > v1.3.4 this change simply includes the
VIR_MIGRATE_PARAM_PERSIST_XML param using the same updated XML for the
destination as is already provided to VIR_MIGRATE_PARAM_DEST_XML.

Conflicts:
    nova/tests/unit/virt/libvirt/test_driver.py
    nova/virt/libvirt/driver.py

NOTE(melwitt): Conflicts in driver.py are because changes:

  I6ac601e633ab2b0a67b4802ff880865255188a93
    (libvirt: Provide VGPU inventory for a single GPU type)
  I947bf0ad34a48e9182a3dc016f47f0c9f71c9d7b
    ([libvirt] Allow multiple volume attachments)
  Ibfa64f18bbd2fb70db7791330ed1a64fe61c1355
    (libvirt: QEMU native LUKS decryption for encrypted volumes)
  If2035cac931c42c440d61ba97ebc7e9e92141a28
    (libvirt: Rework 'EBUSY' (SIGKILL) error handling code path)
  Ibf210dd27972fed2651d6c9bd73a0bcf352c8bab
    (libvirt: create vGPU for instance)

are not in Pike. Conflict in test_driver.py is because the Pike
backport of change I9b545ca8aa6dd7b41ddea2d333190c9fbed19bc1 explicitly
asserts byte string destination_xml in
_test_live_migration_block_migration_flags and the change is not in
Queens where this is being backported from.

Co-authored-by: Tadayoshi Hosoya <tad-hosoya@wr.jp.nec.com>
Closes-Bug: #1890501
Change-Id: Ia3f1d8e83cbc574ce5cb440032e12bbcb1e10e98
(cherry picked from commit 1bb8ee95d4)
(cherry picked from commit bbf9d1de06)
(cherry picked from commit 6a07edb4b2)
(cherry picked from commit b9ea91d177)
(cherry picked from commit c438fd9a0e)
(cherry picked from commit a721ca5f51)
 		2020-09-25 15:23:07 +00:00
api-guide/source api-ref: Add X-Openstack-Request-Id description 2017-07-10 14:03:14 +00:00
api-ref/source Block deleting compute services which are hosting instances 2018-07-05 16:24:32 -04:00
contrib Merge "changed quantum to neutron in vif-openstack" 2014-03-05 10:45:05 +00:00
devstack Skip test_rebuild_server_in_error_state for cells v1 2017-08-22 18:42:17 +00:00
doc Fix os-simple-tenant-usage result order 2020-08-03 13:43:55 +02:00
etc/nova rootwrap.d cleanup mislabeled files 2017-08-01 16:09:18 +10:00
gate move gate hooks to gate/ 2017-01-04 11:05:16 +00:00
nova libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration 2020-09-25 15:23:07 +00:00
placement-api-ref/source [placement] Add api-ref for usages 2017-08-09 15:54:48 +00:00
playbooks/legacy Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree 2019-04-26 15:21:26 -04:00
plugins/xenserver XenAPI Remove useless files when use os-xenapi lib 2017-01-10 18:06:17 -08:00
releasenotes Fix os-simple-tenant-usage result order 2020-08-03 13:43:55 +02:00
tools Check cherry-pick hashes in pep8 tox target 2020-07-21 16:41:23 +02:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.gitreview OpenDev Migration Patch 2019-04-19 19:46:33 +00:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.stestr.conf Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.zuul.yaml Merge "Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs" into stable/pike 2020-03-25 11:40:34 +00:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst Enable global hacking checks and removed local checks 2017-02-10 15:09:37 +01:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Add a maintainers file 2015-05-23 03:22:07 +10:00
README.rst doc: Rework README to reflect new doc URLs 2017-08-03 16:06:08 -04:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt Update bindep.txt for doc builds 2017-11-21 20:09:12 +00:00
requirements.txt Updated from global requirements 2017-08-07 00:49:24 +00:00
setup.cfg Using plain routes for the microversions test 2017-07-23 22:43:53 +08:00
setup.py Updated from global requirements 2017-03-02 11:50:48 +00:00
test-requirements.txt Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
tests-functional-py3.txt Remove invalid URL in gabbi tests 2017-01-17 21:10:45 +00:00
tests-py3.txt Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
tox.ini Check cherry-pick hashes in pep8 tox target 2020-07-21 16:41:23 +02:00

README.rst

Team and repository tags

image

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.

Use the following resources to learn more.

API

To learn how to use Nova's API, consult the documentation available online at:

For more information on OpenStack APIs, SDKs and CLIs in general, refer to:

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

Other Information

During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: