ecfcf86538
We've seen a recent issue that suggest direct IO support checks can fail in other valid ways than EINVAL, namely, failures with ENOENT or the FileNotFoundError exception, which is a Python 3-only exception type, can occur. While we can't test for this without breaking Python 2.7 support, we can mimic this by looking for checking for the errno attribute of the OSError exception. Do this. Change-Id: I8aab86bb62cbc8ad538c706af037a30437c7964d Closes-Bug: #1788922
79 lines
2.7 KiB
Python
79 lines
2.7 KiB
Python
# Copyright 2010 United States Government as represented by the
|
|
# Administrator of the National Aeronautics and Space Administration.
|
|
# Copyright 2011 Justin Santa Barbara
|
|
# Copyright 2018 Michael Still and Aptira
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# This module is utility methods that privsep depends on. Privsep isn't allowed
|
|
# to depend on anything outside the privsep directory, so these need to be
|
|
# here. That said, other parts of nova can call into these utilities if
|
|
# needed.
|
|
|
|
import errno
|
|
import mmap
|
|
import os
|
|
|
|
from oslo_log import log as logging
|
|
from oslo_utils import excutils
|
|
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
def supports_direct_io(dirpath):
|
|
|
|
if not hasattr(os, 'O_DIRECT'):
|
|
LOG.debug("This python runtime does not support direct I/O")
|
|
return False
|
|
|
|
testfile = os.path.join(dirpath, ".directio.test")
|
|
|
|
hasDirectIO = True
|
|
fd = None
|
|
try:
|
|
fd = os.open(testfile, os.O_CREAT | os.O_WRONLY | os.O_DIRECT)
|
|
# Check is the write allowed with 512 byte alignment
|
|
align_size = 512
|
|
m = mmap.mmap(-1, align_size)
|
|
m.write(b"x" * align_size)
|
|
os.write(fd, m)
|
|
LOG.debug("Path '%(path)s' supports direct I/O",
|
|
{'path': dirpath})
|
|
except OSError as e:
|
|
if e.errno in (errno.EINVAL, errno.ENOENT):
|
|
LOG.debug("Path '%(path)s' does not support direct I/O: "
|
|
"'%(ex)s'", {'path': dirpath, 'ex': e})
|
|
hasDirectIO = False
|
|
else:
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.error("Error on '%(path)s' while checking "
|
|
"direct I/O: '%(ex)s'",
|
|
{'path': dirpath, 'ex': e})
|
|
except Exception as e:
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.error("Error on '%(path)s' while checking direct I/O: "
|
|
"'%(ex)s'", {'path': dirpath, 'ex': e})
|
|
finally:
|
|
# ensure unlink(filepath) will actually remove the file by deleting
|
|
# the remaining link to it in close(fd)
|
|
if fd is not None:
|
|
os.close(fd)
|
|
|
|
try:
|
|
os.unlink(testfile)
|
|
except Exception:
|
|
pass
|
|
|
|
return hasDirectIO
|