nova/nova/tests/unit
Artom Lifshitz 560317c766 libvirt: move checking CONF.my_ip to init_host()
Migrations use the libvirt driver's get_host_ip_addr() method to
determine the dest_host field of the migration object.
get_host_ip_addr() checks whether CONF.my_ip is actually assigned to
one of the host's interfaces. It does so by calling
get_machine_ips(), which iterates over all of the host's interfaces.
If the host has many interfaces, this can take a long time, and
introduces needless delays in processing the migration.
get_machine_ips() is only used to print a warning, so this patch moves
the get_machine_ips() call to a single method in init_host(). This
way, a warning is still emitted at compute service startup, and
migration progress is not needlessly slowed down.

NOTE(artom) While the following paragraph still applies, the poison
patch will not be backported. Stubbing out use of
netifaces.interfaces() is still a good thing to do, however.

This patch also has a chicken and egg problem with the patch on top of
it, which poisons use of netifaces.interfaces() in tests. While this
patch fixes all the tests that break with that poison, it starts
breaking different tests because of the move of get_machine_ips() into
init_host(). Therefore, while not directly related to the bug, this
patch also preventatively mocks or stubs out any use of
get_machine_ips() that will get poisoned with the subsequent patch.

Closes-bug: 1837075
Change-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f
(cherry picked from commit 30d8159d4e)
2019-07-22 15:48:09 -04:00
..
api Merge "Delete resource providers for all nodes when deleting compute service" into stable/stein 2019-07-01 16:25:12 +00:00
cells Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
cmd Remove "API Service Version" upgrade check 2018-12-19 20:41:04 -05:00
compute Merge "Grab fresh power state info from the driver" into stable/stein 2019-07-01 13:48:54 +00:00
conductor Noop CantStartEngineError in targets_cell if API DB not configured 2019-06-04 13:32:51 +00:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Move create of ComputeAPI object in websocketproxy 2019-04-02 15:43:18 +00:00
consoleauth Fix stacktraces with redis caching backend 2018-09-27 13:15:11 -04:00
db Fix retry of instance_update_and_get_original 2019-05-15 16:29:53 +01:00
fake_loadables
image Share snapshot image membership with instance owner 2019-02-08 18:06:27 -05:00
keymgr
network Move get_pci_mapping_for_migration to MigrationContext 2019-05-26 18:40:28 +03:00
notifications Remove CellMappingPayload database_connection and transport_url fields 2019-04-04 21:25:52 +00:00
objects Avoid unnecessary joins in InstanceGroup.get_hosts 2019-06-10 15:15:23 +00:00
pci Add get_instance_pci_request_from_vif 2019-03-07 11:37:53 +02:00
privsep Move create_tap_dev into privsep. 2019-02-19 03:29:44 +00:00
scheduler Init HostState.failed_builds 2019-06-29 02:36:21 +00:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt libvirt: move checking CONF.my_ip to init_host() 2019-07-22 15:48:09 -04:00
volume Add compute API validation for when a volume_type is requested 2018-10-11 16:04:53 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py libvirt: Start populating NUMACell.network_metadata field 2018-07-24 15:33:49 +01:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize 2019-06-20 12:43:25 -04:00
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Remove deprecated 'os-server-groups' policy 2019-02-22 00:31:02 +00:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Add python 3.7 unit and functional tox jobs 2018-12-13 10:41:46 -05:00
test_availability_zones.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_baserpc.py
test_block_device.py Add method to generate device names universally 2019-01-15 18:55:11 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Configure placement DB context manager for nova-manage/status 2018-09-05 10:29:48 -04:00
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Remove NovaException logging from scatter_gather_cells 2018-11-21 12:43:35 -05:00
test_crypto.py
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Add context.target_cell() stub to DownCellFixture 2019-02-15 14:39:20 -05:00
test_flavors.py Add python 3.7 unit and functional tox jobs 2018-12-13 10:41:46 -05:00
test_hacking.py Fix double word hacking test 2019-06-13 15:21:25 +01:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Allow run metadata api per cell 2019-01-14 10:20:50 -05:00
test_notifications.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_notifier.py
test_nova_manage.py Populate InstanceMapping.user_id during migrations and schedules 2019-03-08 19:01:25 -05:00
test_policy.py Fix target used in nova.policy.check_is_admin 2019-05-21 10:55:14 +01:00
test_profiler.py
test_quota.py Merge "quota: remove defaults kwarg in get_project_quotas" 2019-02-26 13:26:24 +00:00
test_rpc.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Switch to using os-resource-classes 2019-02-07 11:11:09 +00:00
test_versions.py
test_weights.py Per aggregate scheduling weight 2019-01-21 11:48:44 +08:00
test_wsgi.py
utils.py Transform missing delete notifications 2018-08-29 13:39:57 +02:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎