openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/unit/virt/xenapi
History
Corey Bryant 8241b47967 xenapi/agent: Change openssl error handling 
Prior to this patch, if the openssl command returned a zero exit code
and wrote details to stderr, nova would raise a RuntimeError exception.
This patch changes the behavior to only raise a RuntimeError exception
when openssl returns a non-zero exit code. Regardless of the exit code
a warning will always be logged with stderr details if stderr is not
None. Note that processutils.execute will now raise a
processutils.ProcessExecutionError exception for any non-zero exit code
since we are passing check_exit_code=True, which we convert to a
Runtime error.

Thanks to Dimitri John Ledkov <xnox@ubuntu.com> and Eric Fried
<openstack@fried.cc> for helping with this patch.

Conflicts:
    nova/virt/xenapi/agent.py

NOTE(coreycb): The conflict is due to
Ibe2f478288db42f8168b52dfc14d85ab92ace74b not being in stable/rocky.

Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073
Partial-Bug: #1771506
(cherry picked from commit 1da71fa4ab)
(cherry picked from commit 64793cf6f7)
 		2019-04-30 08:40:53 -04:00
..
image Remove mox in nova/tests/unit/virt/xenapi/stubs.py 2018-06-21 23:59:39 +00:00
__init__.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
stubs.py Merge "Remove mox in nova/tests/unit/virt/xenapi/stubs.py" 2018-06-29 23:13:42 +00:00
test_agent.py xenapi/agent: Change openssl error handling 2019-04-30 08:40:53 -04:00
test_driver.py Remove mox in nova/tests/unit/virt/xenapi/stubs.py 2018-06-21 23:59:39 +00:00
test_network_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_vgpu.py XenAPI: create vGPU for instance 2017-12-18 08:09:20 -08:00
test_vif.py xenapi: drop deprecated vif_driver config option 2018-06-11 14:29:47 -04:00
test_vm_utils.py Remove mox in nova/tests/unit/virt/xenapi/stubs.py 2018-06-21 23:59:39 +00:00
test_vmops.py XenAPI/Stops the migration of volume backed VHDS 2018-09-20 19:57:37 +00:00
test_volume_utils.py Remove mox in nova/tests/unit/virt/xenapi/stubs.py 2018-06-21 23:59:39 +00:00
test_volumeops.py refactor: move down ``dev_number`` in xenapi 2016-12-05 13:19:23 -06:00
test_xenapi.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
vm_rrd.xml move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00