477722a849
Some patches in gerrit depend on other patches that are not yet approved, i.e. not yet landed on master. In this patch lintstack deals with these cases by currectly generating the right commit to compare against to further reduce pylint errors. Part of bp/lintstack Change-Id: I77622a44949ad2b442d9f2cce6c807e1581830c7
55 lines
2.0 KiB
Bash
Executable File
55 lines
2.0 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Copyright (c) 2012-2013, AT&T Labs, Yun Mao <yunmao@gmail.com>
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# Use lintstack.py to compare pylint errors.
|
|
# We run pylint twice, once on HEAD, once on the code before the latest
|
|
# commit for review.
|
|
set -e
|
|
TOOLS_DIR=$(cd $(dirname "$0") && pwd)
|
|
GITHEAD=`git rev-parse HEAD`
|
|
cp -f $TOOLS_DIR/lintstack.py $TOOLS_DIR/lintstack.head.py
|
|
|
|
if git rev-parse HEAD^2 2>/dev/null; then
|
|
# The HEAD is a Merge commit. Here, the patch to review is
|
|
# HEAD^2, the master branch is at HEAD^1, and the patch was
|
|
# written based on HEAD^2~1.
|
|
PREV_COMMIT=`git rev-parse HEAD^2~1`
|
|
git checkout HEAD~1
|
|
# The git merge is necessary for reviews with a series of patches.
|
|
# If not, this is a no-op so won't hurt either.
|
|
git merge $PREV_COMMIT
|
|
else
|
|
# The HEAD is not a merge commit. This won't happen on gerrit.
|
|
# Most likely you are running against your own patch locally.
|
|
# We assume the patch to examine is HEAD, and we compare it against
|
|
# HEAD~1
|
|
git checkout HEAD~1
|
|
fi
|
|
|
|
# First generate tools/pylint_exceptions from HEAD~1
|
|
$TOOLS_DIR/lintstack.head.py generate
|
|
# Then use that as a reference to compare against HEAD
|
|
git checkout $GITHEAD
|
|
$TOOLS_DIR/lintstack.head.py
|
|
echo "Check passed. FYI: the pylint exceptions are:"
|
|
cat $TOOLS_DIR/pylint_exceptions
|
|
echo
|
|
echo "You are in detached HEAD mode. If you are a developer"
|
|
echo "and not very familiar with git, you might want to do"
|
|
echo "'git checkout branch-name' to go back to your branch."
|
|
|