3f9411071d
This change leverages the new NUMA constraint checking added in in I0322d872bdff68936033a6f5a54e8296a6fb3434 to allow the NUMATopologyFilter to be skipped on rebuild. As the new behavior of rebuild enfroces that no changes to the numa constraints are allowed on rebuild we no longer need to execute the NUMATopologyFilter. Previously the NUMATopologyFilter would process the rebuild request as if it was a request to spawn a new instnace as the numa_fit_instance_to_host function is not rebuild aware. As such prior to this change a rebuild would only succeed if a host had enough additional capacity for a second instance on the same host meeting the requirement of the new image and existing flavor. This behavior was incorrect on two counts as a rebuild uses a noop claim. First the resouce usage cannot change so it was incorrect to require the addtional capacity to rebuild an instance. Secondly it was incorrect not to assert the resouce usage remained the same. I0322d872bdff68936033a6f5a54e8296a6fb3434 adressed guarding the rebuild against altering the resouce usage and this change allows in place rebuild. This change found a latent bug that will be adressed in a follow up change and updated the functional tests to note the incorrect behavior. Change-Id: I48bccc4b9adcac3c7a3e42769c11fdeb8f6fd132 Closes-Bug: #1804502 Implements: blueprint inplace-rebuild-of-numa-instances
28 lines
1.4 KiB
YAML
28 lines
1.4 KiB
YAML
---
|
|
fixes:
|
|
- |
|
|
An instance can be rebuilt in-place with the original image or a new
|
|
image. Instance resource usage cannot be altered during a rebuild.
|
|
Previously Nova would have ignored the NUMA topology of the new image
|
|
continuing to use the NUMA topology of the existing instance until a move
|
|
operation was performed. As Nova did not explicitly guard against
|
|
inadvertent changes in resource request contained in a new image,
|
|
it was possible to rebuild with an image that would violate this requirement
|
|
`bug #1763766`_. This resulted in an inconsistent state as the instance that
|
|
was running did not match the instance that was requested. Nova now explicitly
|
|
checks if a rebuild would alter the requested NUMA topology of an instance
|
|
and rejects the rebuild.
|
|
|
|
.. _`bug #1763766`: https://bugs.launchpad.net/nova/+bug/1763766
|
|
|
|
features:
|
|
- |
|
|
With the changes introduced to address `bug #1763766`_, Nova now guards
|
|
against NUMA constraint changes on rebuild. As a result the
|
|
``NUMATopologyFilter`` is no longer required to run on rebuild since
|
|
we already know the topology will not change and therefor the existing
|
|
resource claim is still valid. As such it is now possible to do an in-place
|
|
rebuild of a instance with a NUMA topology even if the image changes
|
|
provided the new image does not alter the topology.
|
|
|