d775dd7066
The instance.resize_prep.start and instance.resize_prep.end notifications are transformed to the versioned framework. Co-Authored-By: Takashi Natsume <natsume.takashi@lab.ntt.co.jp> Change-Id: If33d092e8688ed4d4864b2f7130104ab85ce1ea4 Implements: bp versioned-notification-transformation-queens
597 lines
24 KiB
Python
597 lines
24 KiB
Python
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
import collections
|
|
|
|
import mock
|
|
from oslo_utils import timeutils
|
|
from oslo_versionedobjects import fixture
|
|
|
|
from nova import exception
|
|
from nova.network import model as network_model
|
|
from nova.notifications import base as notification_base
|
|
from nova.notifications.objects import base as notification
|
|
from nova.notifications.objects import instance as instance_notification
|
|
from nova import objects
|
|
from nova.objects import base
|
|
from nova.objects import fields
|
|
from nova.objects import instance as instance_obj
|
|
from nova import test
|
|
from nova.tests.unit.objects import test_objects
|
|
from nova.tests import uuidsentinel as uuids
|
|
|
|
|
|
class TestNotificationBase(test.NoDBTestCase):
|
|
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestObject(base.NovaObject):
|
|
VERSION = '1.0'
|
|
fields = {
|
|
'field_1': fields.StringField(),
|
|
'field_2': fields.IntegerField(),
|
|
'not_important_field': fields.IntegerField(),
|
|
'lazy_field': fields.IntegerField()
|
|
}
|
|
|
|
def obj_load_attr(self, attrname):
|
|
if attrname == 'lazy_field':
|
|
self.lazy_field = 42
|
|
else:
|
|
raise exception.ObjectActionError(
|
|
action='obj_load_attr',
|
|
reason='attribute %s not lazy-loadable' % attrname)
|
|
|
|
def __init__(self, not_important_field):
|
|
super(TestNotificationBase.TestObject, self).__init__()
|
|
# field1 and field_2 simulates that some fields are initialized
|
|
# outside of the object's ctor
|
|
self.not_important_field = not_important_field
|
|
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestNotificationPayload(notification.NotificationPayloadBase):
|
|
VERSION = '1.0'
|
|
|
|
SCHEMA = {
|
|
'field_1': ('source_field', 'field_1'),
|
|
'field_2': ('source_field', 'field_2'),
|
|
'lazy_field': ('source_field', 'lazy_field')
|
|
}
|
|
|
|
fields = {
|
|
'extra_field': fields.StringField(), # filled by ctor
|
|
# filled by the schema
|
|
'field_1': fields.StringField(nullable=True),
|
|
'field_2': fields.IntegerField(), # filled by the schema
|
|
'lazy_field': fields.IntegerField() # filled by the schema
|
|
}
|
|
|
|
def __init__(self, extra_field, source_field):
|
|
super(TestNotificationBase.TestNotificationPayload,
|
|
self).__init__()
|
|
self.extra_field = extra_field
|
|
self.populate_schema(source_field=source_field)
|
|
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestNotificationPayloadEmptySchema(
|
|
notification.NotificationPayloadBase):
|
|
VERSION = '1.0'
|
|
|
|
fields = {
|
|
'extra_field': fields.StringField(), # filled by ctor
|
|
}
|
|
|
|
def __init__(self, extra_field):
|
|
super(TestNotificationBase.TestNotificationPayloadEmptySchema,
|
|
self).__init__()
|
|
self.extra_field = extra_field
|
|
|
|
@notification.notification_sample('test-update-1.json')
|
|
@notification.notification_sample('test-update-2.json')
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestNotification(notification.NotificationBase):
|
|
VERSION = '1.0'
|
|
fields = {
|
|
'payload': fields.ObjectField('TestNotificationPayload')
|
|
}
|
|
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestNotificationEmptySchema(notification.NotificationBase):
|
|
VERSION = '1.0'
|
|
fields = {
|
|
'payload': fields.ObjectField('TestNotificationPayloadEmptySchema')
|
|
}
|
|
|
|
fake_service = {
|
|
'created_at': timeutils.utcnow().replace(microsecond=0),
|
|
'updated_at': None,
|
|
'deleted_at': None,
|
|
'deleted': False,
|
|
'id': 123,
|
|
'uuid': uuids.service,
|
|
'host': 'fake-host',
|
|
'binary': 'nova-compute',
|
|
'topic': 'fake-service-topic',
|
|
'report_count': 1,
|
|
'forced_down': False,
|
|
'disabled': False,
|
|
'disabled_reason': None,
|
|
'last_seen_up': None,
|
|
'version': 1}
|
|
|
|
expected_payload = {
|
|
'nova_object.name': 'TestNotificationPayload',
|
|
'nova_object.data': {
|
|
'extra_field': 'test string',
|
|
'field_1': 'test1',
|
|
'field_2': 15,
|
|
'lazy_field': 42},
|
|
'nova_object.version': '1.0',
|
|
'nova_object.namespace': 'nova'}
|
|
|
|
def setUp(self):
|
|
super(TestNotificationBase, self).setUp()
|
|
with mock.patch('nova.db.service_update') as mock_db_service_update:
|
|
self.service_obj = objects.Service(context=mock.sentinel.context,
|
|
id=self.fake_service['id'])
|
|
self.service_obj.obj_reset_changes(['version'])
|
|
mock_db_service_update.return_value = self.fake_service
|
|
self.service_obj.save()
|
|
|
|
self.my_obj = self.TestObject(not_important_field=13)
|
|
self.my_obj.field_1 = 'test1'
|
|
self.my_obj.field_2 = 15
|
|
|
|
self.payload = self.TestNotificationPayload(
|
|
extra_field='test string', source_field=self.my_obj)
|
|
|
|
self.notification = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE,
|
|
phase=fields.NotificationPhase.START),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=self.payload)
|
|
|
|
def _verify_notification(self, mock_notifier, mock_context,
|
|
expected_event_type,
|
|
expected_payload):
|
|
mock_notifier.prepare.assert_called_once_with(
|
|
publisher_id='nova-compute:fake-host')
|
|
mock_notify = mock_notifier.prepare.return_value.info
|
|
self.assertTrue(mock_notify.called)
|
|
self.assertEqual(mock_notify.call_args[0][0], mock_context)
|
|
self.assertEqual(mock_notify.call_args[1]['event_type'],
|
|
expected_event_type)
|
|
actual_payload = mock_notify.call_args[1]['payload']
|
|
self.assertJsonEqual(expected_payload, actual_payload)
|
|
|
|
@mock.patch('nova.rpc.LEGACY_NOTIFIER')
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_emit_notification(self, mock_notifier, mock_legacy):
|
|
|
|
mock_context = mock.Mock()
|
|
mock_context.to_dict.return_value = {}
|
|
self.notification.emit(mock_context)
|
|
|
|
self._verify_notification(
|
|
mock_notifier,
|
|
mock_context,
|
|
expected_event_type='test_object.update.start',
|
|
expected_payload=self.expected_payload)
|
|
self.assertFalse(mock_legacy.called)
|
|
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_emit_with_host_and_binary_as_publisher(self, mock_notifier):
|
|
noti = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher(
|
|
host='fake-host',
|
|
source='nova-compute'),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=self.payload)
|
|
|
|
mock_context = mock.Mock()
|
|
mock_context.to_dict.return_value = {}
|
|
noti.emit(mock_context)
|
|
|
|
self._verify_notification(
|
|
mock_notifier,
|
|
mock_context,
|
|
expected_event_type='test_object.update',
|
|
expected_payload=self.expected_payload)
|
|
|
|
@mock.patch('nova.rpc.LEGACY_NOTIFIER')
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_emit_event_type_without_phase(self, mock_notifier, mock_legacy):
|
|
noti = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=self.payload)
|
|
|
|
mock_context = mock.Mock()
|
|
mock_context.to_dict.return_value = {}
|
|
noti.emit(mock_context)
|
|
|
|
self._verify_notification(
|
|
mock_notifier,
|
|
mock_context,
|
|
expected_event_type='test_object.update',
|
|
expected_payload=self.expected_payload)
|
|
self.assertFalse(mock_legacy.called)
|
|
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_not_possible_to_emit_if_not_populated(self, mock_notifier):
|
|
payload = self.TestNotificationPayload(
|
|
extra_field='test string', source_field=self.my_obj)
|
|
payload.populated = False
|
|
|
|
noti = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=payload)
|
|
|
|
mock_context = mock.Mock()
|
|
self.assertRaises(AssertionError, noti.emit, mock_context)
|
|
self.assertFalse(mock_notifier.called)
|
|
|
|
def test_lazy_load_source_field(self):
|
|
my_obj = self.TestObject(not_important_field=13)
|
|
my_obj.field_1 = 'test1'
|
|
my_obj.field_2 = 15
|
|
|
|
payload = self.TestNotificationPayload(extra_field='test string',
|
|
source_field=my_obj)
|
|
|
|
self.assertEqual(42, payload.lazy_field)
|
|
|
|
def test_uninited_source_field_defaulted_to_none(self):
|
|
my_obj = self.TestObject(not_important_field=13)
|
|
# intentionally not initializing field_1 to simulate an uninited but
|
|
# nullable field
|
|
my_obj.field_2 = 15
|
|
|
|
payload = self.TestNotificationPayload(extra_field='test string',
|
|
source_field=my_obj)
|
|
|
|
self.assertIsNone(payload.field_1)
|
|
|
|
def test_uninited_source_field_not_nullable_payload_field_fails(self):
|
|
my_obj = self.TestObject(not_important_field=13)
|
|
# intentionally not initializing field_2 to simulate an uninited no
|
|
# nullable field
|
|
my_obj.field_1 = 'test1'
|
|
|
|
self.assertRaises(ValueError, self.TestNotificationPayload,
|
|
extra_field='test string', source_field=my_obj)
|
|
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_empty_schema(self, mock_notifier):
|
|
non_populated_payload = self.TestNotificationPayloadEmptySchema(
|
|
extra_field='test string')
|
|
noti = self.TestNotificationEmptySchema(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=non_populated_payload)
|
|
|
|
mock_context = mock.Mock()
|
|
mock_context.to_dict.return_value = {}
|
|
noti.emit(mock_context)
|
|
|
|
self._verify_notification(
|
|
mock_notifier,
|
|
mock_context,
|
|
expected_event_type='test_object.update',
|
|
expected_payload=
|
|
{'nova_object.name': 'TestNotificationPayloadEmptySchema',
|
|
'nova_object.data': {'extra_field': u'test string'},
|
|
'nova_object.version': '1.0',
|
|
'nova_object.namespace': 'nova'})
|
|
|
|
def test_sample_decorator(self):
|
|
self.assertEqual(2, len(self.TestNotification.samples))
|
|
self.assertIn('test-update-1.json', self.TestNotification.samples)
|
|
self.assertIn('test-update-2.json', self.TestNotification.samples)
|
|
|
|
@mock.patch('nova.notifications.objects.base.NotificationBase._emit')
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
def test_payload_is_not_generated_if_notifier_is_not_enabled(
|
|
self, mock_notifier, mock_emit):
|
|
mock_notifier.is_enabled.return_value = False
|
|
|
|
payload = self.TestNotificationPayload(
|
|
extra_field='test string',
|
|
source_field=self.my_obj)
|
|
noti = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=payload)
|
|
|
|
mock_context = mock.Mock()
|
|
|
|
noti.emit(mock_context)
|
|
|
|
self.assertFalse(payload.populated)
|
|
self.assertFalse(mock_emit.called)
|
|
|
|
@mock.patch('nova.notifications.objects.base.NotificationBase._emit')
|
|
def test_payload_is_not_generated_if_notification_format_is_unversioned(
|
|
self, mock_emit):
|
|
self.flags(notification_format='unversioned', group='notifications')
|
|
|
|
payload = self.TestNotificationPayload(
|
|
extra_field='test string',
|
|
source_field=self.my_obj)
|
|
noti = self.TestNotification(
|
|
event_type=notification.EventType(
|
|
object='test_object',
|
|
action=fields.NotificationAction.UPDATE),
|
|
publisher=notification.NotificationPublisher.from_service_obj(
|
|
self.service_obj),
|
|
priority=fields.NotificationPriority.INFO,
|
|
payload=payload)
|
|
|
|
mock_context = mock.Mock()
|
|
|
|
noti.emit(mock_context)
|
|
|
|
self.assertFalse(payload.populated)
|
|
self.assertFalse(mock_emit.called)
|
|
|
|
notification_object_data = {
|
|
'AggregateNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'AggregatePayload': '1.1-1eb9adcc4440d8627de6ec37c6398746',
|
|
'AuditPeriodPayload': '1.0-2b429dd307b8374636703b843fa3f9cb',
|
|
'BandwidthPayload': '1.0-ee2616a7690ab78406842a2b68e34130',
|
|
'BlockDevicePayload': '1.0-29751e1b6d41b1454e36768a1e764df8',
|
|
'EventType': '1.8-0f8fb2dbc76f10c7c56d1680c65ad0cf',
|
|
'ExceptionNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'ExceptionPayload': '1.0-27db46ee34cd97e39f2643ed92ad0cc5',
|
|
'FlavorNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'FlavorPayload': '1.4-2e7011b8b4e59167fe8b7a0a81f0d452',
|
|
'InstanceActionNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionPayload': '1.5-fb2804ce9b681bfb217e729153c22611',
|
|
'InstanceActionRescueNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionRescuePayload': '1.0-a29f3339d0b8c3bcc997ab5d19d898d5',
|
|
'InstanceActionResizePrepNotification':
|
|
'1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionResizePrepPayload': '1.0-3a23d3dd6516964a51c256b2f8b4646c',
|
|
'InstanceActionVolumeNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionVolumePayload': '1.3-f175b22ac6d6d0aea2bac21e12156e77',
|
|
'InstanceActionVolumeSwapNotification':
|
|
'1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionVolumeSwapPayload': '1.5-bccb88cda36276d20a9b3e427b999929',
|
|
'InstanceCreateNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceCreatePayload': '1.7-a35b2f3aa64dcc262ebb830e78939bdb',
|
|
'InstancePayload': '1.5-201d852973dbcb5caab89082a3140487',
|
|
'InstanceActionSnapshotNotification':
|
|
'1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceActionSnapshotPayload': '1.6-6f96ad137957d802aac94c90337fd950',
|
|
'InstanceStateUpdatePayload': '1.0-07e111c0fa0f6db0f79b0726d593e3da',
|
|
'InstanceUpdateNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'InstanceUpdatePayload': '1.6-9145c7cac4208eb841ceaaa9c10b2d9b',
|
|
'IpPayload': '1.0-8ecf567a99e516d4af094439a7632d34',
|
|
'KeypairNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'KeypairPayload': '1.0-6daebbbde0e1bf35c1556b1ecd9385c1',
|
|
'NotificationPublisher': '2.2-b6ad48126247e10b46b6b0240e52e614',
|
|
'ServerGroupNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'ServerGroupPayload': '1.0-eb4bd1738b4670cfe1b7c30344c143c3',
|
|
'ServiceStatusNotification': '1.0-a73147b93b520ff0061865849d3dfa56',
|
|
'ServiceStatusPayload': '1.1-7b6856bd879db7f3ecbcd0ca9f35f92f',
|
|
}
|
|
|
|
|
|
class TestNotificationObjectVersions(test.NoDBTestCase):
|
|
def setUp(self):
|
|
super(TestNotificationObjectVersions, self).setUp()
|
|
base.NovaObjectRegistry.register_notification_objects()
|
|
|
|
def test_versions(self):
|
|
checker = fixture.ObjectVersionChecker(
|
|
test_objects.get_nova_objects())
|
|
notification_object_data.update(test_objects.object_data)
|
|
expected, actual = checker.test_hashes(notification_object_data,
|
|
extra_data_func=get_extra_data)
|
|
self.assertEqual(expected, actual,
|
|
'Some notification objects have changed; please make '
|
|
'sure the versions have been bumped, and then update '
|
|
'their hashes here.')
|
|
|
|
def test_notification_payload_version_depends_on_the_schema(self):
|
|
@base.NovaObjectRegistry.register_if(False)
|
|
class TestNotificationPayload(notification.NotificationPayloadBase):
|
|
VERSION = '1.0'
|
|
|
|
SCHEMA = {
|
|
'field_1': ('source_field', 'field_1'),
|
|
'field_2': ('source_field', 'field_2'),
|
|
}
|
|
|
|
fields = {
|
|
'extra_field': fields.StringField(), # filled by ctor
|
|
'field_1': fields.StringField(), # filled by the schema
|
|
'field_2': fields.IntegerField(), # filled by the schema
|
|
}
|
|
|
|
checker = fixture.ObjectVersionChecker(
|
|
{'TestNotificationPayload': (TestNotificationPayload,)})
|
|
|
|
old_hash = checker.get_hashes(extra_data_func=get_extra_data)
|
|
TestNotificationPayload.SCHEMA['field_3'] = ('source_field',
|
|
'field_3')
|
|
new_hash = checker.get_hashes(extra_data_func=get_extra_data)
|
|
|
|
self.assertNotEqual(old_hash, new_hash)
|
|
|
|
|
|
def get_extra_data(obj_class):
|
|
extra_data = tuple()
|
|
|
|
# Get the SCHEMA items to add to the fingerprint
|
|
# if we are looking at a notification
|
|
if issubclass(obj_class, notification.NotificationPayloadBase):
|
|
schema_data = collections.OrderedDict(
|
|
sorted(obj_class.SCHEMA.items()))
|
|
|
|
extra_data += (schema_data,)
|
|
|
|
return extra_data
|
|
|
|
|
|
class TestInstanceNotification(test.NoDBTestCase):
|
|
def setUp(self):
|
|
super(TestInstanceNotification, self).setUp()
|
|
self.test_keys = ['memory_mb', 'vcpus', 'root_gb', 'ephemeral_gb',
|
|
'swap']
|
|
self.flavor_values = {k: 123 for k in self.test_keys}
|
|
instance_values = {k: 456 for k in self.test_keys}
|
|
flavor = objects.Flavor(flavorid='test-flavor', name='test-flavor',
|
|
disabled=False, projects=[], is_public=True,
|
|
extra_specs={}, **self.flavor_values)
|
|
info_cache = objects.InstanceInfoCache(
|
|
network_info=network_model.NetworkInfo())
|
|
self.instance = objects.Instance(
|
|
flavor=flavor,
|
|
info_cache=info_cache,
|
|
metadata={},
|
|
uuid=uuids.instance1,
|
|
locked=False,
|
|
auto_disk_config=False,
|
|
**instance_values)
|
|
self.payload = {
|
|
'bandwidth': {},
|
|
'audit_period_ending': timeutils.utcnow(),
|
|
'audit_period_beginning': timeutils.utcnow(),
|
|
}
|
|
|
|
@mock.patch('nova.notifications.objects.instance.'
|
|
'InstanceUpdateNotification._emit')
|
|
def test_send_version_instance_update_uses_flavor(self, mock_emit):
|
|
# instance.update notification needs some tags value to avoid lazy-load
|
|
self.instance.tags = objects.TagList()
|
|
# Make sure that the notification payload chooses the values in
|
|
# instance.flavor.$value instead of instance.$value
|
|
notification_base._send_versioned_instance_update(
|
|
mock.MagicMock(),
|
|
self.instance,
|
|
self.payload,
|
|
'host',
|
|
'compute')
|
|
payload = mock_emit.call_args_list[0][1]['payload']['nova_object.data']
|
|
flavor_payload = payload['flavor']['nova_object.data']
|
|
data = {k: flavor_payload[k] for k in self.test_keys}
|
|
self.assertEqual(self.flavor_values, data)
|
|
|
|
@mock.patch('nova.rpc.NOTIFIER')
|
|
@mock.patch('nova.notifications.objects.instance.'
|
|
'InstanceUpdatePayload.__init__', return_value=None)
|
|
@mock.patch('nova.notifications.objects.instance.'
|
|
'InstanceUpdateNotification.__init__', return_value=None)
|
|
def test_send_versioned_instance_notification_is_not_called_disabled(
|
|
self, mock_notification, mock_payload, mock_notifier):
|
|
mock_notifier.is_enabled.return_value = False
|
|
|
|
notification_base._send_versioned_instance_update(
|
|
mock.MagicMock(),
|
|
self.instance,
|
|
self.payload,
|
|
'host',
|
|
'compute')
|
|
|
|
self.assertFalse(mock_payload.called)
|
|
self.assertFalse(mock_notification.called)
|
|
|
|
@mock.patch('nova.notifications.objects.instance.'
|
|
'InstanceUpdatePayload.__init__', return_value=None)
|
|
@mock.patch('nova.notifications.objects.instance.'
|
|
'InstanceUpdateNotification.__init__', return_value=None)
|
|
def test_send_versioned_instance_notification_is_not_called_unversioned(
|
|
self, mock_notification, mock_payload):
|
|
self.flags(notification_format='unversioned', group='notifications')
|
|
|
|
notification_base._send_versioned_instance_update(
|
|
mock.MagicMock(),
|
|
self.instance,
|
|
self.payload,
|
|
'host',
|
|
'compute')
|
|
|
|
self.assertFalse(mock_payload.called)
|
|
self.assertFalse(mock_notification.called)
|
|
|
|
|
|
class TestBlockDevicePayload(test.NoDBTestCase):
|
|
@mock.patch('nova.objects.instance.Instance.get_bdms')
|
|
def test_payload_contains_volume_bdms_if_requested(self, mock_get_bdms):
|
|
self.flags(bdms_in_notifications='True', group='notifications')
|
|
context = mock.Mock()
|
|
instance = instance_obj.Instance(uuid=uuids.instance_uuid)
|
|
image_bdm = objects.BlockDeviceMapping(
|
|
**{'context': context, 'source_type': 'image',
|
|
'destination_type': 'local',
|
|
'image_id': uuids.image_id,
|
|
'volume_id': None,
|
|
'device_name': '/dev/vda',
|
|
'instance_uuid': instance.uuid})
|
|
|
|
volume_bdm = objects.BlockDeviceMapping(
|
|
**{'context': context, 'source_type': 'volume',
|
|
'destination_type': 'volume',
|
|
'volume_id': uuids.volume_id,
|
|
'device_name': '/dev/vdb',
|
|
'instance_uuid': instance.uuid,
|
|
'boot_index': 0,
|
|
'delete_on_termination': True,
|
|
'tag': 'my-tag'})
|
|
|
|
mock_get_bdms.return_value = [image_bdm, volume_bdm]
|
|
|
|
bdms = instance_notification.BlockDevicePayload.from_instance(
|
|
instance)
|
|
|
|
self.assertEqual(1, len(bdms))
|
|
bdm = bdms[0]
|
|
self.assertIsInstance(bdm, instance_notification.BlockDevicePayload)
|
|
self.assertEqual('/dev/vdb', bdm.device_name)
|
|
self.assertEqual(0, bdm.boot_index)
|
|
self.assertTrue(bdm.delete_on_termination)
|
|
self.assertEqual('my-tag', bdm.tag)
|
|
self.assertEqual(uuids.volume_id, bdm.volume_id)
|
|
|
|
@mock.patch('nova.objects.instance.Instance.get_bdms',
|
|
return_value=mock.NonCallableMock())
|
|
def test_bdms_are_skipped_by_default(self, mock_get_bdms):
|
|
instance = instance_obj.Instance(uuid=uuids.instance_uuid)
|
|
bmds = instance_notification.BlockDevicePayload.from_instance(
|
|
instance)
|
|
self.assertIsNone(bmds)
|