nova/nova/tests/unit
Matthew Booth 642c986f06 Don't check flavor disk size when booting from volume
When creating a volume from an image, cinder copies the image metadata
into volume properties. When booting from the volume, we read this
metadata from the volume and use it as image metadata once again.

While fixing the check against min_ram,
change I861a78b5c7efa71e4bf7206d388b8d0d8048c78e introduced a
regression which prevents a user from booting a volume which is larger
than the flavor's disk. As we are not creating this disk, this check
does not make sense. Similarly, it checks the image metadata's
min_disk against the flavor disk size, which is not being used.

This change leaves the image metadata check unaltered when creating a
flavor disk. When booting from a volume, we check min_disk from image
metadata against the actual size of the volume. We don't check the
volume size at all. The check against min_ram is retained unaltered.

Closes-Bug: #1457517
Closes-Bug: #1459491
Closes-Bug: #1466305
Change-Id: I264493172da20b664df571e32876030246c2a87c
2015-08-12 15:45:19 +01:00
..
api Merge "New nova API call to mark nova-compute down" 2015-08-06 05:31:25 +00:00
cells Switch to the oslo_utils.fileutils 2015-07-24 14:10:44 +03:00
cert Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
cmd Make BaseProxyTestCase.test_proxy deterministic wrt traffic/verbose 2015-08-03 13:26:08 -07:00
compute Don't check flavor disk size when booting from volume 2015-08-12 15:45:19 +01:00
conductor Merge "Retry live migration on pre-check failure" 2015-08-05 00:52:35 +00:00
console Fix noVNC console access for an IPv6 setup 2015-06-15 09:23:25 +00:00
consoleauth Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
db Merge "Remove legacy flavor compatibility code from Instance" 2015-08-05 03:46:15 +00:00
fake_loadables
image Merge "Get py34 subunit.run test discovery to work" 2015-07-31 13:23:55 +00:00
keymgr Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
monkey_patch_example
network Neutron: add in API method for updating VNIC index 2015-08-03 23:11:32 -07:00
objects Merge "objects: add hw_vif_multiqueue_enabled image property" 2015-08-05 19:47:46 +00:00
pci cleanup NovaObjectDictCompat subclassing from pci_device 2015-07-21 23:30:34 +05:30
scheduler Enable python34 tests for nova/tests/unit/scheduler/test*.py 2015-07-28 10:40:36 +00:00
servicegroup Service group drivers forced_down flag utilization 2015-07-31 15:43:36 +02:00
ssl_cert
virt Merge "allow live migration in case of a booted from volume instance" 2015-08-06 05:55:52 +00:00
volume Try luksFormat up to 3 times in case the device is in use 2015-07-01 13:08:47 -07:00
README.rst
__init__.py
cast_as_call.py Replace fanout to False for CastAsCall fixture 2015-03-02 15:46:22 +01:00
conf_fixture.py Test fixture for the api database 2015-03-18 10:06:03 -04:00
fake_block_device.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_crypto.py Adds cleanup on v2.2 keypair api and tests 2015-03-24 17:06:18 +02:00
fake_flavor.py Make resize api of compute manager to send flavor object 2015-06-18 00:58:26 +08:00
fake_hosts.py Change queries for network services to use binary instead of topic 2015-03-04 10:32:45 -08:00
fake_instance.py Fix up instance flavor usage in compute and network tests 2015-06-22 11:16:55 -07:00
fake_ldap.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
fake_network.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
fake_network_cache_model.py
fake_notifier.py Add serialization of context to FakeNotifier 2015-03-31 23:20:03 +00:00
fake_pci_device_pools.py Add numa_node field to PciDevicePool 2015-04-13 16:30:45 +01:00
fake_policy.py Adding user_id handling to keypair index, show and create api calls 2015-08-04 16:34:24 -07:00
fake_processutils.py Use oslo.log 2015-02-22 07:56:40 -05:00
fake_server_actions.py
fake_utils.py
fake_volume.py Cleanup unused method fake_set_snapshot_id 2015-07-10 02:22:07 +00:00
image_fixtures.py
matchers.py Fix Python 3 issues in nova.db.sqlalchemy 2015-06-30 07:06:54 -07:00
policy_fixture.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_api_validation.py Add json-schema for v2.1 fixed-ips 2015-04-01 18:39:16 +08:00
test_availability_zones.py Replace unicode with six.text_type 2015-05-12 12:31:20 +02:00
test_baserpc.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_bdm.py
test_block_device.py snapshot: Add device_name to the snapshot bdms 2015-07-02 13:45:36 +01:00
test_cinder.py
test_configdrive2.py Switch to the oslo_utils.fileutils 2015-07-24 14:10:44 +03:00
test_context.py Removed unused variables 2015-05-20 14:31:33 +03:00
test_crypto.py Replace openssl calls with cryptography lib 2015-07-27 14:41:44 -07:00
test_exception.py Port test_exception to Python 3 2015-07-03 11:17:45 +02:00
test_fixtures.py Block subtractive operations in migrations for Kilo and beyond 2015-06-30 19:56:43 -07:00
test_flavors.py Support flavor object in migrate_disk_and_power_off 2015-06-19 02:50:26 +08:00
test_hacking.py Remove unnecessary oslo namespace import checks 2015-07-23 11:01:19 +00:00
test_hooks.py Fix improper use of Stevedore 2015-02-05 09:15:45 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py Replace dict.itervalues() with six.itervalues(dict) 2015-05-12 12:21:46 +02:00
test_ipv6.py
test_loadables.py
test_matchers.py fixed tests in test_matchers to pass with random PYTHONHASHSEED 2015-04-20 11:59:36 +03:00
test_metadata.py Metadata: support proxying loadbalancers 2015-08-04 03:55:44 -07:00
test_notifications.py Handle InstanceNotFound when sending instance update notification 2015-06-11 12:26:00 -07:00
test_nova_manage.py Get py34 subunit.run test discovery to work 2015-07-28 10:40:56 +00:00
test_objectstore.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_pipelib.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_policy.py Get py34 subunit.run test discovery to work 2015-07-28 10:40:56 +00:00
test_quota.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
test_safeutils.py Avoid indexing into an empty list in getcallargs 2015-04-10 13:10:16 -04:00
test_service.py Switch to oslo.service library 2015-07-11 02:54:42 +00:00
test_test.py return more details on assertJsonEqual fail 2015-07-30 10:25:56 -04:00
test_test_utils.py
test_utils.py Merge "Fixed typos in self parameter" 2015-07-30 10:45:02 +00:00
test_versions.py Fix version unit test on Python 3 2015-05-25 13:33:59 +02:00
test_weights.py Skip only one host weight calculation 2015-05-05 11:40:09 +08:00
test_wsgi.py Skip socket related unit tests on OSX 2015-03-26 18:33:42 -04:00
utils.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎