nova/nova/tests/unit
jichenjc 6abb88befe Check flavor type before add tenant access
Currently we allow tenant access for public flavor, however,
we can't query it after that because flavor is public.
This patch adds check for add access function to raise exception
if the flavor is public.

Also, a nit change is use methods introduced in
793bcc07b9 to get flavor.

APIImpact: Adds new 2.7 API microversion due to new error condition
           in flavor access API
Implements blueprint check-flavor-type-before-add-tenant
Closes-Bug: #1361476

Change-Id: I461175e9969a0dd5b2b7ef75ea7d9f36f3a306d0
2015-07-24 15:36:29 +03:00
..
api Check flavor type before add tenant access 2015-07-24 15:36:29 +03:00
cells Cells: cell scheduler anti-affinity filter 2015-06-22 12:00:03 -04:00
cert Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
cmd Switch to oslo.reports 2015-07-23 00:36:01 +03:00
compute Merge "Execute _poll_shelved_instances only if shelved_offload_time is > 0" 2015-07-23 19:38:54 +00:00
conductor Merge "Remove and deprecate conductor task_log methods" 2015-07-18 22:02:41 +00:00
console Fix noVNC console access for an IPv6 setup 2015-06-15 09:23:25 +00:00
consoleauth Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
db Use utf8_bin collation on the flavor extra-specs table in MySQL 2015-07-21 15:02:53 -05:00
fake_loadables
image Switch to oslo.service library 2015-07-11 02:54:42 +00:00
keymgr Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
monkey_patch_example Enable check for H238 rule 2015-01-20 18:05:47 +03:00
network Merge "Build Neutron network data for metadata service" 2015-07-11 01:33:21 +00:00
objects Merge "Add VersionPredicate type of field" 2015-07-23 20:03:31 +00:00
pci Add unit tests for PCI utils 2015-06-18 16:55:26 -04:00
scheduler Merge "Make NoValidHost exceptions clearer" 2015-07-14 17:41:46 +00:00
servicegroup fix "down" nova-compute service spuriously marked as "up" 2015-06-10 13:18:06 -06:00
ssl_cert
virt Merge "libvirt: make unit tests concise by setup guest object" 2015-07-24 08:27:11 +00:00
volume Make unit tests inherit from test.NoDBTestCase 2015-03-06 09:46:31 +02:00
README.rst
__init__.py
cast_as_call.py Replace fanout to False for CastAsCall fixture 2015-03-02 15:46:22 +01:00
conf_fixture.py Test fixture for the api database 2015-03-18 10:06:03 -04:00
fake_block_device.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_crypto.py Adds cleanup on v2.2 keypair api and tests 2015-03-24 17:06:18 +02:00
fake_flavor.py Make resize api of compute manager to send flavor object 2015-06-18 00:58:26 +08:00
fake_hosts.py Change queries for network services to use binary instead of topic 2015-03-04 10:32:45 -08:00
fake_instance.py Fix up instance flavor usage in compute and network tests 2015-06-22 11:16:55 -07:00
fake_ldap.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
fake_network.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
fake_network_cache_model.py
fake_notifier.py Add serialization of context to FakeNotifier 2015-03-31 23:20:03 +00:00
fake_pci_device_pools.py Add numa_node field to PciDevicePool 2015-04-13 16:30:45 +01:00
fake_policy.py Remove db layer hard-code permission checks for quota_class_create/update 2015-07-14 20:50:08 +08:00
fake_processutils.py Use oslo.log 2015-02-22 07:56:40 -05:00
fake_server_actions.py
fake_utils.py
fake_volume.py Cleanup unused method fake_set_snapshot_id 2015-07-10 02:22:07 +00:00
image_fixtures.py
matchers.py Fix Python 3 issues in nova.db.sqlalchemy 2015-06-30 07:06:54 -07:00
policy_fixture.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_api_validation.py Add json-schema for v2.1 fixed-ips 2015-04-01 18:39:16 +08:00
test_availability_zones.py Replace unicode with six.text_type 2015-05-12 12:31:20 +02:00
test_baserpc.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_bdm.py
test_block_device.py snapshot: Add device_name to the snapshot bdms 2015-07-02 13:45:36 +01:00
test_cinder.py
test_configdrive2.py Revert "Add config drive support for Virtuozzo containers" 2015-07-23 00:15:56 +10:00
test_context.py Removed unused variables 2015-05-20 14:31:33 +03:00
test_crypto.py Port crypto to Python 3 2015-07-10 10:42:32 +02:00
test_exception.py Port test_exception to Python 3 2015-07-03 11:17:45 +02:00
test_fixtures.py Block subtractive operations in migrations for Kilo and beyond 2015-06-30 19:56:43 -07:00
test_flavors.py Support flavor object in migrate_disk_and_power_off 2015-06-19 02:50:26 +08:00
test_hacking.py Add a hacking rule for consistent HTTP501 message 2015-06-08 03:06:49 +00:00
test_hooks.py Fix improper use of Stevedore 2015-02-05 09:15:45 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py Replace dict.itervalues() with six.itervalues(dict) 2015-05-12 12:21:46 +02:00
test_ipv6.py
test_linuxscsi.py Fix multipath device discovery when UFN is enabled. 2015-04-02 13:23:49 +01:00
test_loadables.py
test_matchers.py fixed tests in test_matchers to pass with random PYTHONHASHSEED 2015-04-20 11:59:36 +03:00
test_metadata.py Include project_id in instance metadata. 2015-07-10 16:42:43 -05:00
test_notifications.py Handle InstanceNotFound when sending instance update notification 2015-06-11 12:26:00 -07:00
test_nova_manage.py Remove flavor migration from db_api and nova-manage 2015-07-06 06:58:33 -07:00
test_objectstore.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_pipelib.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_policy.py
test_quota.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
test_safeutils.py Avoid indexing into an empty list in getcallargs 2015-04-10 13:10:16 -04:00
test_service.py Switch to oslo.service library 2015-07-11 02:54:42 +00:00
test_test.py test: add MatchType helper class as equivalent of mox.IsA 2015-06-17 12:16:43 +01:00
test_test_utils.py
test_utils.py Fix Python 3 issues in nova.utils and nova.tests 2015-07-16 10:17:42 +02:00
test_versions.py Fix version unit test on Python 3 2015-05-25 13:33:59 +02:00
test_weights.py Skip only one host weight calculation 2015-05-05 11:40:09 +08:00
test_wsgi.py Skip socket related unit tests on OSX 2015-03-26 18:33:42 -04:00
utils.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎