f85b2b84aa
PCI stats will also include device_type in it's pools, in order to meet the request specs. Changing the request device_type allowed values to match the values defined in nova.fields.PciDeviceType Supporting a device_type in a pci requests specs will allow the users to explicitly request pci devices by it's type, i.e. PF or a VF Some SR-IOV cards expose the same device_id for both PFs and VFs Due to this fact PFs will be filtered out for the available pools unless it has been explicitly requested. While keeping track of the number of available physical functions in the pci pools, this change will also update the dependent virtual functions count and remove it from the pools, when PF is allocated. Physical function will be removed from the pools when one of it's VFs is allocated. DocImpact Partially implements blueprint sriov-physical-function-passthrough Change-Id: If631d828fbad37a3dd9a61f4d5f9856b6e2f9cfc
210 lines
7.2 KiB
Python
210 lines
7.2 KiB
Python
# Copyright 2013 Intel Corporation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Tests for PCI request."""
|
|
|
|
from nova import exception
|
|
from nova.pci import request
|
|
from nova import test
|
|
|
|
|
|
_fake_alias1 = """{
|
|
"name": "QuicAssist",
|
|
"capability_type": "pci",
|
|
"product_id": "4443",
|
|
"vendor_id": "8086",
|
|
"device_type": "type-PCI"
|
|
}"""
|
|
|
|
_fake_alias11 = """{
|
|
"name": "QuicAssist",
|
|
"capability_type": "pci",
|
|
"product_id": "4444",
|
|
"vendor_id": "8086",
|
|
"device_type": "type-PCI"
|
|
}"""
|
|
|
|
_fake_alias2 = """{
|
|
"name": "xxx",
|
|
"capability_type": "pci",
|
|
"product_id": "1111",
|
|
"vendor_id": "1111",
|
|
"device_type": "N"
|
|
}"""
|
|
|
|
_fake_alias3 = """{
|
|
"name": "IntelNIC",
|
|
"capability_type": "pci",
|
|
"product_id": "1111",
|
|
"vendor_id": "8086",
|
|
"device_type": "type-PF"
|
|
}"""
|
|
|
|
|
|
class AliasTestCase(test.NoDBTestCase):
|
|
def test_good_alias(self):
|
|
self.flags(pci_alias=[_fake_alias1])
|
|
als = request._get_alias_from_config()
|
|
self.assertIsInstance(als['QuicAssist'], list)
|
|
expect_dict = {
|
|
"capability_type": "pci",
|
|
"product_id": "4443",
|
|
"vendor_id": "8086",
|
|
"dev_type": "type-PCI"
|
|
}
|
|
self.assertEqual(expect_dict, als['QuicAssist'][0])
|
|
|
|
def test_multispec_alias(self):
|
|
self.flags(pci_alias=[_fake_alias1, _fake_alias11])
|
|
als = request._get_alias_from_config()
|
|
self.assertIsInstance(als['QuicAssist'], list)
|
|
expect_dict1 = {
|
|
"capability_type": "pci",
|
|
"product_id": "4443",
|
|
"vendor_id": "8086",
|
|
"dev_type": "type-PCI"
|
|
}
|
|
expect_dict2 = {
|
|
"capability_type": "pci",
|
|
"product_id": "4444",
|
|
"vendor_id": "8086",
|
|
"dev_type": "type-PCI"
|
|
}
|
|
|
|
self.assertEqual(expect_dict1, als['QuicAssist'][0])
|
|
self.assertEqual(expect_dict2, als['QuicAssist'][1])
|
|
|
|
def test_wrong_type_aliase(self):
|
|
self.flags(pci_alias=[_fake_alias2])
|
|
self.assertRaises(exception.PciInvalidAlias,
|
|
request._get_alias_from_config)
|
|
|
|
def test_wrong_product_id_aliase(self):
|
|
self.flags(pci_alias=[
|
|
"""{
|
|
"name": "xxx",
|
|
"capability_type": "pci",
|
|
"product_id": "g111",
|
|
"vendor_id": "1111",
|
|
"device_type": "NIC"
|
|
}"""])
|
|
self.assertRaises(exception.PciInvalidAlias,
|
|
request._get_alias_from_config)
|
|
|
|
def test_wrong_vendor_id_aliase(self):
|
|
self.flags(pci_alias=[
|
|
"""{
|
|
"name": "xxx",
|
|
"capability_type": "pci",
|
|
"product_id": "1111",
|
|
"vendor_id": "0xg111",
|
|
"device_type": "NIC"
|
|
}"""])
|
|
self.assertRaises(exception.PciInvalidAlias,
|
|
request._get_alias_from_config)
|
|
|
|
def test_wrong_cap_type_aliase(self):
|
|
self.flags(pci_alias=[
|
|
"""{
|
|
"name": "xxx",
|
|
"capability_type": "usb",
|
|
"product_id": "1111",
|
|
"vendor_id": "8086",
|
|
"device_type": "NIC"
|
|
}"""])
|
|
self.assertRaises(exception.PciInvalidAlias,
|
|
request._get_alias_from_config)
|
|
|
|
def test_dup_aliase(self):
|
|
self.flags(pci_alias=[
|
|
"""{
|
|
"name": "xxx",
|
|
"capability_type": "pci",
|
|
"product_id": "1111",
|
|
"vendor_id": "8086",
|
|
"device_type": "NIC"
|
|
}""",
|
|
"""{
|
|
"name": "xxx",
|
|
"capability_type": "pci",
|
|
"product_id": "1111",
|
|
"vendor_id": "8086",
|
|
"device_type": "type-PCI"
|
|
}"""])
|
|
self.assertRaises(
|
|
exception.PciInvalidAlias,
|
|
request._get_alias_from_config)
|
|
|
|
def _verify_result(self, expected, real):
|
|
exp_real = zip(expected, real)
|
|
for exp, real in exp_real:
|
|
self.assertEqual(exp['count'], real.count)
|
|
self.assertEqual(exp['alias_name'], real.alias_name)
|
|
self.assertEqual(exp['spec'], real.spec)
|
|
|
|
def test_aliase_2_request(self):
|
|
self.flags(pci_alias=[_fake_alias1, _fake_alias3])
|
|
expect_request = [
|
|
{'count': 3,
|
|
'spec': [{'vendor_id': '8086', 'product_id': '4443',
|
|
'dev_type': 'type-PCI',
|
|
'capability_type': 'pci'}],
|
|
'alias_name': 'QuicAssist'},
|
|
|
|
{'count': 1,
|
|
'spec': [{'vendor_id': '8086', 'product_id': '1111',
|
|
'dev_type': "type-PF",
|
|
'capability_type': 'pci'}],
|
|
'alias_name': 'IntelNIC'}, ]
|
|
|
|
requests = request._translate_alias_to_requests(
|
|
"QuicAssist : 3, IntelNIC: 1")
|
|
self.assertEqual(set([p['count'] for p in requests]), set([1, 3]))
|
|
self._verify_result(expect_request, requests)
|
|
|
|
def test_aliase_2_request_invalid(self):
|
|
self.flags(pci_alias=[_fake_alias1, _fake_alias3])
|
|
self.assertRaises(exception.PciRequestAliasNotDefined,
|
|
request._translate_alias_to_requests,
|
|
"QuicAssistX : 3")
|
|
|
|
def test_get_pci_requests_from_flavor(self):
|
|
self.flags(pci_alias=[_fake_alias1, _fake_alias3])
|
|
expect_request = [
|
|
{'count': 3,
|
|
'spec': [{'vendor_id': '8086', 'product_id': '4443',
|
|
'dev_type': "type-PCI",
|
|
'capability_type': 'pci'}],
|
|
'alias_name': 'QuicAssist'},
|
|
|
|
{'count': 1,
|
|
'spec': [{'vendor_id': '8086', 'product_id': '1111',
|
|
'dev_type': "type-PF",
|
|
'capability_type': 'pci'}],
|
|
'alias_name': 'IntelNIC'}, ]
|
|
|
|
flavor = {'extra_specs': {"pci_passthrough:alias":
|
|
"QuicAssist:3, IntelNIC: 1"}}
|
|
requests = request.get_pci_requests_from_flavor(flavor)
|
|
self.assertEqual(set([1, 3]),
|
|
set([p.count for p in requests.requests]))
|
|
self._verify_result(expect_request, requests.requests)
|
|
|
|
def test_get_pci_requests_from_flavor_no_extra_spec(self):
|
|
self.flags(pci_alias=[_fake_alias1, _fake_alias3])
|
|
flavor = {}
|
|
requests = request.get_pci_requests_from_flavor(flavor)
|
|
self.assertEqual([], requests.requests)
|