c8ad9f4e19
In Pike, we began setting disk unit values manually for the 'virtio-scsi' controller model in order to allow up to 256 devices [1]. We do this by setting the disk unit of the address tag manually for the guest config. If we do not set the address tag manually, libvirt would autogenerate it for us. A problem occurs when a user has a SCSI disk that is a volume or isn't using the 'virtio-scsi' controller model because we're not guarding our manual setting of the address tag in the guest config by the disk unit, in addition to the SCSI bus. This means that for a SCSI volume, we generate an address tag like '<address type="drive" controller="0"/>' for any SCSI volume, so a user with more than one device will get the following error when they try to boot an instance: Failed to start libvirt guest: libvirtError: unsupported configuration: Found duplicate drive address for disk with target name 'sda' controller='0' bus='0' target='0' unit='0' This updates the conditionals to only manually set the address tag if the bus is SCSI _and_ the disk unit has been specified. Otherwise, let libvirt autogenerate the address tag and take care of avoiding collisions. [1] https://bugs.launchpad.net/nova/+bug/1686116 Closes-Bug: #1792077 Change-Id: Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d (cherry picked from commit48fd81648a
) (cherry picked from commit7500c1910c
) (cherry picked from commit8703282508
)
174 lines
6.5 KiB
Python
174 lines
6.5 KiB
Python
# Copyright 2011 OpenStack Foundation
|
|
# (c) Copyright 2013 Hewlett-Packard Development Company, L.P.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Volume drivers for libvirt."""
|
|
|
|
from oslo_log import log as logging
|
|
|
|
|
|
import nova.conf
|
|
from nova import exception
|
|
from nova import profiler
|
|
from nova.virt import block_device as driver_block_device
|
|
from nova.virt.libvirt import config as vconfig
|
|
import nova.virt.libvirt.driver
|
|
from nova.virt.libvirt import utils as libvirt_utils
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
CONF = nova.conf.CONF
|
|
|
|
|
|
@profiler.trace_cls("volume_api")
|
|
class LibvirtBaseVolumeDriver(object):
|
|
"""Base class for volume drivers."""
|
|
def __init__(self, host, is_block_dev):
|
|
self.host = host
|
|
self.is_block_dev = is_block_dev
|
|
|
|
def get_config(self, connection_info, disk_info):
|
|
"""Returns xml for libvirt."""
|
|
conf = vconfig.LibvirtConfigGuestDisk()
|
|
conf.driver_name = libvirt_utils.pick_disk_driver_name(
|
|
self.host.get_version(),
|
|
self.is_block_dev
|
|
)
|
|
|
|
conf.source_device = disk_info['type']
|
|
conf.driver_format = "raw"
|
|
conf.driver_cache = "none"
|
|
conf.target_dev = disk_info['dev']
|
|
conf.target_bus = disk_info['bus']
|
|
conf.serial = connection_info.get('serial')
|
|
|
|
# Support for block size tuning
|
|
data = {}
|
|
if 'data' in connection_info:
|
|
data = connection_info['data']
|
|
if 'logical_block_size' in data:
|
|
conf.logical_block_size = data['logical_block_size']
|
|
if 'physical_block_size' in data:
|
|
conf.physical_block_size = data['physical_block_size']
|
|
|
|
# Extract rate_limit control parameters
|
|
if 'qos_specs' in data and data['qos_specs']:
|
|
tune_opts = ['total_bytes_sec', 'read_bytes_sec',
|
|
'write_bytes_sec', 'total_iops_sec',
|
|
'read_iops_sec', 'write_iops_sec']
|
|
specs = data['qos_specs']
|
|
if isinstance(specs, dict):
|
|
for k, v in specs.items():
|
|
if k in tune_opts:
|
|
new_key = 'disk_' + k
|
|
setattr(conf, new_key, v)
|
|
else:
|
|
LOG.warning('Unknown content in connection_info/'
|
|
'qos_specs: %s', specs)
|
|
|
|
# Extract access_mode control parameters
|
|
if 'access_mode' in data and data['access_mode']:
|
|
access_mode = data['access_mode']
|
|
if access_mode in ('ro', 'rw'):
|
|
conf.readonly = access_mode == 'ro'
|
|
else:
|
|
LOG.error('Unknown content in '
|
|
'connection_info/access_mode: %s',
|
|
access_mode)
|
|
raise exception.InvalidVolumeAccessMode(
|
|
access_mode=access_mode)
|
|
|
|
# Configure usage of discard
|
|
if data.get('discard', False) is True:
|
|
conf.driver_discard = 'unmap'
|
|
|
|
# NOTE(melwitt): We set the device address unit number manually in the
|
|
# case of the virtio-scsi controller, in order to allow attachment of
|
|
# up to 256 devices. So, we should only be setting the address tag
|
|
# if we intend to set the unit number. Otherwise, we will let libvirt
|
|
# handle autogeneration of the address tag.
|
|
# See https://bugs.launchpad.net/nova/+bug/1792077 for details.
|
|
if disk_info['bus'] == 'scsi' and 'unit' in disk_info:
|
|
# The driver is responsible to create the SCSI controller
|
|
# at index 0.
|
|
conf.device_addr = vconfig.LibvirtConfigGuestDeviceAddressDrive()
|
|
conf.device_addr.controller = 0
|
|
# In order to allow up to 256 disks handled by one
|
|
# virtio-scsi controller, the device addr should be
|
|
# specified.
|
|
conf.device_addr.unit = disk_info['unit']
|
|
|
|
if connection_info.get('multiattach', False):
|
|
# Note that driver_cache should be disabled (none) when using
|
|
# a shareable disk.
|
|
conf.shareable = True
|
|
|
|
volume_id = driver_block_device.get_volume_id(connection_info)
|
|
volume_secret = None
|
|
if volume_id:
|
|
volume_secret = self.host.find_secret('volume', volume_id)
|
|
if volume_secret:
|
|
conf.encryption = vconfig.LibvirtConfigGuestDiskEncryption()
|
|
secret = vconfig.LibvirtConfigGuestDiskEncryptionSecret()
|
|
secret.type = 'passphrase'
|
|
secret.uuid = volume_secret.UUIDString()
|
|
conf.encryption.format = 'luks'
|
|
conf.encryption.secret = secret
|
|
|
|
return conf
|
|
|
|
def connect_volume(self, connection_info, instance):
|
|
"""Connect the volume."""
|
|
pass
|
|
|
|
def disconnect_volume(self, connection_info, instance):
|
|
"""Disconnect the volume."""
|
|
pass
|
|
|
|
def extend_volume(self, connection_info, instance):
|
|
"""Extend the volume."""
|
|
raise NotImplementedError()
|
|
|
|
|
|
class LibvirtVolumeDriver(LibvirtBaseVolumeDriver):
|
|
"""Class for volumes backed by local file."""
|
|
def __init__(self, host):
|
|
super(LibvirtVolumeDriver,
|
|
self).__init__(host, is_block_dev=True)
|
|
|
|
def get_config(self, connection_info, disk_info):
|
|
"""Returns xml for libvirt."""
|
|
conf = super(LibvirtVolumeDriver,
|
|
self).get_config(connection_info, disk_info)
|
|
conf.source_type = "block"
|
|
conf.source_path = connection_info['data']['device_path']
|
|
return conf
|
|
|
|
|
|
class LibvirtFakeVolumeDriver(LibvirtBaseVolumeDriver):
|
|
"""Driver to attach fake volumes to libvirt."""
|
|
def __init__(self, host):
|
|
super(LibvirtFakeVolumeDriver,
|
|
self).__init__(host, is_block_dev=True)
|
|
|
|
def get_config(self, connection_info, disk_info):
|
|
"""Returns xml for libvirt."""
|
|
conf = super(LibvirtFakeVolumeDriver,
|
|
self).get_config(connection_info, disk_info)
|
|
conf.source_type = "network"
|
|
conf.source_protocol = "fake"
|
|
conf.source_name = "fake"
|
|
return conf
|