521ea08467
1. Add testing context 'self.other_project_reader_context' for remaining tests. 2. Replace REQUESTED_DESTINATION policy check_str with 'PROJECT_ADMIN' so that it will easy to remove the deprecated RULE_ADMIN_API rule. Partial implement blueprint policy-defaults-refresh-deprecated-apis Change-Id: Ibf88029af32376788134427be99d219784f8e333
215 lines
9.8 KiB
Python
215 lines
9.8 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
from nova.policies import keypairs as policies
|
|
|
|
from nova.api.openstack.compute import keypairs
|
|
from nova.tests.unit.api.openstack import fakes
|
|
from nova.tests.unit.objects import test_keypair
|
|
from nova.tests.unit.policies import base
|
|
|
|
|
|
class KeypairsPolicyTest(base.BasePolicyTest):
|
|
"""Test Keypairs APIs policies with all possible context.
|
|
This class defines the set of context with different roles
|
|
which are allowed and not allowed to pass the policy checks.
|
|
With those set of context, it will call the API operation and
|
|
verify the expected behaviour.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(KeypairsPolicyTest, self).setUp()
|
|
self.controller = keypairs.KeypairController()
|
|
self.req = fakes.HTTPRequest.blank('')
|
|
|
|
# Check that everyone is able to create, delete and get
|
|
# their keypairs.
|
|
self.everyone_authorized_contexts = [
|
|
self.legacy_admin_context, self.system_admin_context,
|
|
self.project_admin_context,
|
|
self.system_member_context, self.system_reader_context,
|
|
self.system_foo_context, self.project_member_context,
|
|
self.project_reader_context, self.project_foo_context,
|
|
self.other_project_member_context,
|
|
self.other_project_reader_context,
|
|
]
|
|
self.everyone_unauthorized_contexts = []
|
|
|
|
# Check that admin is able to create, delete and get
|
|
# other users keypairs.
|
|
self.admin_authorized_contexts = [
|
|
self.legacy_admin_context, self.system_admin_context,
|
|
self.project_admin_context]
|
|
# Check that non-admin is not able to create, delete and get
|
|
# other users keypairs.
|
|
self.admin_unauthorized_contexts = [
|
|
self.system_member_context, self.system_reader_context,
|
|
self.system_foo_context, self.project_member_context,
|
|
self.project_reader_context, self.project_foo_context,
|
|
self.other_project_member_context,
|
|
self.other_project_reader_context,
|
|
]
|
|
|
|
# Check that system reader is able to get
|
|
# other users keypairs.
|
|
self.system_reader_authorized_contexts = [
|
|
self.legacy_admin_context, self.system_admin_context,
|
|
self.project_admin_context, self.system_member_context,
|
|
self.system_reader_context]
|
|
# Check that non-system reader is not able to get
|
|
# other users keypairs.
|
|
self.system_reader_unauthorized_contexts = [
|
|
self.system_foo_context, self.project_member_context,
|
|
self.project_reader_context, self.project_foo_context,
|
|
self.other_project_member_context,
|
|
self.other_project_reader_context,
|
|
]
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.get_key_pairs')
|
|
def test_index_keypairs_policy(self, mock_get):
|
|
rule_name = policies.POLICY_ROOT % 'index'
|
|
self.common_policy_check(self.everyone_authorized_contexts,
|
|
self.everyone_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.index,
|
|
self.req)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.get_key_pairs')
|
|
def test_index_others_keypairs_policy(self, mock_get):
|
|
req = fakes.HTTPRequest.blank('?user_id=user2', version='2.10')
|
|
rule_name = policies.POLICY_ROOT % 'index'
|
|
self.common_policy_check(self.system_reader_authorized_contexts,
|
|
self.system_reader_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.index,
|
|
req)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.get_key_pair')
|
|
def test_show_keypairs_policy(self, mock_get):
|
|
rule_name = policies.POLICY_ROOT % 'show'
|
|
self.common_policy_check(self.everyone_authorized_contexts,
|
|
self.everyone_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.show,
|
|
self.req, fakes.FAKE_UUID)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.get_key_pair')
|
|
def test_show_others_keypairs_policy(self, mock_get):
|
|
# Change the user_id in request context.
|
|
req = fakes.HTTPRequest.blank('?user_id=user2', version='2.10')
|
|
rule_name = policies.POLICY_ROOT % 'show'
|
|
self.common_policy_check(self.system_reader_authorized_contexts,
|
|
self.system_reader_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.show,
|
|
req, fakes.FAKE_UUID)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.create_key_pair')
|
|
def test_create_keypairs_policy(self, mock_create):
|
|
rule_name = policies.POLICY_ROOT % 'create'
|
|
mock_create.return_value = (test_keypair.fake_keypair, 'FAKE_KEY')
|
|
self.common_policy_check(self.everyone_authorized_contexts,
|
|
self.everyone_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.create,
|
|
self.req,
|
|
body={'keypair': {'name': 'create_test'}})
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.create_key_pair')
|
|
def test_create_others_keypairs_policy(self, mock_create):
|
|
# Change the user_id in request context.
|
|
req = fakes.HTTPRequest.blank('', version='2.10')
|
|
rule_name = policies.POLICY_ROOT % 'create'
|
|
mock_create.return_value = (test_keypair.fake_keypair, 'FAKE_KEY')
|
|
body = {'keypair': {'name': 'test2', 'user_id': 'user2'}}
|
|
self.common_policy_check(self.admin_authorized_contexts,
|
|
self.admin_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.create,
|
|
req, body=body)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.delete_key_pair')
|
|
def test_delete_keypairs_policy(self, mock_delete):
|
|
rule_name = policies.POLICY_ROOT % 'delete'
|
|
self.common_policy_check(self.everyone_authorized_contexts,
|
|
self.everyone_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.delete,
|
|
self.req, fakes.FAKE_UUID)
|
|
|
|
@mock.patch('nova.compute.api.KeypairAPI.delete_key_pair')
|
|
def test_delete_others_keypairs_policy(self, mock_delete):
|
|
# Change the user_id in request context.
|
|
req = fakes.HTTPRequest.blank('?user_id=user2', version='2.10')
|
|
rule_name = policies.POLICY_ROOT % 'delete'
|
|
self.common_policy_check(self.admin_authorized_contexts,
|
|
self.admin_unauthorized_contexts,
|
|
rule_name,
|
|
self.controller.delete,
|
|
req, fakes.FAKE_UUID)
|
|
|
|
|
|
class KeypairsScopeTypePolicyTest(KeypairsPolicyTest):
|
|
"""Test Keypairs APIs policies with system scope enabled.
|
|
This class set the nova.conf [oslo_policy] enforce_scope to True
|
|
so that we can switch on the scope checking on oslo policy side.
|
|
It defines the set of context with scoped token
|
|
which are allowed and not allowed to pass the policy checks.
|
|
With those set of context, it will run the API operation and
|
|
verify the expected behaviour.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(KeypairsScopeTypePolicyTest, self).setUp()
|
|
self.flags(enforce_scope=True, group="oslo_policy")
|
|
|
|
|
|
class KeypairsNoLegacyPolicyTest(KeypairsScopeTypePolicyTest):
|
|
"""Test Keypairs APIs policies with system scope enabled,
|
|
and no more deprecated rules that allow the legacy admin API to
|
|
access system APIs.
|
|
"""
|
|
without_deprecated_rules = True
|
|
|
|
def setUp(self):
|
|
super(KeypairsNoLegacyPolicyTest, self).setUp()
|
|
|
|
# Check that system admin is able to create, delete and get
|
|
# other users keypairs.
|
|
self.admin_authorized_contexts = [
|
|
self.system_admin_context]
|
|
# Check that system non-admin is not able to create, delete and get
|
|
# other users keypairs.
|
|
self.admin_unauthorized_contexts = [
|
|
self.legacy_admin_context, self.system_member_context,
|
|
self.system_reader_context, self.system_foo_context,
|
|
self.project_admin_context, self.project_member_context,
|
|
self.other_project_member_context,
|
|
self.other_project_reader_context,
|
|
self.project_foo_context, self.project_reader_context
|
|
]
|
|
# Check that system reader is able to get
|
|
# other users keypairs.
|
|
self.system_reader_authorized_contexts = [
|
|
self.system_admin_context, self.system_member_context,
|
|
self.system_reader_context]
|
|
# Check that non-system reader is not able to get
|
|
# other users keypairs.
|
|
self.system_reader_unauthorized_contexts = [
|
|
self.legacy_admin_context, self.project_admin_context,
|
|
self.system_foo_context, self.project_member_context,
|
|
self.project_reader_context, self.project_foo_context,
|
|
self.other_project_member_context,
|
|
self.other_project_reader_context,
|
|
]
|