nova/nova/tests/unit
Qin Zhao 7f293ec49c Ensure to store context in thread local after spawn/spawn_n
https://review.openstack.org/#/c/171299/ introduces a wrapper for utils.spawn_n
to update context in thread local store. However, there are other routines in
driver code which calls greenthread.spawn or greenthread.spawn_n, so that they
will not update context in thread local store. The commit adds utils.spawn as a
new wrapper, and also make those codes call spawn/spawn_n of utils, in order to
ensure the context of logging is correct.

Change-Id: I3623e60c49e442e2431cf017540422aa59bc285a
Related-Bug: 1404268
2015-06-03 14:44:05 +00:00
..
api Merge "Cleanups for pci stats in preparation for RT using ComputeNode" 2015-06-03 03:02:57 +00:00
cells Merge "Fix cells capacity calculation for n:1 virt drivers" 2015-06-01 20:50:06 +00:00
cert Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
cmd Don't query compute_node through service object in nova-manage 2015-04-21 09:36:39 +02:00
compute bdm: Make sure that delete_on_termination is a boolean 2015-06-02 10:51:23 +01:00
conductor Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
console websocketproxy: Make protocol validation use connection_info 2015-04-09 11:26:25 +01:00
consoleauth Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
db Make nova-manage handle completely missing flavor information 2015-06-01 15:56:44 -07:00
fake_loadables
functional
image Merge "Removed twice declared variables" 2015-04-29 19:40:27 +00:00
keymgr Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
monkey_patch_example
network Merge "network: fix instance cache refresh for empty list" 2015-06-03 04:23:06 +00:00
objects Merge "Add nova object equivalence based on prims" 2015-06-03 03:03:22 +00:00
pci Merge "Cleanups for pci stats in preparation for RT using ComputeNode" 2015-06-03 03:02:57 +00:00
scheduler Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
servicegroup servicegroup: remove get_all method never used as public 2015-05-07 03:50:05 -04:00
ssl_cert
virt Ensure to store context in thread local after spawn/spawn_n 2015-06-03 14:44:05 +00:00
volume Make unit tests inherit from test.NoDBTestCase 2015-03-06 09:46:31 +02:00
README.rst
__init__.py
cast_as_call.py Replace fanout to False for CastAsCall fixture 2015-03-02 15:46:22 +01:00
conf_fixture.py Test fixture for the api database 2015-03-18 10:06:03 -04:00
fake_block_device.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_crypto.py Adds cleanup on v2.2 keypair api and tests 2015-03-24 17:06:18 +02:00
fake_hosts.py Change queries for network services to use binary instead of topic 2015-03-04 10:32:45 -08:00
fake_instance.py Add EC2Ids object and link to Instance object as optional attribute 2015-04-12 00:50:19 +02:00
fake_ldap.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
fake_network.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
fake_network_cache_model.py
fake_notifier.py Add serialization of context to FakeNotifier 2015-03-31 23:20:03 +00:00
fake_pci_device_pools.py Add numa_node field to PciDevicePool 2015-04-13 16:30:45 +01:00
fake_policy.py Add policy to cover snapshotting of volume backed instances 2015-05-14 13:53:21 +00:00
fake_processutils.py Use oslo.log 2015-02-22 07:56:40 -05:00
fake_server_actions.py
fake_utils.py
fake_volume.py Removed twice declared variables 2015-04-29 15:26:50 +03:00
image_fixtures.py
matchers.py fixed tests in test_matchers to pass with random PYTHONHASHSEED 2015-04-20 11:59:36 +03:00
policy_fixture.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_api_validation.py Add json-schema for v2.1 fixed-ips 2015-04-01 18:39:16 +08:00
test_availability_zones.py Replace unicode with six.text_type 2015-05-12 12:31:20 +02:00
test_baserpc.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_bdm.py
test_block_device.py bdm: Make sure that delete_on_termination is a boolean 2015-06-02 10:51:23 +01:00
test_cinder.py
test_configdrive2.py Compute: update config drive settings on instance 2015-03-04 08:46:43 -08:00
test_context.py Removed unused variables 2015-05-20 14:31:33 +03:00
test_crypto.py Split up and improve speed of keygen tests 2015-05-21 17:27:38 +00:00
test_exception.py
test_fixtures.py Add SpawnFixture 2015-05-07 13:18:19 -07:00
test_flavors.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_hacking.py Drop explicit suds dependency 2015-05-22 23:40:14 -07:00
test_hooks.py Fix improper use of Stevedore 2015-02-05 09:15:45 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py Replace dict.itervalues() with six.itervalues(dict) 2015-05-12 12:21:46 +02:00
test_ipv6.py
test_linuxscsi.py Fix multipath device discovery when UFN is enabled. 2015-04-02 13:23:49 +01:00
test_loadables.py
test_matchers.py fixed tests in test_matchers to pass with random PYTHONHASHSEED 2015-04-20 11:59:36 +03:00
test_metadata.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_notifications.py Be more forgiving to empty context in notification 2015-03-31 00:00:46 +00:00
test_nova_manage.py Store cells credentials in transport_url properly 2015-03-31 00:00:20 +00:00
test_objectstore.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_pipelib.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_policy.py
test_quota.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
test_safeutils.py Avoid indexing into an empty list in getcallargs 2015-04-10 13:10:16 -04:00
test_service.py Refactor some service tests and make them not require db 2015-04-13 19:47:44 +02:00
test_test.py Added assertJsonEqual method to TestCase class 2015-03-17 20:23:15 +03:00
test_test_utils.py
test_utils.py Ensure to store context in thread local after spawn/spawn_n 2015-06-03 14:44:05 +00:00
test_versions.py Fix version unit test on Python 3 2015-05-25 13:33:59 +02:00
test_weights.py Skip only one host weight calculation 2015-05-05 11:40:09 +08:00
test_wsgi.py Skip socket related unit tests on OSX 2015-03-26 18:33:42 -04:00
utils.py Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎