This is a partial revert of commit
9606c80402 which added the 'path' query
parameter to work with noVNC v1.1.0. This broke all other console types
using websockify server (serial, spice) because the websockify server
itself doesn't know how to handle the 'path' query parameter. It is the
noVNC vnc_lite.html file which parses the 'path' variable and uses it
as the url to the websockify server. So, all other console types should
*not* be generating a console access url with a 'path' query parameter,
only noVNC.
Closes-Bug: #1845243
TODO(melwitt): Figure out how to test serial and/or spice console in
the gate
NOTE(melwitt): The difference in nova/tests/unit/console/test_websocketproxy.py
from the Train change is because change
I0498599fd636aa9e30df932f0d893db5efa23260 is not in Stein.
Change-Id: I9521f21a685edc44121d75bdf534c201fa87c2d7
(cherry picked from commit 54125a75fb)
(cherry picked from commit e736babdfe)
This part of the tree contains templates for API samples. The
documentation in doc/api_samples is completely autogenerated from the
tests in this directory.
To add a new api sample, add tests for the common passing and failing
cases in this directory for your extension, and modify test_samples.py
for your tests.
Then run the following command:
tox -e api-samples
Which will create the files on doc/api_samples.
If new tests are added or the .tpl files are changed due to bug
fixes, the samples must be regenerated so they are in sync with the
templates, as there is an additional test which reloads the
documentation and ensures that it's in sync.
Debugging sample generation
If a .tpl is changed, its matching .json must be removed else the
samples won't be generated. If an entirely new extension is added, a
directory for it must be created before its samples will be
generated.
ff29f7018f