OpenStack Compute (Nova)
Go to file
melanie witt 8703282508 libvirt: set device address tag only if setting disk unit
In Pike, we began setting disk unit values manually for the
'virtio-scsi' controller model in order to allow up to 256 devices [1].
We do this by setting the disk unit of the address tag manually for the
guest config. If we do not set the address tag manually, libvirt would
autogenerate it for us.

A problem occurs when a user has a SCSI disk that is a volume or isn't
using the 'virtio-scsi' controller model because we're not guarding our
manual setting of the address tag in the guest config by the disk unit,
in addition to the SCSI bus. This means that for a SCSI volume, we
generate an address tag like '<address type="drive" controller="0"/>'
for any SCSI volume, so a user with more than one device will get the
following error when they try to boot an instance:

  Failed to start libvirt guest: libvirtError: unsupported
    configuration: Found duplicate drive address for disk with target name
    'sda' controller='0' bus='0' target='0' unit='0'

This updates the conditionals to only manually set the address tag if
the bus is SCSI _and_ the disk unit has been specified. Otherwise, let
libvirt autogenerate the address tag and take care of avoiding
collisions.

[1] https://bugs.launchpad.net/nova/+bug/1686116

Closes-Bug: #1792077

NOTE(melwitt): The difference in test_imagebackend.py from the Stein
backport is because change I28c5bc23c0ea60d64153472d8937965f60f907c4
is not in Rocky.

Change-Id: Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d
(cherry picked from commit 48fd81648a)
(cherry picked from commit 7500c1910c)
2019-04-18 15:56:28 +00:00
api-guide/source Fix none-ascii char in doc 2018-08-07 00:13:00 +00:00
api-ref/source Merge "Update the parameter explain when updating a volume attachment" 2018-08-09 17:44:47 +00:00
contrib trivial: Remove "vif" script 2017-08-07 16:00:10 +01:00
devstack Skip test_resize_server_revert_with_volume_attached in nova-lvm 2018-07-19 12:22:18 -04:00
doc Merge "doc: Capitalize keystone domain name" into stable/rocky 2019-04-11 18:33:20 +00:00
etc/nova Add osprofiler config options to generated reference 2018-06-16 12:46:19 +00:00
gate Make nova-manage db purge take --all-cells 2018-03-08 09:26:49 -08:00
nova libvirt: set device address tag only if setting disk unit 2019-04-18 15:56:28 +00:00
placement-api-ref [placement] api-ref: add description for 1.29 2018-08-09 02:56:30 +00:00
playbooks/legacy Replace openstack.org git:// URLs with https:// 2019-03-24 20:34:46 +00:00
releasenotes Merge "pass endpoint interface to Ironic client" into stable/rocky 2019-03-21 15:59:11 +00:00
tools Convert 'placement_api_docs' into a Sphinx extension 2018-07-02 11:21:47 +01:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
.gitreview Update .gitreview for stable/rocky 2018-08-10 09:53:45 +00:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.stestr.conf Finish stestr migration 2017-11-24 16:51:12 -05:00
.zuul.yaml Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree 2019-03-01 08:50:52 -05:00
CONTRIBUTING.rst Update links in documents 2018-01-12 17:05:11 +08:00
HACKING.rst Removed unnecessary parantheses in yield statements 2018-03-07 16:44:36 +09:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Fix broken URLs 2017-09-07 15:42:31 +02:00
README.rst Docs: modernise links 2018-03-24 20:27:11 +08:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt Merge "Bindep does not catch missing libpcre3-dev on Ubuntu" 2018-02-14 07:31:09 +00:00
lower-constraints.txt Use ThreadPoolExecutor for max_concurrent_live_migrations 2018-07-16 13:57:09 -04:00
requirements.txt Merge "Blacklist greenlet 0.4.14" 2018-07-24 16:06:41 +00:00
setup.cfg Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
setup.py Updated from global requirements 2017-03-02 11:50:48 +00:00
test-requirements.txt Cleanup ugly stub in TestLocalDeleteAllocations 2018-05-16 09:23:55 -04:00
tests-py3.txt Remove mox in unit/virt/xenapi/test_vmops.py 2018-05-06 22:31:05 +00:00
tox.ini tox: Don't write byte code (maybe) 2019-02-14 10:40:26 +00:00

README.rst

Team and repository tags

image

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.

Use the following resources to learn more.

API

To learn how to use Nova's API, consult the documentation available online at:

For more information on OpenStack APIs, SDKs and CLIs in general, refer to:

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

Other Information

During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: