nova/nova/tests/unit
Matt Riedemann 8921a470ee Avoid unnecessary joins in delete_resource_provider
If cascade=True, we're getting all of the instances on the
compute node just to use the uuid, which will by default
join on the info_cache and security_groups for the instances.
This is a simple optimization to avoid those unnecessary joins.

A TODO is left to further optimize this with a new InstanceList
query method to just get the instance uuids on a given host/node
combo, but that requires an RPC change which we can't backport.

Change-Id: Ie121210456a240c257979d3269db115ddae2d23b
Related-Bug: #1811726
Related-Bug: #1756179
2019-06-13 15:03:02 -04:00
..
api Delete resource providers for all nodes when deleting compute service 2019-06-13 14:58:20 -04:00
cells Remove 'instance_update_at_top', 'instance_destroy_at_top' 2019-05-02 08:32:05 -06:00
cmd Stop handling cells v1 for console authentication 2019-04-16 18:26:17 +01:00
compute Remove 'instance_update_at_top', 'instance_destroy_at_top' 2019-05-02 08:32:05 -06:00
conductor Merge "Only call _fill_provider_mapping if claim succeeds" 2019-05-02 12:53:47 +00:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Stop handling cells v1 for console authentication 2019-04-16 18:26:17 +01:00
consoleauth Stop handling cells v1 for console authentication 2019-04-16 18:26:17 +01:00
db Merge "Add get_compute_nodes_by_host_or_node()" 2019-05-01 21:32:16 +00:00
fake_loadables
image Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00
keymgr
network Merge "Remove deprecated 'default_flavor' config option" 2019-05-02 00:46:59 +00:00
notifications Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00
objects Remove 'instance_update_at_top', 'instance_destroy_at_top' 2019-05-02 08:32:05 -06:00
pci Add get_instance_pci_request_from_vif 2019-03-07 11:37:53 +02:00
privsep Add test coverage for nova.privsep.qemu. 2019-04-04 20:44:01 +00:00
scheduler Avoid unnecessary joins in delete_resource_provider 2019-06-13 15:03:02 -04:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt Merge "libvirt: Avoid using os-brick encryptors when device_path isn't provided" 2019-04-29 22:03:48 +00:00
volume Add compute API validation for when a volume_type is requested 2018-10-11 16:04:53 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py libvirt: Start populating NUMACell.network_metadata field 2018-07-24 15:33:49 +01:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
test_availability_zones.py Always pass HostAPI to get_availability_zones 2019-04-26 15:30:48 -04:00
test_baserpc.py
test_block_device.py Add method to generate device names universally 2019-01-15 18:55:11 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Configure placement DB context manager for nova-manage/status 2018-09-05 10:29:48 -04:00
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Remove NovaException logging from scatter_gather_cells 2018-11-21 12:43:35 -05:00
test_crypto.py
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Add context.target_cell() stub to DownCellFixture 2019-02-15 14:39:20 -05:00
test_flavors.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_hacking.py Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Merge "Remove deprecated 'default_flavor' config option" 2019-05-02 00:46:59 +00:00
test_notifications.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_notifier.py
test_nova_manage.py Merge "Use aggregate_add_host in nova-manage" 2019-04-29 08:38:04 +00:00
test_policy.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
test_profiler.py
test_quota.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_rpc.py test_rpc: Stop f****** with global state 2019-04-26 12:21:16 +01:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Switch to using os-resource-classes 2019-02-07 11:11:09 +00:00
test_versions.py
test_weights.py Per aggregate scheduling weight 2019-01-21 11:48:44 +08:00
test_wsgi.py
utils.py Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎