ca8f4be2a8
Several existing tests patch open() to fake the contents of a file
outside the test virtualenv, whilst avoiding interfering with reading
and writing of other files inside the test virtualenv. Currently they
do it by duplicating logic.
Furthermore, in the near future, more tests (specifically, some SEV
tests) will want to do the same selective patching, and similarly will
need to avoid impacting reads of other files within the test
virtualenv, e.g. placement-policy.yaml.
So create new patch_open() context manager / decorator in nova.test
for selectively patching open based on the path parameter, and reuse
this for existing tests.
Also add unit tests for all these cases.
mock >= 3.0.0 is required because configparser.RawConfigParser._read()
uses enumerate() to iterate over the lines of the (mocked)
/etc/nova/release config file, and this uses __iter__() under the hood
which was not supported via mock_open until a bug was fixed and
backported to the external mock library for 3.0.0:
https://bugs.python.org/issue21258
https://bugs.python.org/issue32933
73f6eed0d6
Change-Id: I19f49c923d2c41eab0c7b4cab28c50498dc07046
52 lines
1.9 KiB
Python
52 lines
1.9 KiB
Python
# Copyright 2011 Ken Pepple
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo_config import cfg
|
|
|
|
from nova import test
|
|
from nova import version
|
|
|
|
|
|
class VersionTestCase(test.NoDBTestCase):
|
|
"""Test cases for Versions code."""
|
|
|
|
def test_version_string_with_package_is_good(self):
|
|
"""Ensure uninstalled code get version string."""
|
|
|
|
self.stub_out('nova.version.version_info.version_string',
|
|
lambda: '5.5.5.5')
|
|
self.stub_out('nova.version.NOVA_PACKAGE', 'g9ec3421')
|
|
self.assertEqual("5.5.5.5-g9ec3421",
|
|
version.version_string_with_package())
|
|
|
|
@test.patch_open("/etc/nova/release", read_data=
|
|
"[Nova]\n"
|
|
"vendor = ACME Corporation\n"
|
|
"product = ACME Nova\n"
|
|
"package = 1337\n")
|
|
def test_release_file(self):
|
|
version.loaded = False
|
|
real_find_file = cfg.CONF.find_file
|
|
|
|
def fake_find_file(self, name):
|
|
if name == "release":
|
|
return "/etc/nova/release"
|
|
return real_find_file(self, name)
|
|
|
|
self.stub_out('oslo_config.cfg.ConfigOpts.find_file', fake_find_file)
|
|
|
|
self.assertEqual(version.vendor_string(), "ACME Corporation")
|
|
self.assertEqual(version.product_string(), "ACME Nova")
|
|
self.assertEqual(version.package_string(), "1337")
|