openstack
/
nova
Code Issues Proposed changes
OpenStack Compute (Nova)
36,616 Commits 9 Branches 80 Tags 1.6 GiB
Python 97.7%
Smarty 2.2%
Shell 0.1%
Go to file
Matt Riedemann 9369aab04e Don't expect meta attributes in object_compat that aren't in the db obj 
The object_compat decorator expects to get the Instance object with
'metadata' and 'system_metadata' attributes but if those aren't in the
db instance dict object, Instance._from_db_object will fail with a
KeyError.

In Kilo this happens per refresh_instance_security_rules because in the
compute API code, the instance passed to refresh_instance_security_rules
comes from the call to get the security group(s) which joins on the
instances column, but that doesn't join on the metadata/system_metadata
fields for the instances.  So when the instances get to object_compat in
the compute manager and the db instance dict is converted to the
Instance object, it expects fields that aren't in the dict and we get
the KeyError.

The refresh_instance_security_rules case is fixed in Liberty per commit
12fbe6f082 - in that case the compute API
passes Instance objects to the compute manager so object_compat doesn't
have anything to do, _load_instance just sees instance_or_dict isn't a
dict and ignores it.

We're making this change since (1) it's an obviously wrong assumption in
object_compat and should be fixed and (2) we need to backport this fix
to stable/kilo since it's an upgrade impact for users there.

Closes-Bug: #1484738

Change-Id: I36a954c095a9aa35879200784dc18e35edf689e6
 		2015-09-09 20:29:09 -07:00
contrib Merge "changed quantum to neutron in vif-openstack" 2014-03-05 10:45:05 +00:00
devstack Merge "Remove the blacklisted nova-cells shelve tests" 2015-09-06 11:58:28 +00:00
doc Merge "Add migration policy to upgrades devref" 2015-09-04 13:06:16 +00:00
etc/nova Merge "Add os-brick's scsi_id command to rootwrap" 2015-09-09 17:00:52 +00:00
nova Don't expect meta attributes in object_compat that aren't in the db obj 2015-09-09 20:29:09 -07:00
plugins/xenserver Get py34 subunit.run test discovery to work 2015-07-28 10:40:56 +00:00
tools tox: make it possible to run pep8 on current patch only 2015-07-24 16:15:38 +01:00
.coveragerc Port Cheetah templates to Jinja2 2013-09-02 16:03:34 +02:00
.gitignore remove all traces of pylint testing infrastructure 2015-01-08 11:56:45 +00:00
.gitreview Add .gitreview config file for gerrit. 2011-10-24 15:07:19 -04:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.testr.conf Add tox -e functional 2014-11-12 15:31:06 -05:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst Add hacking check for greenthread.spawn() 2015-08-11 16:09:48 +00:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Add a maintainers file 2015-05-23 03:22:07 +10:00
README.rst Update links in README 2014-05-07 16:06:24 -07:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bandit.yaml Add bandit for security static analysis testing 2015-07-02 09:17:48 -07:00
openstack-common.conf Switch to the oslo_utils.fileutils 2015-07-24 14:10:44 +03:00
requirements.txt Updated from global requirements 2015-09-08 16:30:02 +00:00
run_tests.sh Fix likely undesired use of redirection 2015-02-02 16:26:31 +01:00
setup.cfg Add rootwrap daemon mode support 2015-08-21 10:34:30 -04:00
setup.py Updated from global requirements 2015-07-18 16:07:43 +00:00
test-requirements.txt Updated from global requirements 2015-09-08 16:30:02 +00:00
tox.ini Add constraint target to tox.ini 2015-09-04 15:06:11 -07:00

README.rst

OpenStack Nova README

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of virtualization technologies, including KVM, Xen, LXC, VMware, and more. In addition to its native API, it includes compatibility with the commonly encountered Amazon EC2 and S3 APIs.

OpenStack Nova is distributed under the terms of the Apache License, Version 2.0. The full terms and conditions of this license are detailed in the LICENSE file.

Nova primarily consists of a set of Python daemons, though it requires and integrates with a number of native system components for databases, messaging and virtualization capabilities.

To keep updated with new developments in the OpenStack project follow @openstack on Twitter.

To learn how to deploy OpenStack Nova, consult the documentation available online at:

http://docs.openstack.org

For information about the different compute (hypervisor) drivers supported by Nova, read this page on the wiki:

https://wiki.openstack.org/wiki/HypervisorSupportMatrix

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

http://bugs.launchpad.net/nova

Developers wishing to work on the OpenStack Nova project should always base their work on the latest Nova code, available from the master GIT repository at:

https://git.openstack.org/cgit/openstack/nova

Developers should also join the discussion on the mailing list, at:

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests. Further developer focused documentation is available at:

http://docs.openstack.org/developer/nova/

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst file.

-- End of broadcast