nova/nova/tests/unit
Matt Riedemann 95106d2fa1 Add nova-manage placement heal_allocations CLI
This adds a new CLI which will iterate all non-cell0
cells looking for instances that (1) have a host,
(2) aren't undergoing a task state transition and
(3) don't have allocations in placement and try
to allocate resources, based on the instance embedded
flavor, against the compute node resource provider
on which the instance is currently running.

This is meant as a way to help migrate CachingScheduler
users off the CachingScheduler by first shoring up
instance allocations in placement for any instances
created after Pike, when the nova-compute resource
tracker code stopped creating allocations in placement
since the FilterScheduler does it at the time of
scheduling (but the CachingScheduler doesn't).

This will be useful beyond just getting deployments
off the CachingScheduler, however, since operators
will be able to use it to fix incorrect allocations
resulting from failed operations.

There are several TODOs and NOTEs inline about things
we could build on top of this or improve, but for now
this is the basic idea.

Change-Id: Iab67fd56ab4845f8ee19ca36e7353730638efb21
2018-06-01 18:45:10 -04:00
..
api Merge "Fix HTTP500 error of changes-since on v2.0 API" 2018-05-16 00:31:45 +00:00
api_samples_test_base
cells remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
cmd Update nova-status and docs for required placement 1.24 2018-05-18 21:46:25 +00:00
compute Merge "ProviderTree.has_inventory_changed for new fields" 2018-05-19 01:38:30 +00:00
conductor Remove mox in test_live_migrate.py 2018-05-14 22:22:03 +00:00
console Convert websocketproxy to use db for token validation 2018-05-03 09:57:56 -04:00
consoleauth Fix invalid UUIDs in remaining tests 2018-01-30 17:15:03 +00:00
db Expose instance_get_all_uuids_by_host() from DB API and use it 2018-05-18 14:36:12 -07:00
fake_loadables
image Fix unit tests to work with new oslo.config 2018-03-31 15:55:51 -05:00
keymgr
network Add test_set_device_mtu_default back in 2018-05-10 13:56:55 -04:00
notifications Merge "Remove vestigial system_metadata param from info_from_instance()" 2018-04-24 10:17:27 +00:00
objects Make instance.refresh() avoid recursion better 2018-05-18 14:36:12 -07:00
pci Address nits in I46d483f9de6776db1b025f925890624e5e682ada 2018-01-02 15:57:50 +00:00
privsep Move image conversion to privsep. 2018-05-15 10:09:01 -04:00
scheduler Merge "Granular requests to get_allocation_candidates" 2018-05-19 05:22:25 +00:00
servicegroup iso8601.is8601.Utc No Longer Exists 2017-08-29 19:26:55 -04:00
ssl_cert Update SSL cert used in testing 2017-07-31 13:09:49 +10:00
virt PowerVM Driver: Localdisk 2018-05-18 21:38:09 +00:00
volume Log a more useful error when cinder auth isn't configured 2018-04-06 14:52:13 -04:00
README.rst
__init__.py Do not monkey patch eventlet in unit tests 2017-09-28 12:22:11 +01:00
cast_as_call.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
conf_fixture.py Remove placement config check 2018-04-17 20:53:08 +00:00
fake_block_device.py Make BlockDeviceMapping object support uuid 2017-12-17 16:47:30 +00:00
fake_build_request.py
fake_console_auth_token.py Add access_url_base to console_auth_tokens table 2018-01-06 02:02:26 +00:00
fake_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
fake_diagnostics.py
fake_flavor.py Add Flavor.description attribute 2017-11-05 01:24:01 -05:00
fake_hosts.py
fake_instance.py Add trusted_certs object 2018-03-29 23:00:48 -04:00
fake_ldap.py
fake_network.py
fake_network_cache_model.py
fake_notifier.py fake_notifier: Refactor wait_for_versioned_notification 2017-09-12 14:20:05 +00:00
fake_pci_device_pools.py
fake_policy.py Remove deprecated policy items from fake_policy 2018-01-27 00:01:43 +00:00
fake_processutils.py
fake_request_spec.py Add user_id to RequestSpec 2018-05-01 11:08:43 -04:00
fake_requests.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
fake_server_actions.py Add host/hostId to instance action events API 2018-04-26 14:17:02 +00:00
fake_volume.py Remove check_detach 2017-07-20 22:32:52 +02:00
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py
policy_fixture.py Reduce policy deprecation warnings in test runs 2018-01-27 00:01:43 +00:00
test_api_validation.py Fix PatternPropertiesTestCase for py 3.6 2018-02-19 11:06:45 +00:00
test_availability_zones.py Remove deprecated aggregate DB compatibility 2018-02-14 14:32:00 -08:00
test_baserpc.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_block_device.py
test_cache.py
test_cinder.py Fix bug case by none token context 2018-01-24 20:53:50 -05:00
test_conf.py
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Remove RequestContext.instance_lock_checked 2018-04-11 11:46:19 -04:00
test_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
test_exception.py Add __repr__ for NovaException 2018-04-04 20:48:54 +00:00
test_fixtures.py
test_flavors.py Remove old flavor_get_all db api method 2018-02-14 15:53:18 -05:00
test_hacking.py Fix N332 api_version decorator hacking check 2018-03-29 10:27:30 -05:00
test_hooks.py
test_identity.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Nits from Ic3ab7d60e4ac12b767fe70bef97b327545a86e74 2017-11-28 15:55:45 +01:00
test_loadables.py
test_matchers.py
test_metadata.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
test_notifications.py Remove deprecated monkey_patch config options 2018-05-16 11:40:41 -04:00
test_notifier.py
test_nova_manage.py Add nova-manage placement heal_allocations CLI 2018-06-01 18:45:10 -04:00
test_policy.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_profiler.py
test_quota.py Follow up on removing old-style quotas code 2017-12-08 22:11:24 +00:00
test_rpc.py Make TestRPC inherit from the base nova TestCase 2017-09-26 14:13:53 +00:00
test_safeutils.py Allow wrapping of closures 2017-07-20 10:07:52 +01:00
test_service.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
test_service_auth.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_test.py Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 2017-09-06 15:52:51 -04:00
test_test_utils.py
test_utils.py Remove deprecated monkey_patch config options 2018-05-16 11:40:41 -04:00
test_uuid_sentinels.py Move test_uuid_sentinels to NoDBTestCase 2017-10-12 10:58:17 -04:00
test_versions.py
test_weights.py
test_wsgi.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
utils.py Remove vestigial system_metadata param from info_from_instance() 2018-04-23 11:18:05 -04:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎