9606c80402
Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.
This modifies the ConsoleAuthToken.access_url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.
This change is backward compatible with noVNC < v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.
Co-Authored-By: melanie witt <melwittt@gmail.com>
Closes-Bug: #1822676
[1] 51f9f0098d
[2] https://github.com/novnc/noVNC/pull/1220
Change-Id: I2ddf0f4d768b698e980594dd67206464a9cea37b
8 lines
270 B
YAML
8 lines
270 B
YAML
---
|
|
fixes:
|
|
- |
|
|
Add support for noVNC >= v1.1.0 for VNC consoles. Prior to this fix, VNC
|
|
console token validation always failed regardless of actual token validity
|
|
with noVNC >= v1.1.0. See
|
|
https://bugs.launchpad.net/nova/+bug/1822676 for more details.
|