nova/nova/tests/unit
Sean Mooney 98464d54d0 stop setting mtu when plugging vhost-user ports
vhost-user is a userspace protocol to establish connectivity
between a virto-net frontend typically qemu and a
userspace virtio backend such as ovs with dpdk.

vhost-user interfaces exist only in userspace from the host perspective
and are not represented in the linux networking stack as kernel netdevs.
As a result attempting to set the mtu on a vhost-user interface
using ifconfig or ip link will fail with a device not found error.

- this change removes a call to _set_device_mtu when plugging
  vhost-user interfaces.
- this change prevents the device not found error from occurring
  which stopped vms booting with vhost-user interfaces
  due to an uncaught exception resulting in a failure to set the
  interface type in ovs.
- this change make creating vhost-user interface
  an atomic action.

This latent bug is only triggered when the mtu value is set to a
value other than 0 which was the default proir to mitaka.

Conflicts:
	nova/network/model.py
	nova/tests/unit/virt/libvirt/test_vif.py
	nova/virt/libvirt/vif.py

Change-Id: I2e17723d5052d57cd1557bd8a173c06ea0dcb2d4
Closes-Bug: #1533876
(cherry picked from commit adf7ba61dd)
2016-04-14 13:27:25 +02:00
..
api Make scheduler_hints schema allow list of id 2016-01-05 05:55:15 +00:00
cells Merge "Creating instance fail when inject ssh key in cells mode" 2015-09-14 22:19:04 +00:00
cert Fix order of arguments in assertEqual 2015-09-03 06:39:24 -07:00
cmd Make BaseProxyTestCase.test_proxy deterministic wrt traffic/verbose 2015-08-03 13:26:08 -07:00
compute Fix instance not destroyed after successful evacuation 2016-01-18 18:00:40 +01:00
conductor rebuild: RPC sends additional args and claims are done 2015-09-22 17:41:29 +01:00
console Add console allowed origins setting 2015-07-28 22:06:40 -06:00
consoleauth Use six.moves.range for Python 3 2015-05-20 15:19:51 -07:00
db Spread allocations of fixed ips 2016-02-11 06:26:41 -05:00
fake_loadables
image Ensure Glance image 'size' attribute is 0, not 'None' 2016-02-12 22:00:41 +00:00
keymgr
monkey_patch_example
network stop setting mtu when plugging vhost-user ports 2016-04-14 13:27:25 +02:00
objects Remove the TestRemoteObject class 2015-12-21 15:28:26 +00:00
pci pci: Remove nova.pci.device module 2015-08-19 12:22:00 -04:00
scheduler Don't load deleted instances 2016-01-07 14:30:34 +00:00
servicegroup servicegroup: stop zombie service due to exception 2015-12-01 11:13:57 +02:00
ssl_cert
virt stop setting mtu when plugging vhost-user ports 2016-04-14 13:27:25 +02:00
volume Consolidate code to get the correct availability zone of an instance 2015-09-09 17:14:35 +02:00
README.rst
__init__.py Move objects registration in tests directory 2015-08-24 10:21:27 -04:00
cast_as_call.py
conf_fixture.py api: deprecate the concept of extensions in v2.1 2015-08-27 13:16:09 +00:00
fake_block_device.py
fake_crypto.py Adds cleanup on v2.2 keypair api and tests 2015-03-24 17:06:18 +02:00
fake_flavor.py Make resize api of compute manager to send flavor object 2015-06-18 00:58:26 +08:00
fake_hosts.py
fake_instance.py Add Instance and InstanceList v2.0 objects 2015-09-03 19:17:37 -07:00
fake_ldap.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
fake_network.py Merge "Support Network objects in set_network_host" 2015-09-02 04:04:04 +00:00
fake_network_cache_model.py
fake_notifier.py Add serialization of context to FakeNotifier 2015-03-31 23:20:03 +00:00
fake_pci_device_pools.py Add numa_node field to PciDevicePool 2015-04-13 16:30:45 +01:00
fake_policy.py Adding user_id handling to keypair index, show and create api calls 2015-08-04 16:34:24 -07:00
fake_processutils.py
fake_server_actions.py
fake_utils.py
fake_volume.py __getitem__ method not returning value 2015-08-07 03:26:15 -07:00
image_fixtures.py
matchers.py Fix Python 3 issues in nova.db.sqlalchemy 2015-06-30 07:06:54 -07:00
policy_fixture.py Replace dict.iteritems() with six.iteritems(dict) 2015-05-22 11:33:18 -07:00
test_api_validation.py Filter leading/trailing spaces for name field in v2.1 compat mode 2015-09-23 10:27:54 +01:00
test_availability_zones.py Merge "Fix order of arguments in assertEqual" 2015-09-18 18:46:13 +00:00
test_baserpc.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_bdm.py
test_block_device.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_cinder.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_configdrive2.py Switch to the oslo_utils.fileutils 2015-07-24 14:10:44 +03:00
test_context.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_crypto.py Merge "Make test_revoke_cert_project_not_found_chdir_fails deterministic" 2015-09-23 10:49:41 +00:00
test_exception.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_fixtures.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_flavors.py Support flavor object in migrate_disk_and_power_off 2015-06-19 02:50:26 +08:00
test_hacking.py Merge "Add hacking check for greenthread.spawn()" 2015-08-13 17:09:53 +00:00
test_hooks.py
test_instance_types_extra_specs.py
test_iptables_network.py Replace dict.itervalues() with six.itervalues(dict) 2015-05-12 12:21:46 +02:00
test_ipv6.py
test_loadables.py
test_matchers.py fixed tests in test_matchers to pass with random PYTHONHASHSEED 2015-04-20 11:59:36 +03:00
test_metadata.py Revert "Fixes Python 3 str issue in ConfigDrive creation" 2016-01-07 09:47:40 -05:00
test_notifications.py Fix notify_decorator errors 2015-08-11 10:30:30 +08:00
test_nova_manage.py Get py34 subunit.run test discovery to work 2015-07-28 10:40:56 +00:00
test_objectstore.py
test_pipelib.py ensure DatabaseFixture removes db on cleanup 2015-03-12 16:55:55 -04:00
test_policy.py Add missing rules in policy.json 2015-08-13 16:03:16 +08:00
test_quota.py Fix incomplete error message of quota exceeded 2015-09-02 11:45:27 +08:00
test_safeutils.py Avoid indexing into an empty list in getcallargs 2015-04-10 13:10:16 -04:00
test_service.py Switch to oslo.service library 2015-07-11 02:54:42 +00:00
test_test.py return more details on assertJsonEqual fail 2015-07-30 10:25:56 -04:00
test_test_utils.py
test_utils.py Give instance default hostname if hostname is empty 2015-09-23 17:02:30 +08:00
test_versions.py Fix version unit test on Python 3 2015-05-25 13:33:59 +02:00
test_weights.py Skip only one host weight calculation 2015-05-05 11:40:09 +08:00
test_wsgi.py Replace eventlet-based raw socket client with requests 2016-02-09 13:39:28 -08:00
utils.py Skip SO_REUSEADDR tests on BSD 2015-08-07 14:07:23 +02:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎