8d11cba5ed
This commit checks that InstancePCIRequests is empty before passing it to the pci_stats.support_requests. This prevents doing the support request check for host_state which don't have pci_stats like ironic host. Closes-Bug: #1658078 Change-Id: Ie6d870729883e2bbdc3278c52e88d147613712f6
84 lines
3.6 KiB
Python
84 lines
3.6 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from nova import objects
|
|
from nova.pci import stats
|
|
from nova.scheduler.filters import pci_passthrough_filter
|
|
from nova import test
|
|
from nova.tests.unit.scheduler import fakes
|
|
|
|
|
|
class TestPCIPassthroughFilter(test.NoDBTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestPCIPassthroughFilter, self).setUp()
|
|
self.filt_cls = pci_passthrough_filter.PciPassthroughFilter()
|
|
|
|
def test_pci_passthrough_pass(self):
|
|
pci_stats_mock = mock.MagicMock()
|
|
pci_stats_mock.support_requests.return_value = True
|
|
request = objects.InstancePCIRequest(count=1,
|
|
spec=[{'vendor_id': '8086'}])
|
|
requests = objects.InstancePCIRequests(requests=[request])
|
|
spec_obj = objects.RequestSpec(pci_requests=requests)
|
|
host = fakes.FakeHostState(
|
|
'host1', 'node1',
|
|
attribute_dict={'pci_stats': pci_stats_mock})
|
|
self.assertTrue(self.filt_cls.host_passes(host, spec_obj))
|
|
pci_stats_mock.support_requests.assert_called_once_with(
|
|
requests.requests)
|
|
|
|
def test_pci_passthrough_fail(self):
|
|
pci_stats_mock = mock.MagicMock()
|
|
pci_stats_mock.support_requests.return_value = False
|
|
request = objects.InstancePCIRequest(count=1,
|
|
spec=[{'vendor_id': '8086'}])
|
|
requests = objects.InstancePCIRequests(requests=[request])
|
|
spec_obj = objects.RequestSpec(pci_requests=requests)
|
|
host = fakes.FakeHostState(
|
|
'host1', 'node1',
|
|
attribute_dict={'pci_stats': pci_stats_mock})
|
|
self.assertFalse(self.filt_cls.host_passes(host, spec_obj))
|
|
pci_stats_mock.support_requests.assert_called_once_with(
|
|
requests.requests)
|
|
|
|
def test_pci_passthrough_no_pci_request(self):
|
|
spec_obj = objects.RequestSpec(pci_requests=None)
|
|
host = fakes.FakeHostState('h1', 'n1', {})
|
|
self.assertTrue(self.filt_cls.host_passes(host, spec_obj))
|
|
|
|
def test_pci_passthrough_empty_pci_request_obj(self):
|
|
requests = objects.InstancePCIRequests(requests=[])
|
|
spec_obj = objects.RequestSpec(pci_requests=requests)
|
|
host = fakes.FakeHostState('h1', 'n1', {})
|
|
self.assertTrue(self.filt_cls.host_passes(host, spec_obj))
|
|
|
|
def test_pci_passthrough_no_pci_stats(self):
|
|
request = objects.InstancePCIRequest(count=1,
|
|
spec=[{'vendor_id': '8086'}])
|
|
requests = objects.InstancePCIRequests(requests=[request])
|
|
spec_obj = objects.RequestSpec(pci_requests=requests)
|
|
host = fakes.FakeHostState('host1', 'node1',
|
|
attribute_dict={'pci_stats': stats.PciDeviceStats()})
|
|
self.assertFalse(self.filt_cls.host_passes(host, spec_obj))
|
|
|
|
def test_pci_passthrough_with_pci_stats_none(self):
|
|
request = objects.InstancePCIRequest(count=1,
|
|
spec=[{'vendor_id': '8086'}])
|
|
requests = objects.InstancePCIRequests(requests=[request])
|
|
spec_obj = objects.RequestSpec(pci_requests=requests)
|
|
host = fakes.FakeHostState('host1', 'node1',
|
|
attribute_dict={'pci_stats': None})
|
|
self.assertFalse(self.filt_cls.host_passes(host, spec_obj))
|