nova/nova/tests/unit
Matt Riedemann a3b3e8d831 libvirt: wait for interface detach from the guest
The test_reassign_port_between_servers test in Tempest creates
a port in neutron and two servers. It attaches the port to the
first server and then quickly detaches it and waits for the
port.device_id to be unbound from the server. Then it repeats
that for the second server.

The interface detach from the guest is asynchronous and happens
before nova unbinds the port, so there is a race where the port's
device_id is unset but the interface is still on the first guest
when we try to attach to the second guest, which fails.

This is a latent bug, but apparently has been tickled by the
move to our neutron CI jobs to use ubuntu xenial nodes.

The fix is to add a detach and retry loop on the interface detach
on the guest so that we can wait until the interface is gone
from the guest before nova unbinds the port in neutron, which is
what the Tempest test is waiting for. Then the device should be
available for attaching to the second guest.

This is similar to what we do with detaching volumes.

Closes-Bug: #1607714

Change-Id: Ic04aad8923ea2edf1d16e32c208cd41fdf898834
2017-02-09 19:33:33 -05:00
..
api Merge "[3/3]Replace six.iteritems() with .items()" 2017-02-09 18:25:51 +00:00
api_samples_test_base Fix invalid import order 2016-07-04 16:03:42 +05:30
cells Stop using mox stubs in nova/tests/unit/cells 2016-12-26 13:31:24 +00:00
cert conf: remove deprecated cert_topic option 2016-11-23 10:53:36 -06:00
cmd nova-status: relax the resource providers check 2017-01-31 17:59:53 -05:00
compute [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
conductor Merge "Ensure build request exists before creating instance" 2017-02-02 16:44:26 +00:00
console Merge "tests: Replace use of CONF with monkey patching" 2017-01-24 12:03:07 +00:00
consoleauth [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
db [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
fake_loadables
image Merge "conf: remove deprecated image url options" 2017-02-09 12:23:19 +00:00
keymgr
monkey_patch_example
network [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
notifications Merge "Update notification for flavor" 2017-01-11 21:58:06 +00:00
objects [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
pci [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
scheduler [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
servicegroup Don't use 'updated_at' to check service's status 2016-12-08 09:51:03 +00:00
ssl_cert
virt libvirt: wait for interface detach from the guest 2017-02-09 19:33:33 -05:00
volume encryptors: Introduce encryption provider constants 2016-11-23 10:57:11 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Block starting compute unless placement conf is provided 2017-01-27 16:35:09 -08:00
fake_block_device.py Replace uuid4() with uuidsentinel 2016-10-05 18:27:50 +05:30
fake_build_request.py Create Instance from BuildRequest if not in a cell 2016-08-22 16:52:53 -04:00
fake_console_auth_token.py
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
fake_ldap.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
fake_network.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
fake_network_cache_model.py
fake_notifier.py support polling free notification testing 2016-12-05 16:16:17 +01:00
fake_pci_device_pools.py
fake_policy.py Separate CRUD policy for server_groups 2016-11-21 11:43:13 -05:00
fake_processutils.py Merge "Stop using mox in unit/fake_processutils.py" 2016-10-14 16:24:17 +00:00
fake_request_spec.py
fake_server_actions.py
fake_volume.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:24 +05:30
fake_xvp_console_proxy.py tests: Replace use of CONF with monkey patching 2017-01-06 14:54:47 +00:00
image_fixtures.py
matchers.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
policy_fixture.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
test_api_validation.py Add query parameters white list for server list/detail 2017-01-17 15:54:15 +00:00
test_availability_zones.py
test_baserpc.py conf: Remove deprecated service manager opts 2016-12-05 23:28:49 +08:00
test_block_device.py
test_cache.py
test_cinder.py Fix ksa mocking in test_cinderclient_unsupported_v1 2017-01-05 19:52:10 -05:00
test_conf.py conf: Remove 'virt' file 2016-12-21 16:45:08 +00:00
test_configdrive2.py Fixes python 3 unit tests 2016-09-23 20:10:24 +00:00
test_context.py Setup CellsV2 environment in base test 2016-12-09 10:30:43 -08:00
test_crypto.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
test_exception.py conf: remove deprecated exception option 2016-11-23 15:25:03 +00:00
test_fixtures.py Add a PlacementFixture 2017-01-20 17:41:37 +01:00
test_flavors.py Merge "Move some flavor fakes closer to where they are being used" 2016-10-18 12:13:40 +00:00
test_hacking.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
test_hash_ring.py Ironic: allow multiple compute services 2016-08-04 23:51:13 +00:00
test_hooks.py
test_instance_types_extra_specs.py objects: Move 'arch' to 'fields.Architecture' 2016-11-25 16:19:41 +00:00
test_iptables_network.py
test_ipv6.py Fix test_ipv6 and simplify to_global() 2016-06-28 20:42:32 +02:00
test_loadables.py
test_matchers.py Port test_matchers.TestDictMatches.test__str__ to Python 3 2016-12-20 11:11:44 +08:00
test_metadata.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
test_notifications.py conf: added notifications group 2017-01-03 14:38:57 +00:00
test_notifier.py conf: added notifications group 2017-01-03 14:38:57 +00:00
test_nova_manage.py Merge "Add debug possibility for nova-manage command" 2017-02-09 12:41:01 +00:00
test_pipelib.py conf: Move cloudpipe options to a group 2016-08-22 09:31:03 +01:00
test_policy.py Separate CRUD policy for server_groups 2016-11-21 11:43:13 -05:00
test_profiler.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
test_quota.py Move quota options to a config group. 2017-01-04 22:57:14 -06:00
test_rpc.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
test_safeutils.py
test_service.py Merge "test: drop unused config option fake_manager" 2016-12-12 08:41:03 +00:00
test_service_auth.py Add service_token for nova-cinder interaction 2017-01-11 15:49:16 +00:00
test_signature_utils.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_test.py Cleanup before removal of conductor local apis 2016-10-18 14:26:06 +02:00
test_test_utils.py test:Remove unused method _test_get_test_network_info 2016-09-25 16:19:29 +08:00
test_utils.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
test_uuid_sentinels.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_versions.py
test_weights.py
test_wsgi.py
utils.py Make vmware unit tests work with CONF.use_neutron=True 2016-11-30 10:14:41 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎