473 lines
18 KiB
Python
473 lines
18 KiB
Python
# Copyright 2011 Eldar Nugaev
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import webob
|
|
|
|
from nova.api.openstack.compute.plugins.v3 import keypairs
|
|
from nova import db
|
|
from nova import exception
|
|
from nova.openstack.common import jsonutils
|
|
from nova.openstack.common import policy as common_policy
|
|
from nova import policy
|
|
from nova import quota
|
|
from nova import test
|
|
from nova.tests.api.openstack import fakes
|
|
from nova.tests.objects import test_keypair
|
|
|
|
|
|
QUOTAS = quota.QUOTAS
|
|
|
|
|
|
keypair_data = {
|
|
'public_key': 'FAKE_KEY',
|
|
'fingerprint': 'FAKE_FINGERPRINT',
|
|
}
|
|
|
|
|
|
def fake_keypair(name):
|
|
return dict(test_keypair.fake_keypair,
|
|
name=name, **keypair_data)
|
|
|
|
|
|
def db_key_pair_get_all_by_user(self, user_id):
|
|
return [fake_keypair('FAKE')]
|
|
|
|
|
|
def db_key_pair_create(self, keypair):
|
|
return fake_keypair(name=keypair['name'])
|
|
|
|
|
|
def db_key_pair_destroy(context, user_id, name):
|
|
if not (user_id and name):
|
|
raise Exception()
|
|
|
|
|
|
def db_key_pair_create_duplicate(context, keypair):
|
|
raise exception.KeyPairExists(key_name=keypair.get('name', ''))
|
|
|
|
|
|
class KeypairsTest(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(KeypairsTest, self).setUp()
|
|
self.Controller = keypairs.Controller()
|
|
fakes.stub_out_networking(self.stubs)
|
|
fakes.stub_out_rate_limiting(self.stubs)
|
|
|
|
self.stubs.Set(db, "key_pair_get_all_by_user",
|
|
db_key_pair_get_all_by_user)
|
|
self.stubs.Set(db, "key_pair_create",
|
|
db_key_pair_create)
|
|
self.stubs.Set(db, "key_pair_destroy",
|
|
db_key_pair_destroy)
|
|
self.flags(
|
|
osapi_compute_extension=[
|
|
'nova.api.openstack.compute.contrib.select_extensions'],
|
|
osapi_compute_ext_list=['Keypairs'])
|
|
self.app = fakes.wsgi_app_v3(init_only=('keypairs', 'servers'))
|
|
|
|
def test_keypair_list(self):
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 200)
|
|
res_dict = jsonutils.loads(res.body)
|
|
response = {'keypairs': [{'keypair': dict(keypair_data, name='FAKE')}]}
|
|
self.assertEqual(res_dict, response)
|
|
|
|
def test_keypair_create(self):
|
|
body = {'keypair': {'name': 'create_test'}}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 201)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertTrue(len(res_dict['keypair']['fingerprint']) > 0)
|
|
self.assertTrue(len(res_dict['keypair']['private_key']) > 0)
|
|
|
|
def test_keypair_create_without_keypair(self):
|
|
body = {'foo': None}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 400)
|
|
jsonutils.loads(res.body)
|
|
|
|
def test_keypair_create_without_name(self):
|
|
body = {'keypair': {'public_key': 'public key'}}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 400)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual("Invalid input for field/attribute keypair. "
|
|
"Value: {u'public_key': u'public key'}. "
|
|
"'name' is a required property",
|
|
res_dict['badRequest']['message'])
|
|
|
|
def test_keypair_create_with_empty_name(self):
|
|
body = {'keypair': {'name': ''}}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 400)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual("Invalid input for field/attribute name. "
|
|
"Value: . u'' is too short",
|
|
res_dict['badRequest']['message'])
|
|
|
|
def test_keypair_create_with_name_too_long(self):
|
|
name = 'a' * 256
|
|
body = {
|
|
'keypair': {
|
|
'name': name
|
|
}
|
|
}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 400)
|
|
res_dict = jsonutils.loads(res.body)
|
|
expected_message = "Invalid input for field/attribute name. "\
|
|
"Value: %s. u'%s' is too long" % (name, name)
|
|
self.assertEqual(expected_message, res_dict['badRequest']['message'])
|
|
|
|
def test_keypair_create_with_non_alphanumeric_name(self):
|
|
body = {
|
|
'keypair': {
|
|
'name': 'test/keypair'
|
|
}
|
|
}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(res.status_int, 400)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(
|
|
"Invalid input for field/attribute name. Value: test/keypair. "
|
|
"u'test/keypair' does not match '^(?! )[a-zA-Z0-9. _-]+(?<! )$'",
|
|
res_dict['badRequest']['message'])
|
|
|
|
def test_keypair_import(self):
|
|
body = {
|
|
'keypair': {
|
|
'name': 'create_test',
|
|
'public_key': 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDBYIznA'
|
|
'x9D7118Q1VKGpXy2HDiKyUTM8XcUuhQpo0srqb9rboUp4'
|
|
'a9NmCwpWpeElDLuva707GOUnfaBAvHBwsRXyxHJjRaI6Y'
|
|
'Qj2oLJwqvaSaWUbyT1vtryRqy6J3TecN0WINY71f4uymi'
|
|
'MZP0wby4bKBcYnac8KiCIlvkEl0ETjkOGUq8OyWRmn7lj'
|
|
'j5SESEUdBP0JnuTFKddWTU/wD6wydeJaUhBTqOlHn0kX1'
|
|
'GyqoNTE1UEhcM5ZRWgfUZfTjVyDF2kGj3vJLCJtJ8LoGc'
|
|
'j7YaN4uPg1rBle+izwE/tLonRrds+cev8p6krSSrxWOwB'
|
|
'bHkXa6OciiJDvkRzJXzf',
|
|
},
|
|
}
|
|
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 201)
|
|
# FIXME(ja): sholud we check that public_key was sent to create?
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertTrue(len(res_dict['keypair']['fingerprint']) > 0)
|
|
self.assertNotIn('private_key', res_dict['keypair'])
|
|
|
|
def test_keypair_import_quota_limit(self):
|
|
|
|
def fake_quotas_count(self, context, resource, *args, **kwargs):
|
|
return 100
|
|
|
|
self.stubs.Set(QUOTAS, "count", fake_quotas_count)
|
|
|
|
body = {
|
|
'keypair': {
|
|
'name': 'create_test',
|
|
'public_key': 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDBYIznA'
|
|
'x9D7118Q1VKGpXy2HDiKyUTM8XcUuhQpo0srqb9rboUp4'
|
|
'a9NmCwpWpeElDLuva707GOUnfaBAvHBwsRXyxHJjRaI6Y'
|
|
'Qj2oLJwqvaSaWUbyT1vtryRqy6J3TecN0WINY71f4uymi'
|
|
'MZP0wby4bKBcYnac8KiCIlvkEl0ETjkOGUq8OyWRmn7lj'
|
|
'j5SESEUdBP0JnuTFKddWTU/wD6wydeJaUhBTqOlHn0kX1'
|
|
'GyqoNTE1UEhcM5ZRWgfUZfTjVyDF2kGj3vJLCJtJ8LoGc'
|
|
'j7YaN4uPg1rBle+izwE/tLonRrds+cev8p6krSSrxWOwB'
|
|
'bHkXa6OciiJDvkRzJXzf',
|
|
},
|
|
}
|
|
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 413)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(
|
|
"Quota exceeded, too many key pairs.",
|
|
res_dict['overLimit']['message'])
|
|
|
|
def test_keypair_create_quota_limit(self):
|
|
|
|
def fake_quotas_count(self, context, resource, *args, **kwargs):
|
|
return 100
|
|
|
|
self.stubs.Set(QUOTAS, "count", fake_quotas_count)
|
|
|
|
body = {
|
|
'keypair': {
|
|
'name': 'create_test',
|
|
},
|
|
}
|
|
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 413)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(
|
|
"Quota exceeded, too many key pairs.",
|
|
res_dict['overLimit']['message'])
|
|
|
|
def test_keypair_create_duplicate(self):
|
|
self.stubs.Set(db, "key_pair_create", db_key_pair_create_duplicate)
|
|
body = {'keypair': {'name': 'create_duplicate'}}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 409)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(
|
|
"Key pair 'create_duplicate' already exists.",
|
|
res_dict['conflictingRequest']['message'])
|
|
|
|
def test_keypair_import_bad_key(self):
|
|
body = {
|
|
'keypair': {
|
|
'name': 'create_test',
|
|
'public_key': 'ssh-what negative',
|
|
},
|
|
}
|
|
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 400)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(
|
|
'Keypair data is invalid: failed to generate fingerprint',
|
|
res_dict['badRequest']['message'])
|
|
|
|
def test_keypair_delete(self):
|
|
req = webob.Request.blank('/v3/keypairs/FAKE')
|
|
req.method = 'DELETE'
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 204)
|
|
|
|
def test_keypair_get_keypair_not_found(self):
|
|
req = webob.Request.blank('/v3/keypairs/DOESNOTEXIST')
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 404)
|
|
|
|
def test_keypair_delete_not_found(self):
|
|
|
|
def db_key_pair_get_not_found(context, user_id, name):
|
|
raise exception.KeypairNotFound(user_id=user_id, name=name)
|
|
|
|
self.stubs.Set(db, "key_pair_get",
|
|
db_key_pair_get_not_found)
|
|
req = webob.Request.blank('/v3/keypairs/WHAT')
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 404)
|
|
|
|
def test_keypair_show(self):
|
|
|
|
def _db_key_pair_get(context, user_id, name):
|
|
return dict(test_keypair.fake_keypair,
|
|
name='foo', public_key='XXX', fingerprint='YYY')
|
|
|
|
self.stubs.Set(db, "key_pair_get", _db_key_pair_get)
|
|
|
|
req = webob.Request.blank('/v3/keypairs/FAKE')
|
|
req.method = 'GET'
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
res_dict = jsonutils.loads(res.body)
|
|
self.assertEqual(res.status_int, 200)
|
|
self.assertEqual('foo', res_dict['keypair']['name'])
|
|
self.assertEqual('XXX', res_dict['keypair']['public_key'])
|
|
self.assertEqual('YYY', res_dict['keypair']['fingerprint'])
|
|
|
|
def test_keypair_show_not_found(self):
|
|
|
|
def _db_key_pair_get(context, user_id, name):
|
|
raise exception.KeypairNotFound(user_id=user_id, name=name)
|
|
|
|
self.stubs.Set(db, "key_pair_get", _db_key_pair_get)
|
|
|
|
req = webob.Request.blank('/v3/keypairs/FAKE')
|
|
req.method = 'GET'
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
self.assertEqual(res.status_int, 404)
|
|
|
|
def test_show_server(self):
|
|
self.stubs.Set(db, 'instance_get',
|
|
fakes.fake_instance_get())
|
|
self.stubs.Set(db, 'instance_get_by_uuid',
|
|
fakes.fake_instance_get())
|
|
req = webob.Request.blank('/v3/servers/1')
|
|
req.headers['Content-Type'] = 'application/json'
|
|
response = req.get_response(self.app)
|
|
self.assertEqual(response.status_int, 200)
|
|
res_dict = jsonutils.loads(response.body)
|
|
self.assertIn('key_name', res_dict['server'])
|
|
self.assertEqual(res_dict['server']['key_name'], '')
|
|
|
|
def test_detail_servers(self):
|
|
self.stubs.Set(db, 'instance_get_all_by_filters',
|
|
fakes.fake_instance_get_all_by_filters())
|
|
self.stubs.Set(db, 'instance_get_by_uuid', fakes.fake_instance_get())
|
|
req = webob.Request.blank('/v3/servers/detail')
|
|
res = req.get_response(self.app)
|
|
server_dicts = jsonutils.loads(res.body)['servers']
|
|
self.assertEqual(len(server_dicts), 5)
|
|
|
|
for server_dict in server_dicts:
|
|
self.assertIn('key_name', server_dict)
|
|
self.assertEqual(server_dict['key_name'], '')
|
|
|
|
def test_keypair_create_with_invalid_keypair_body(self):
|
|
body = {'alpha': {'name': 'create_test'}}
|
|
req = webob.Request.blank('/v3/keypairs')
|
|
req.method = 'POST'
|
|
req.body = jsonutils.dumps(body)
|
|
req.headers['Content-Type'] = 'application/json'
|
|
res = req.get_response(self.app)
|
|
jsonutils.loads(res.body)
|
|
self.assertEqual(res.status_int, 400)
|
|
|
|
|
|
class KeypairPolicyTest(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(KeypairPolicyTest, self).setUp()
|
|
self.KeyPairController = keypairs.KeypairController()
|
|
|
|
def _db_key_pair_get(context, user_id, name):
|
|
return dict(test_keypair.fake_keypair,
|
|
name='foo', public_key='XXX', fingerprint='YYY')
|
|
|
|
self.stubs.Set(db, "key_pair_get",
|
|
_db_key_pair_get)
|
|
self.stubs.Set(db, "key_pair_get_all_by_user",
|
|
db_key_pair_get_all_by_user)
|
|
self.stubs.Set(db, "key_pair_create",
|
|
db_key_pair_create)
|
|
self.stubs.Set(db, "key_pair_destroy",
|
|
db_key_pair_destroy)
|
|
|
|
def test_keypair_list_fail_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:index':
|
|
common_policy.parse_rule('role:admin')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs')
|
|
self.assertRaises(exception.Forbidden,
|
|
self.KeyPairController.index,
|
|
req)
|
|
|
|
def test_keypair_list_pass_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:index':
|
|
common_policy.parse_rule('')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs')
|
|
res = self.KeyPairController.index(req)
|
|
self.assertIn('keypairs', res)
|
|
|
|
def test_keypair_show_fail_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:show':
|
|
common_policy.parse_rule('role:admin')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs/FAKE')
|
|
self.assertRaises(exception.Forbidden,
|
|
self.KeyPairController.show,
|
|
req, 'FAKE')
|
|
|
|
def test_keypair_show_pass_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:show':
|
|
common_policy.parse_rule('')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs/FAKE')
|
|
res = self.KeyPairController.show(req, 'FAKE')
|
|
self.assertIn('keypair', res)
|
|
|
|
def test_keypair_create_fail_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:create':
|
|
common_policy.parse_rule('role:admin')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs')
|
|
req.method = 'POST'
|
|
self.assertRaises(exception.Forbidden,
|
|
self.KeyPairController.create,
|
|
req, body={'keypair': {'name': 'create_test'}})
|
|
|
|
def test_keypair_create_pass_policy(self):
|
|
body = {'keypair': {'name': 'create_test'}}
|
|
rules = {'compute_extension:v3:keypairs:create':
|
|
common_policy.parse_rule('')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs')
|
|
req.method = 'POST'
|
|
res = self.KeyPairController.create(req, body=body)
|
|
self.assertIn('keypair', res)
|
|
|
|
def test_keypair_delete_fail_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:delete':
|
|
common_policy.parse_rule('role:admin')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs/FAKE')
|
|
req.method = 'DELETE'
|
|
self.assertRaises(exception.Forbidden,
|
|
self.KeyPairController.delete,
|
|
req, 'FAKE')
|
|
|
|
def test_keypair_delete_pass_policy(self):
|
|
rules = {'compute_extension:v3:keypairs:delete':
|
|
common_policy.parse_rule('')}
|
|
policy.set_rules(rules)
|
|
req = fakes.HTTPRequestV3.blank('/keypairs/FAKE')
|
|
req.method = 'DELETE'
|
|
self.assertIsNone(self.KeyPairController.delete(req, 'FAKE'))
|