3a43a931d4
User confirming migration as well as a successfull live migration also triggers the delete allocation code path. This patch adds test coverage for these code paths. If the deletion of the source allocation of a confirmed migration fails then nova puts the instance to ERROR state. The instance still has two allocations in this state and deleting the instance only deletes the one that is held by the instance_uuid. This patch logs an ERROR describing that in this case the allocation held by the migration_uuid is leaked. The same true for live migration failing to delete allocaton on the source host. As this makes every caller of _delete_allocation_after_move logging the same error for AllocationDeleteFailed exception this patch moves that logging into _delete_allocation_after_move. Blueprint: use-nested-allocation-candidates Change-Id: I99427a52676826990d2a2ffc82cf30ad945b939c
13 lines
672 B
YAML
13 lines
672 B
YAML
---
|
|
issues:
|
|
- |
|
|
Nova leaks resource allocations in placement during
|
|
``POST /servers/{server_id}/action (revertResize Action)`` and
|
|
``POST /servers/{server_id}/action (confirmResize Action)`` and
|
|
``POST /servers/{server_id}/action (os-migrateLive Action)`` and if the
|
|
allocation held by the migration_uuid is modified in parallel with the
|
|
lifecycle operation. Nova will log an ERROR and will put the server into
|
|
ERROR state but will not delete the migration allocation. We assume that
|
|
this can only happen if somebody outside of nova is actively changing the
|
|
migration allocation in placement. Therefore it is not considered as a bug.
|