openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/unit/compute
History
Matt Riedemann b00b2fe9be Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker 
For some reason, probably because build requests are meant to be short lived
and we don't get a lot of bugs about paging misbehavior, when paging instances
with a marker, we didn't raise MarkerNotFound if we didn't find the marker in
the list of build requests. Doing so would match what we do when paging over
cells and listing instances using a marker. Once we find the marker, be that
in build_requests, or one of the cells, we need to set the marker to None to
stop looking for it elsewhere if we have more space to fill our limit.

For example, see change I8a957bebfcecd6ac712103c346e028d80f1ecd7c.

This patch fixes the issue by raising MarkerNotFound from BuildRequestList
get_by_filters if there is a marker and we didn't find a build request for
it. The compute API get_all() method handles that as normal and continues
looking for the marker in one of the cells.

Conflicts:
      nova/tests/unit/compute/test_compute_api.py

NOTE(mriedem): The conflicts are due to not having
bb7c6ebb56 in Ocata.

Change-Id: I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab
Closes-Bug: #1737856
(cherry picked from commit 1706e39891)
(cherry picked from commit 344029b94a)
 		2018-01-03 12:48:04 -05:00
..
monitors Allow monitor plugins to set own metric object 2016-06-27 14:38:32 +05:30
__init__.py
…
eventlet_utils.py
…
fake_resource_tracker.py rt: explicitly pass compute node to _update() 2017-01-12 11:30:03 -08:00
test_claims.py rt: use a single ResourceTracker object instance 2017-01-16 14:09:25 -05:00
test_compute.py Get original image_id from volume for volume-backed instance rebuild 2017-12-05 10:40:10 -05:00
test_compute_api.py Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker 2018-01-03 12:48:04 -05:00
test_compute_cells.py Get original image_id from volume for volume-backed instance rebuild 2017-12-05 10:40:10 -05:00
test_compute_mgr.py Merge "Add live.migration.force.complete to the legacy notification whitelist" into stable/ocata 2017-10-24 06:19:51 +00:00
test_compute_utils.py Fix missing instance.delete notification 2017-03-13 15:02:06 -04:00
test_compute_xen.py conf: Remove config option compute_ manager 2016-12-08 20:05:52 +08:00
test_flavors.py Make compute unit tests inherit from test.NoDBTestCase 2015-02-24 17:54:29 +02:00
test_host_api.py Remove compute host from all host aggregates when compute service is deleted 2016-07-16 22:19:44 +03:00
test_keypairs.py Move quota options to a config group. 2017-01-04 22:57:14 -06:00
test_resource_tracker.py Account for compute.metrics.update in legacy notification whitelist 2017-10-04 13:25:57 +00:00
test_rpcapi.py Change RPC post_live_migration_at_destination from cast to call. 2016-11-08 14:42:35 +00:00
test_shelve.py Call terminate_connection when shelve_offloading 2017-09-14 18:45:46 -04:00
test_stats.py Address nits in Ia2296302 2016-03-08 16:48:08 +00:00
test_virtapi.py Remove mox from nova/tests/unit/compute/test_virtapi.py 2016-11-28 08:52:00 +00:00