OpenStack Compute (Nova)
Go to file
Lee Yarwood b18e93a2a4 compute: Don't delete the original attachment during pre LM rollback
I0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live
migration with cinderv3 volume attachments during Queens. This initial
support handled failures in pre_live_migration directly by removing any
attachments created on the destination and reverting to the original
attachment ids before re-raising the caught exception to the source
compute. It also added rollback code within the main
_rollback_live_migration method but missed that this would also be
called during a pre_live_migration rollback.

As a result after a failure in pre_live_migration
_rollback_live_migration will attempt to delete the source host volume
attachments referenced by the bdm before updating the bdms with the now
non-existent attachment ids, leaving the volumes in an `available` state
in Cinder as they have no attachment records associated with them
anymore.

This change aims to resolve this within _rollback_volume_bdms by
ensuring that the current and original attachment_ids are not equal
before requesting that the current attachment referenced by the bdm is
deleted. When called after a failure in pre_live_migration this should
result in no attempt being made to remove the original source host
attachments from Cinder.

Note that the following changes muddy the waters slightly here but
introduced no actual changes to the logic within
_rollback_live_migration:

* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error
  handling in Rocky but isn't the source of the issue here.

* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked
  _rollback_live_migration to use the provided source_bdms.

* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored
  _rollback_live_migration, moving the logic into a self contained
  _rollback_volume_bdms method.

Closes-Bug: #1889108
Change-Id: I9edb36c4df1cc0d8b529e669f06540de71766085
(cherry picked from commit 2102f1834a)
(cherry picked from commit 034b2fa8fe)
(cherry picked from commit c6c3483a41)
(cherry picked from commit 6007c41aa8)
2020-09-14 10:20:11 +01:00
api-guide/source Fix none-ascii char in doc 2018-08-07 00:13:00 +00:00
api-ref/source Block deleting compute services with in-progress migrations 2019-12-09 18:34:52 -05:00
contrib trivial: Remove "vif" script 2017-08-07 16:00:10 +01:00
devstack Skip test_resize_server_revert_with_volume_attached in nova-lvm 2018-07-19 12:22:18 -04:00
doc Merge "Fix os-keypairs pagination links" into stable/rocky 2020-03-19 19:34:21 +00:00
etc/nova Add osprofiler config options to generated reference 2018-06-16 12:46:19 +00:00
gate Make nova-manage db purge take --all-cells 2018-03-08 09:26:49 -08:00
nova compute: Don't delete the original attachment during pre LM rollback 2020-09-14 10:20:11 +01:00
placement-api-ref [placement] api-ref: add description for 1.29 2018-08-09 02:56:30 +00:00
playbooks/legacy OpenDev Migration Patch 2019-04-19 19:47:10 +00:00
releasenotes Merge "FUP for in-place numa rebuild" into stable/rocky 2020-08-18 02:30:24 +00:00
tools Check cherry-pick hashes in pep8 tox target 2020-07-16 18:17:44 +02:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
.gitreview OpenDev Migration Patch 2019-04-19 19:47:10 +00:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.stestr.conf Finish stestr migration 2017-11-24 16:51:12 -05:00
.zuul.yaml zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full 2020-07-21 19:39:26 +02:00
CONTRIBUTING.rst Update links in documents 2018-01-12 17:05:11 +08:00
HACKING.rst Removed unnecessary parantheses in yield statements 2018-03-07 16:44:36 +09:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Fix broken URLs 2017-09-07 15:42:31 +02:00
README.rst Docs: modernise links 2018-03-24 20:27:11 +08:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt Merge "Bindep does not catch missing libpcre3-dev on Ubuntu" 2018-02-14 07:31:09 +00:00
lower-constraints.txt Use ThreadPoolExecutor for max_concurrent_live_migrations 2018-07-16 13:57:09 -04:00
requirements.txt Merge "Blacklist greenlet 0.4.14" 2018-07-24 16:06:41 +00:00
setup.cfg Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
setup.py Updated from global requirements 2017-03-02 11:50:48 +00:00
test-requirements.txt Cleanup ugly stub in TestLocalDeleteAllocations 2018-05-16 09:23:55 -04:00
tests-py3.txt Remove mox in unit/virt/xenapi/test_vmops.py 2018-05-06 22:31:05 +00:00
tox.ini Check cherry-pick hashes in pep8 tox target 2020-07-16 18:17:44 +02:00

README.rst

Team and repository tags

image

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.

Use the following resources to learn more.

API

To learn how to use Nova's API, consult the documentation available online at:

For more information on OpenStack APIs, SDKs and CLIs in general, refer to:

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

Other Information

During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: