OpenStack Compute (Nova)
Go to file
melanie witt b50b70a182 libvirt: set device address tag only if setting disk unit
In Pike, we began setting disk unit values manually for the
'virtio-scsi' controller model in order to allow up to 256 devices [1].
We do this by setting the disk unit of the address tag manually for the
guest config. If we do not set the address tag manually, libvirt would
autogenerate it for us.

A problem occurs when a user has a SCSI disk that is a volume or isn't
using the 'virtio-scsi' controller model because we're not guarding our
manual setting of the address tag in the guest config by the disk unit,
in addition to the SCSI bus. This means that for a SCSI volume, we
generate an address tag like '<address type="drive" controller="0"/>'
for any SCSI volume, so a user with more than one device will get the
following error when they try to boot an instance:

  Failed to start libvirt guest: libvirtError: unsupported
    configuration: Found duplicate drive address for disk with target name
    'sda' controller='0' bus='0' target='0' unit='0'

This updates the conditionals to only manually set the address tag if
the bus is SCSI _and_ the disk unit has been specified. Otherwise, let
libvirt autogenerate the address tag and take care of avoiding
collisions.

[1] https://bugs.launchpad.net/nova/+bug/1686116

Closes-Bug: #1792077

 Conflicts:
     nova/tests/unit/virt/libvirt/volume/test_volume.py

NOTE(melwitt): Conflict is due to not having change
Ibfa64f18bbd2fb70db7791330ed1a64fe61c1355 in Pike.

Change-Id: Iefab05e84ccc0bf8f15bdbbf515a290d282dbc5d
(cherry picked from commit 48fd81648a)
(cherry picked from commit 7500c1910c)
(cherry picked from commit 8703282508)
(cherry picked from commit c8ad9f4e19)
2019-04-18 16:07:22 +00:00
api-guide/source api-ref: Add X-Openstack-Request-Id description 2017-07-10 14:03:14 +00:00
api-ref/source Block deleting compute services which are hosting instances 2018-07-05 16:24:32 -04:00
contrib Merge "changed quantum to neutron in vif-openstack" 2014-03-05 10:45:05 +00:00
devstack Skip test_rebuild_server_in_error_state for cells v1 2017-08-22 18:42:17 +00:00
doc Merge "Null out instance.availability_zone on shelve offload" into stable/pike 2019-03-26 06:19:07 +00:00
etc/nova rootwrap.d cleanup mislabeled files 2017-08-01 16:09:18 +10:00
gate move gate hooks to gate/ 2017-01-04 11:05:16 +00:00
nova libvirt: set device address tag only if setting disk unit 2019-04-18 16:07:22 +00:00
placement-api-ref/source [placement] Add api-ref for usages 2017-08-09 15:54:48 +00:00
playbooks/legacy/nova-live-migration Replace openstack.org git:// URLs with https:// 2019-03-24 20:34:44 +00:00
plugins/xenserver XenAPI Remove useless files when use os-xenapi lib 2017-01-10 18:06:17 -08:00
releasenotes Merge "Fix bug case by none token context" into stable/pike 2019-03-22 19:05:28 +00:00
tools tools/xenserver: Remove 'cleanup_sm_locks' 2017-08-07 12:26:53 +00:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.gitreview Update .gitreview for stable/pike 2017-08-11 12:29:20 +00:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.stestr.conf Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.zuul.yaml Migrate nova v2.0 legacy job to zuulv3 2019-01-25 08:37:07 +00:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst Enable global hacking checks and removed local checks 2017-02-10 15:09:37 +01:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Add a maintainers file 2015-05-23 03:22:07 +10:00
README.rst doc: Rework README to reflect new doc URLs 2017-08-03 16:06:08 -04:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt Update bindep.txt for doc builds 2017-11-21 20:09:12 +00:00
requirements.txt Updated from global requirements 2017-08-07 00:49:24 +00:00
setup.cfg Using plain routes for the microversions test 2017-07-23 22:43:53 +08:00
setup.py Updated from global requirements 2017-03-02 11:50:48 +00:00
test-requirements.txt Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
tests-functional-py3.txt Remove invalid URL in gabbi tests 2017-01-17 21:10:45 +00:00
tests-py3.txt Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
tox.ini tox: Don't write byte code (maybe) 2019-02-22 15:43:18 +00:00

README.rst

Team and repository tags

image

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.

Use the following resources to learn more.

API

To learn how to use Nova's API, consult the documentation available online at:

For more information on OpenStack APIs, SDKs and CLIs in general, refer to:

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

Other Information

During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: