nova/nova/tests/unit
Lee Yarwood be83c7ecc0 libvirt: Remove reference to transient domain when detaching devices
When detaching a device from a domain we first attempt to remove the
device from both the persistent and live configs before looping to
ensure the device has really been detached from the running live config.

Previously when this failed we logged an error message that suggested
that this was due to issues detaching the device from a transient
domain, however this is not the case as the domain is persistent.

This change simply updates the error and associated comments to only
reference the live config of the domain.

Additionally a DEBUG line claiming that a device has been successfully
detached is now only logged once the device is removed from the live
config, hopefully avoiding any confusion from this line been logged
each time an attempt is made to detach the device.

Change-Id: If869470216600c303d47cf79f12c4fc88abcf813
(cherry picked from commit 636c7461de)
2021-01-21 19:37:13 +00:00
..
api Reject boot request for unsupported images 2020-07-17 14:03:31 +02:00
api_samples_test_base Fix os-simple-tenant-usage result order 2019-01-22 18:09:21 +01:00
cells Merge "Add instance action record for snapshot instances" 2017-12-28 02:16:46 +00:00
cmd Fix wrong assertions in unit tests 2019-08-20 14:11:51 +09:00
compute Merge "compute: Don't delete the original attachment during pre LM rollback" into stable/queens 2020-10-07 15:23:25 +00:00
conductor Avoid circular reference during serialization 2020-03-15 11:45:04 +00:00
console Mask the token used to allow access to consoles 2020-02-14 15:13:46 +01:00
consoleauth Mask the token used to allow access to consoles 2020-02-14 15:13:46 +01:00
db Don't delete compute node, when deleting service other than nova-compute 2019-11-21 10:51:01 +01:00
fake_loadables
image prevent common kwargs from glance client failure 2019-04-06 19:18:32 +00:00
keymgr
monkey_patch_example
network Add config option for neutron client retries 2020-04-24 18:20:41 +03:00
notifications Call generate_image_url only for legacy notification 2018-07-23 18:30:33 +02:00
objects objects: Update keypairs when saving an instance 2020-07-31 16:27:37 +01:00
pci Fix non-existent method of Mock 2019-08-16 10:27:22 +09:00
privsep Start moving users of parted to privsep. 2018-01-22 21:37:53 +00:00
scheduler Disable limit if affinity(anti)/same(different)host is requested 2019-08-09 10:26:09 -04:00
servicegroup Fix service list for disabled compute using MC driver 2018-09-16 19:12:55 +00:00
ssl_cert Update SSL cert used in testing 2017-07-31 13:09:49 +10:00
virt libvirt: Remove reference to transient domain when detaching devices 2021-01-21 19:37:13 +00:00
volume Add retry to cinder API calls related to volume detach 2020-05-09 09:14:46 +00:00
README.rst
__init__.py Do not monkey patch eventlet in unit tests 2017-09-28 12:22:11 +01:00
cast_as_call.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
conf_fixture.py Change compute mgr placement check to region_name 2018-03-23 18:46:59 +00:00
fake_block_device.py Make BlockDeviceMapping object support uuid 2017-12-17 16:47:30 +00:00
fake_build_request.py
fake_console_auth_token.py Add access_url_base to console_auth_tokens table 2018-01-06 02:02:26 +00:00
fake_crypto.py
fake_diagnostics.py
fake_flavor.py Add Flavor.description attribute 2017-11-05 01:24:01 -05:00
fake_hosts.py
fake_instance.py objects: Update keypairs when saving an instance 2020-07-31 16:27:37 +01:00
fake_ldap.py
fake_network.py
fake_network_cache_model.py
fake_notifier.py fake_notifier: Refactor wait_for_versioned_notification 2017-09-12 14:20:05 +00:00
fake_pci_device_pools.py
fake_policy.py Fix a missing policy in test policy data 2019-02-15 02:07:35 +00:00
fake_processutils.py
fake_request_spec.py Don't persist could-be-stale InstanceGroup fields in RequestSpec 2017-12-13 16:00:24 -08:00
fake_server_actions.py
fake_volume.py Remove check_detach 2017-07-20 22:32:52 +02:00
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py
policy_fixture.py Reduce policy deprecation warnings in test runs 2018-01-27 00:01:43 +00:00
test_api_validation.py Enable reset keypair while rebuilding instance 2017-11-13 10:49:02 +08:00
test_availability_zones.py
test_baserpc.py Do not setup conductor in BaseAPITestCase 2017-09-28 12:22:11 +01:00
test_block_device.py
test_cache.py
test_cinder.py Fix bug case by none token context 2018-01-24 20:53:50 -05:00
test_conf.py
test_configdrive2.py Cleanup mount / umount and associated rmdir calls 2017-10-18 17:52:58 +11:00
test_context.py Allow cinderv2 endpoints within the request context catalog 2018-06-05 10:04:06 +01:00
test_crypto.py
test_exception.py Add __repr__ for NovaException 2018-04-05 19:44:32 +00:00
test_fixtures.py
test_flavors.py
test_hacking.py Fix double word hacking test 2019-08-09 14:47:56 +00:00
test_hooks.py
test_identity.py Use ksa adapter for keystone conf & requests 2017-11-30 22:33:01 +00:00
test_instance_types_extra_specs.py
test_iptables_network.py Use more specific asserts in tests 2017-06-20 13:27:39 +02:00
test_ipv6.py
test_json_ref.py Nits from Ic3ab7d60e4ac12b767fe70bef97b327545a86e74 2017-11-28 15:55:45 +01:00
test_loadables.py
test_matchers.py
test_metadata.py Merge "conf: Remove 'vendordata_driver' opt" 2018-01-19 11:41:15 +00:00
test_notifications.py Remove dead code of api.fault notification sending 2017-10-09 17:29:40 +02:00
test_notifier.py
test_nova_manage.py fix cellv2 delete_host 2019-07-25 13:45:06 +03:00
test_policy.py Add policy rule to block image-backed servers with 0 root disk flavor 2018-06-18 13:51:41 -04:00
test_profiler.py
test_quota.py Follow up on removing old-style quotas code 2017-12-08 22:11:24 +00:00
test_rpc.py Make TestRPC inherit from the base nova TestCase 2017-09-26 14:13:53 +00:00
test_safeutils.py Allow wrapping of closures 2017-07-20 10:07:52 +01:00
test_service.py Move conductor wait_until_ready() delay before manager init 2018-09-01 17:25:02 -04:00
test_service_auth.py Fix NoneType error when [service_user] is misconfigured 2017-11-28 12:22:30 -06:00
test_test.py Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 2017-09-06 15:52:51 -04:00
test_test_utils.py
test_utils.py Use method validate_integer from oslo.utils 2018-01-05 17:28:16 +08:00
test_uuid_sentinels.py Move test_uuid_sentinels to NoDBTestCase 2017-10-12 10:58:17 -04:00
test_versions.py
test_weights.py
test_wsgi.py
utils.py Make ConductorTaskTestCase run with 2 cells 2017-09-07 09:37:21 -04:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎