nova/nova/tests/unit
Hans Lindgren c126d36640 Make scheduler filters/weighers only load once
Right now, filters/weighers are instantiated on every invocation of the
scheduler. This is both time consuming and unnecessary. In cases where
a filter/weigher tries to be smart and store/cache something in between
invocations this actually prohibits that.

This change make base filter/weigher functions take objects instead of
classes and then let schedulers create objects only once and then reuse
them.

This fixes a known bug in trusted_filter that tries to cache things.

Related to blueprint scheduler-optimization

Change-Id: I3174ab7968b51c43c0711033bac5d4bc30938b95
Closes-Bug: #1223450
2014-12-09 18:58:49 +01:00
..
CA move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
api Merge "Add host field to ComputeNode" 2014-12-09 14:58:30 +00:00
bundle move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cells Make scheduler filters/weighers only load once 2014-12-09 18:58:49 +01:00
cert Remove havana compat from nova.cert.rpcapi 2014-11-22 01:10:05 +00:00
cmd move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
compute Merge "Add host field to ComputeNode" 2014-12-09 14:58:30 +00:00
conductor object-ify flavors manager side of the RPC 2014-12-04 18:59:53 +00:00
console Remove havana compat from nova.console.rpcapi 2014-11-13 06:32:12 +00:00
consoleauth Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
db Add host field to ComputeNode 2014-12-08 14:19:06 +01:00
fake_loadables move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
functional move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
image Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
keymgr move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
monkey_patch_example move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
network rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
objects Merge "objects: introduce numa pages topology as an object" 2014-12-09 16:50:00 +00:00
pci move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
scheduler Make scheduler filters/weighers only load once 2014-12-09 18:58:49 +01:00
servicegroup move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
ssl_cert move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
virt Merge "objects: introduce numa pages topology as an object" 2014-12-09 16:50:00 +00:00
volume Remove unused cinder code 2014-12-05 13:22:06 -05:00
README.rst move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
__init__.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cast_as_call.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
conf_fixture.py Switch to oslo.config fixture 2014-11-20 18:50:04 +00:00
fake_block_device.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_crypto.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_hosts.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_instance.py Added objects Tag and TagList 2014-12-02 17:50:45 +03:00
fake_ldap.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_network.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_network_cache_model.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_notifier.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_policy.py Remove the volume api related useless policy rules 2014-12-03 14:18:42 +08:00
fake_processutils.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
fake_server_actions.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_volume.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
image_fixtures.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
matchers.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
policy_fixture.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_api_validation.py Add API json schema to volumes api(v2.1) 2014-11-18 14:01:08 +08:00
test_availability_zones.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_baserpc.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_bdm.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_block_device.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_cinder.py Use session in cinderclient 2014-11-18 09:46:25 +10:00
test_configdrive2.py Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
test_context.py Prevent admin role leak in context.elevated 2014-11-24 22:58:05 +00:00
test_crypto.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
test_exception.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_flavors.py object-ify flavors api and compute/api side of RPC 2014-11-13 22:18:12 +00:00
test_hacking.py Replacement `_` on `_LW` in all LOG.warning part 1 2014-11-20 11:19:16 +02:00
test_hooks.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_instance_types_extra_specs.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_iptables_network.py Fixes multi-line strings with missing spaces 2014-12-05 13:13:42 +00:00
test_ipv6.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_linuxscsi.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_loadables.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_matchers.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_metadata.py Get EC2 metadata localip return controller node ip 2014-11-17 09:39:22 +00:00
test_notifications.py Changed testcase 'test_send_on_vm_change' to test vm change 2014-11-30 21:04:41 +05:30
test_nova_manage.py Enforce unique instance uuid in data model 2014-12-04 08:31:17 -08:00
test_objectstore.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_pipelib.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_policy.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_quota.py Removing the headroom calculation from db layer 2014-11-28 12:04:40 +08:00
test_safeutils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_service.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
test_test.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_test_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_utils.py Merge "rename oslo.concurrency to oslo_concurrency" 2014-12-08 22:40:45 +00:00
test_versions.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_weights.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_wsgi.py Eventlet green threads not released back to pool 2014-11-21 22:42:08 +00:00
utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎