nova/nova/tests/unit
Chris Dent def4b17934 Use nova.db.api directly
nova/db/__init__.py was importing * from nova.db.api. This meant that
any time any code anywhere within the nova.db package was imported
then nova.db.api was too, leading to a cascade of imports that may
not have been desired. Also, in general, code in __init__.py is a pain.

Therefore, this change adjusts code that so that either:

* nova.db.api is used directly
* nova.db.api is imported as 'db'

In either case, the functionality remains the same.

The primary goal of this change was to make it possible to import the
model files without having to import the db api. Moving the model files
to a different place in the directory hierarchy was considered, but
given that "code in __init__.py is a pain" this mode was chosen.

This looks like a very large change, but it is essentially adjusting
package names, many in mocks.

Change-Id: Ic1fd7c87ceda05eeb96735da2a415ef37060bb1a
2018-07-10 14:56:27 +00:00
..
api Use nova.db.api directly 2018-07-10 14:56:27 +00:00
api_samples_test_base
cells Use nova.db.api directly 2018-07-10 14:56:27 +00:00
cmd Use nova.db.api directly 2018-07-10 14:56:27 +00:00
compute Use nova.db.api directly 2018-07-10 14:56:27 +00:00
conductor Use nova.db.api directly 2018-07-10 14:56:27 +00:00
console Use nova.db.api directly 2018-07-10 14:56:27 +00:00
consoleauth Fix invalid UUIDs in remaining tests 2018-01-30 17:15:03 +00:00
db Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_loadables
image Implement certificate_utils 2018-06-12 14:44:32 -04:00
keymgr
network Use nova.db.api directly 2018-07-10 14:56:27 +00:00
notifications Use nova.db.api directly 2018-07-10 14:56:27 +00:00
objects Use nova.db.api directly 2018-07-10 14:56:27 +00:00
pci Use nova.db.api directly 2018-07-10 14:56:27 +00:00
privsep Move image conversion to privsep. 2018-05-15 10:09:01 -04:00
scheduler Use nova.db.api directly 2018-07-10 14:56:27 +00:00
servicegroup
ssl_cert
virt Use nova.db.api directly 2018-07-10 14:56:27 +00:00
volume Remove unnecessary parameters from create volume API 2018-06-12 12:06:41 +05:30
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Remove placement config check 2018-04-17 20:53:08 +00:00
fake_block_device.py Make BlockDeviceMapping object support uuid 2017-12-17 16:47:30 +00:00
fake_build_request.py
fake_console_auth_token.py Add access_url_base to console_auth_tokens table 2018-01-06 02:02:26 +00:00
fake_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
fake_diagnostics.py
fake_flavor.py Add Flavor.description attribute 2017-11-05 01:24:01 -05:00
fake_hosts.py
fake_instance.py Add trusted_certs object 2018-03-29 23:00:48 -04:00
fake_ldap.py
fake_network.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_network_cache_model.py
fake_notifier.py
fake_pci_device_pools.py
fake_policy.py Remove support for /os-fixed-ips REST API 2018-06-26 09:20:28 -04:00
fake_processutils.py
fake_request_spec.py Add user_id to RequestSpec 2018-05-01 11:08:43 -04:00
fake_requests.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Fix PatternPropertiesTestCase for py 3.6 2018-02-19 11:06:45 +00:00
test_availability_zones.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_baserpc.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_block_device.py
test_cache.py
test_cinder.py Fix bug case by none token context 2018-01-24 20:53:50 -05:00
test_conf.py
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
test_exception.py Add full traceback to ExceptionPayload in versioned notifications 2018-06-19 16:46:46 +08:00
test_fixtures.py Ensure that os-traits sync is attempted only at start of process 2018-06-19 13:22:04 +01:00
test_flavors.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_hacking.py Fix N332 api_version decorator hacking check 2018-03-29 10:27:30 -05:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py
test_metadata.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_notifications.py Add action initiator attribute to the instance payload 2018-07-03 18:45:44 +00:00
test_notifier.py
test_nova_manage.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_policy.py Merge "Remove support for /os-fixed-ips REST API" 2018-06-26 21:01:35 +00:00
test_profiler.py
test_quota.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_rpc.py Use oslo.messaging per-call monitoring 2018-06-11 14:44:10 -07:00
test_safeutils.py
test_service.py Use nova.test.TestingException 2018-06-28 11:57:57 +00:00
test_service_auth.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_uuid_sentinels.py
test_versions.py
test_weights.py
test_wsgi.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎