nova/nova/tests/unit
Balazs Gibizer e0d22ba4de Reject non existent mock assert calls
assert_called and assert_not_called are not asserting the state
of the mock object but considered as mocked calls so mock
will never raise exception but always executed successfully

This change patches the Mock class during unit test
to raise an exception if a function called on a mock object
that's name starts with 'assert' and does not one
of the supported Mock assert calls.

This change also fix the unit test to call only the supported
assert function on mock object.

This change also removes hacking rule N327 as the mock change
renders this hacking rule obsolete.

Change-Id: Id75def84bd4bdc1c1fb06221b4223322a99251eb
2014-12-16 11:40:36 +01:00
..
CA
api Merge "Share server access ips tests between V2 & V2.1" 2014-12-10 20:29:15 +00:00
bundle
cells Merge "Make scheduler filters/weighers only load once" 2014-12-11 17:02:49 +00:00
cert Remove havana compat from nova.cert.rpcapi 2014-11-22 01:10:05 +00:00
cmd
compute Reject non existent mock assert calls 2014-12-16 11:40:36 +01:00
conductor Merge "Set vm state error when raising unexpected exception in live migrate" 2014-12-10 14:46:39 +00:00
console Remove havana compat from nova.console.rpcapi 2014-11-13 06:32:12 +00:00
consoleauth Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
db Merge "Don't modify columns_to_join formal parameter in _manual_join_columns" 2014-12-10 20:29:55 +00:00
fake_loadables
functional
image Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
keymgr
monkey_patch_example
network Merge "Add backoff to ebtables retry" 2014-12-11 02:47:37 +00:00
objects Fix base obj_make_compatible() handling ListOfObjectsField 2014-12-11 09:11:43 -08:00
pci
scheduler Make scheduler filters/weighers only load once 2014-12-09 18:58:49 +01:00
servicegroup
ssl_cert
virt Reject non existent mock assert calls 2014-12-16 11:40:36 +01:00
volume Remove unused cinder code 2014-12-05 13:22:06 -05:00
README.rst
__init__.py move eventlet GREENDNS override to top level 2014-12-08 17:41:03 -05:00
cast_as_call.py
conf_fixture.py move all conf overrides to conf_fixture 2014-12-09 14:05:45 -05:00
fake_block_device.py
fake_crypto.py
fake_hosts.py
fake_instance.py Added objects Tag and TagList 2014-12-02 17:50:45 +03:00
fake_ldap.py
fake_network.py
fake_network_cache_model.py
fake_notifier.py
fake_policy.py Merge "Modify v21 alias name for compatible with v2" 2014-12-10 20:28:48 +00:00
fake_processutils.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
fake_server_actions.py
fake_utils.py
fake_volume.py
image_fixtures.py
matchers.py
policy_fixture.py
test_api_validation.py Add a validation format "cidr" 2014-12-05 02:22:15 +00:00
test_availability_zones.py
test_baserpc.py
test_bdm.py
test_block_device.py
test_cinder.py Use session in cinderclient 2014-11-18 09:46:25 +10:00
test_configdrive2.py Switch to moxstubout and mockpatch from oslotest 2014-12-02 08:03:42 -05:00
test_context.py Prevent admin role leak in context.elevated 2014-11-24 22:58:05 +00:00
test_crypto.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
test_exception.py
test_fixtures.py simplify database fixture to the features we use 2014-12-10 08:51:30 -05:00
test_flavors.py object-ify flavors api and compute/api side of RPC 2014-11-13 22:18:12 +00:00
test_hacking.py Reject non existent mock assert calls 2014-12-16 11:40:36 +01:00
test_hooks.py
test_instance_types_extra_specs.py
test_iptables_network.py Fixes multi-line strings with missing spaces 2014-12-05 13:13:42 +00:00
test_ipv6.py
test_linuxscsi.py
test_loadables.py
test_matchers.py
test_metadata.py Get EC2 metadata localip return controller node ip 2014-11-17 09:39:22 +00:00
test_notifications.py Changed testcase 'test_send_on_vm_change' to test vm change 2014-11-30 21:04:41 +05:30
test_nova_manage.py Enforce unique instance uuid in data model 2014-12-04 08:31:17 -08:00
test_objectstore.py
test_pipelib.py
test_policy.py
test_quota.py Check for floating IP pool in nova-network 2014-12-05 09:53:21 -05:00
test_safeutils.py
test_service.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
test_test.py move ServiceFixture and TranslationFixture 2014-12-09 14:05:45 -05:00
test_test_utils.py
test_utils.py Merge "rename oslo.concurrency to oslo_concurrency" 2014-12-08 22:40:45 +00:00
test_versions.py
test_weights.py
test_wsgi.py Eventlet green threads not released back to pool 2014-11-21 22:42:08 +00:00
utils.py

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎