f1d4d9762c
FIP pools are not associated with any projects and API controller also does not take any project_id in request so anyone requesting that API can get the FIP pools list. current check_str 'admin_or_owner' is not correct for this polic, it should be RULE_ANY. Currently if target is not passed in context.can(), it use defauls target which is context.user_id, context.project_id. These defaults target are not useful as it pass the context's user_id and project_id only which means we tell oslo policy to verify the context data with context data. This commit corrects the check_str and pass the actual target for FIP pools policies which is empty dict. Partial implement blueprint policy-defaults-refresh-deprecated-apis Change-Id: I06dde5960fdae5ee4e3ce902482361909ac397d6
75 lines
3.1 KiB
Python
75 lines
3.1 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from nova.api.openstack.compute import floating_ip_pools
|
|
from nova.tests.unit.api.openstack import fakes
|
|
from nova.tests.unit.policies import base
|
|
|
|
|
|
class FloatingIPPoolsPolicyTest(base.BasePolicyTest):
|
|
"""Test Floating IP Pools APIs policies with all possible context.
|
|
|
|
This class defines the set of context with different roles
|
|
which are allowed and not allowed to pass the policy checks.
|
|
With those set of context, it will call the API operation and
|
|
verify the expected behaviour.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(FloatingIPPoolsPolicyTest, self).setUp()
|
|
self.controller = floating_ip_pools.FloatingIPPoolsController()
|
|
self.req = fakes.HTTPRequest.blank('')
|
|
|
|
# Check that everyone is able to list FIP pools.
|
|
self.everyone_authorized_contexts = [
|
|
self.legacy_admin_context, self.system_admin_context,
|
|
self.project_admin_context, self.project_member_context,
|
|
self.project_reader_context, self.project_foo_context,
|
|
self.other_project_reader_context,
|
|
self.other_project_member_context,
|
|
self.system_member_context, self.system_reader_context,
|
|
self.system_foo_context]
|
|
self.everyone_unauthorized_contexts = []
|
|
|
|
@mock.patch('nova.network.neutron.API.get_floating_ip_pools')
|
|
def test_floating_ip_pools_policy(self, mock_get):
|
|
rule_name = "os_compute_api:os-floating-ip-pools"
|
|
self.common_policy_check(self.everyone_authorized_contexts,
|
|
self.everyone_unauthorized_contexts,
|
|
rule_name, self.controller.index,
|
|
self.req)
|
|
|
|
|
|
class FloatingIPPoolsScopeTypePolicyTest(FloatingIPPoolsPolicyTest):
|
|
"""Test Floating IP Pools APIs policies with system scope enabled.
|
|
|
|
This class set the nova.conf [oslo_policy] enforce_scope to True
|
|
so that we can switch on the scope checking on oslo policy side.
|
|
It defines the set of context with scoped token
|
|
which are allowed and not allowed to pass the policy checks.
|
|
With those set of context, it will run the API operation and
|
|
verify the expected behaviour.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(FloatingIPPoolsScopeTypePolicyTest, self).setUp()
|
|
self.flags(enforce_scope=True, group="oslo_policy")
|
|
|
|
|
|
class FloatingIPPoolsNoLegacyPolicyTest(FloatingIPPoolsScopeTypePolicyTest):
|
|
"""Test Floating IP Pools APIs policies with system scope enabled,
|
|
and no more deprecated rules.
|
|
"""
|
|
without_deprecated_rules = True
|