openstack
/
nova
Code Issues Proposed changes
nova/nova/api/openstack/compute
History
Mohammed Naser d72f24569e Add 'path' query parameter to console access url 
Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.

This modifies the ConsoleAuthToken.access_url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.

This change is backward compatible with noVNC < v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.

Co-Authored-By: melanie witt <melwittt@gmail.com>

Closes-Bug: #1822676

 Conflicts:
	doc/source/admin/remote-console-access.rst
	nova/tests/unit/console/test_websocketproxy.py

NOTE(melwitt): The conflicts are due to the following changes not being
in Rocky:

  I08991796aaced2abc824f608108c0c786181eb65
  I7f5f08691ca3f73073c66c29dddb996fb2c2b266

[1] 51f9f0098d
[2] https://github.com/novnc/noVNC/pull/1220

Change-Id: I2ddf0f4d768b698e980594dd67206464a9cea37b
(cherry picked from commit 9606c80402)
(cherry picked from commit 186aff98b7)
 		2019-08-06 19:20:50 +00:00
..
schemas Remove support for /os-floating-ip-dns REST API 2018-07-18 22:23:45 -04:00
views Add trusted_image_certificates to REST API 2018-06-13 15:52:59 -04:00
__init__.py Use plain routes list for '/servers' endpoint instead of stevedore 2017-04-25 22:38:33 +08:00
admin_actions.py Remove extensions module 2017-12-20 11:35:38 +08:00
admin_password.py Remove extensions module 2017-12-20 11:35:38 +08:00
agents.py Remove extensions module 2017-12-20 11:35:38 +08:00
aggregates.py Remove extensions module 2017-12-20 11:35:38 +08:00
assisted_volume_snapshots.py Remove extensions module 2017-12-20 11:35:38 +08:00
attach_interfaces.py Drop API compat handling for old compute error cases 2018-05-16 17:24:14 -04:00
availability_zone.py AZ list performance optimization: avoid double service list DB fetch 2019-04-30 13:17:04 +00:00
baremetal_nodes.py Remove extensions module 2017-12-20 11:35:38 +08:00
cells.py Remove extensions module 2017-12-20 11:35:38 +08:00
certificates.py Remove extensions module 2017-12-20 11:35:38 +08:00
cloudpipe.py Remove extensions module 2017-12-20 11:35:38 +08:00
config_drive.py Merge server create for config_drive extension 2018-07-19 06:34:05 +00:00
console_auth_tokens.py Use nova-consoleauth only if workaround enabled 2018-10-15 17:38:39 +00:00
console_output.py Remove extensions module 2017-12-20 11:35:38 +08:00
consoles.py Remove extensions module 2017-12-20 11:35:38 +08:00
create_backup.py Remove extensions module 2017-12-20 11:35:38 +08:00
deferred_delete.py Remove extensions module 2017-12-20 11:35:38 +08:00
evacuate.py Remove extensions module 2017-12-20 11:35:38 +08:00
extended_availability_zone.py Totally freeze the extension_info API 2017-05-08 16:32:48 +08:00
extended_server_attributes.py Totally freeze the extension_info API 2017-05-08 16:32:48 +08:00
extended_status.py Totally freeze the extension_info API 2017-05-08 16:32:48 +08:00
extended_volumes.py Make bdms querying in multi-cell use scatter-gather and ignore down cell 2018-02-07 11:46:32 +01:00
extension_info.py Remove unused LOG variables 2018-02-27 11:19:48 +00:00
fixed_ips.py Remove support for /os-fixed-ips REST API 2018-06-26 09:20:28 -04:00
flavor_access.py Remove extensions module 2017-12-20 11:35:38 +08:00
flavor_manage.py Add microversion to support extra_specs in flavor API. 2018-04-11 17:47:57 +08:00
flavors.py Add microversion to support extra_specs in flavor API. 2018-04-11 17:47:57 +08:00
flavors_extraspecs.py Remove extensions module 2017-12-20 11:35:38 +08:00
floating_ip_dns.py Remove support for /os-floating-ip-dns REST API 2018-07-18 22:23:45 -04:00
floating_ip_pools.py Remove extensions module 2017-12-20 11:35:38 +08:00
floating_ips.py Remove extensions module 2017-12-20 11:35:38 +08:00
floating_ips_bulk.py Remove support for /os-floating-ips-bulk REST API 2018-07-18 22:23:45 -04:00
fping.py Remove support for /os-fping REST API 2018-05-10 15:26:13 -04:00
helpers.py remove personality extension 2016-06-24 14:44:53 -04:00
hide_server_addresses.py Fix instance lookup in hide_server_addresses extension 2017-10-26 23:42:04 -04:00
hosts.py remove ec2 in service and cmd 2018-04-12 13:10:23 +08:00
hypervisors.py Remove extensions module 2017-12-20 11:35:38 +08:00
image_metadata.py Remove extensions module 2017-12-20 11:35:38 +08:00
image_size.py Use plain routes list for images instead of stevedore 2017-07-12 20:57:33 +08:00
images.py Remove extensions module 2017-12-20 11:35:38 +08:00
instance_actions.py Fix an error when generating a host ID 2019-03-06 09:29:08 +09:00
instance_usage_audit_log.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
ips.py Remove extensions module 2017-12-20 11:35:38 +08:00
keypairs.py Merge server create for keypair extension 2018-07-18 06:47:57 +00:00
limits.py Remove extensions module 2017-12-20 11:35:38 +08:00
lock_server.py Remove extensions module 2017-12-20 11:35:38 +08:00
migrate_server.py Fail to live migration if instance has a NUMA topology 2018-12-18 11:13:14 +00:00
migrations.py Ensure the JSON-Schema covers the legacy v2 API 2018-02-01 16:56:07 -05:00
multinic.py Remove extensions module 2017-12-20 11:35:38 +08:00
networks.py Remove extensions module 2017-12-20 11:35:38 +08:00
networks_associate.py Remove extensions module 2017-12-20 11:35:38 +08:00
pause_server.py Remove extensions module 2017-12-20 11:35:38 +08:00
quota_classes.py Remove extensions module 2017-12-20 11:35:38 +08:00
quota_sets.py Remove extensions module 2017-12-20 11:35:38 +08:00
remote_consoles.py Remove extensions module 2017-12-20 11:35:38 +08:00
rescue.py Remove extensions module 2017-12-20 11:35:38 +08:00
rest_api_version_history.rst Add 'path' query parameter to console access url 2019-08-06 19:20:50 +00:00
routes.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
security_group_default_rules.py Remove extensions module 2017-12-20 11:35:38 +08:00
security_groups.py Merge server create for security group extension 2018-06-28 14:13:54 +00:00
server_diagnostics.py Drop API compat handling for old compute error cases 2018-05-16 17:24:14 -04:00
server_external_events.py Ensure the JSON-Schema covers the legacy v2 API 2018-02-01 16:56:07 -05:00
server_groups.py Microversion 2.64 - Use new format policy in server group 2018-07-13 10:43:42 +08:00
server_metadata.py Remove extensions module 2017-12-20 11:35:38 +08:00
server_migrations.py API: add support to abort queued live migration in microversion 2.65 2018-07-16 13:57:11 -04:00
server_password.py Remove extensions module 2017-12-20 11:35:38 +08:00
server_tags.py Remove extensions module 2017-12-20 11:35:38 +08:00
server_usage.py Totally freeze the extension_info API 2017-05-08 16:32:48 +08:00
servers.py Handle missing exception in instance creation code 2019-03-06 14:46:40 +00:00
services.py Delete resource providers for all nodes when deleting compute service 2019-06-21 09:55:19 -04:00
shelve.py Remove extensions module 2017-12-20 11:35:38 +08:00
simple_tenant_usage.py Fix os-simple-tenant-usage result order 2018-10-29 08:15:47 +00:00
suspend_server.py Remove extensions module 2017-12-20 11:35:38 +08:00
tenant_networks.py Remove extensions module 2017-12-20 11:35:38 +08:00
used_limits.py Remove extensions module 2017-12-20 11:35:38 +08:00
versions.py Merge ResourceV21 obj into Resource obj 2017-12-21 19:33:35 +08:00
versionsV21.py Remove extensions module 2017-12-20 11:35:38 +08:00
virtual_interfaces.py Remove support for /os-virtual-interfaces REST API 2018-06-06 21:14:39 +00:00
volumes.py Block swap volume on volumes with >1 rw attachment 2019-05-30 17:25:06 -04:00
wsgi.py Add pbr-installed wsgi application for metadata api 2017-05-02 16:58:11 +00:00