d72f24569e
Starting in noVNC v1.1.0, the token query parameter is no longer forwarded via cookie [1]. We must instead use the 'path' query parameter to pass the token through to the websocketproxy [2]. This means that if someone deploys noVNC v1.1.0, VNC consoles will break in nova because the code is relying on the cookie functionality that v1.1.0 removed. This modifies the ConsoleAuthToken.access_url property to include the 'path' query parameter as part of the returned access_url that the client will use to call the console proxy service. This change is backward compatible with noVNC < v1.1.0. The 'path' query parameter is a long supported feature in noVNC. Co-Authored-By: melanie witt <melwittt@gmail.com> Closes-Bug: #1822676 Conflicts: doc/source/admin/remote-console-access.rst nova/tests/unit/console/test_websocketproxy.py NOTE(melwitt): The conflicts are due to the following changes not being in Rocky: I08991796aaced2abc824f608108c0c786181eb65 I7f5f08691ca3f73073c66c29dddb996fb2c2b266 [1] |
||
---|---|---|
.. | ||
v2.6 | ||
v2.8 | ||
get-rdp-console-post-req.json.tpl | ||
get-rdp-console-post-resp.json.tpl | ||
get-serial-console-post-req.json.tpl | ||
get-serial-console-post-resp.json.tpl | ||
get-spice-console-post-req.json.tpl | ||
get-spice-console-post-resp.json.tpl | ||
get-vnc-console-post-req.json.tpl | ||
get-vnc-console-post-resp.json.tpl |