60a91f475a
Add a temporary nova.notifier.Notifier helper class which translates
oslo.messaging.Notifier compatible calls into openstack.common.notifier
compatible calls.
This allows us to port the notifier code over to the oslo.messaging API
before actually switching over oslo.messaging fully.
This patch contains no functional changes at all, except that all
notifications go through this temporary helper class.
Some notes on the new API:
* The notifier API is changed so that what was previously global state
is now encapsulated in a Notifier object. This object also includes
the publisher_id and has error()/info()/etc. methods rather than
just notify().
* The notify_decorator() helper wasn't carried across to the new API
because its semantics are a bit weird. Something along these lines
could be added in future, though.
* We use a fake Notifier implementation for tests because there's no
API in oslo.messaging to actually get the notifications queued
up in the fake notification driver, which is a bit dumb. However,
this feels like the right thing to do anyway. We're not wanting
to test oslo.messaging.Notifier itself, but rather we want to test
how we call it.
blueprint: oslo-messaging
Change-Id: I262163c7e05e6a6fb79265e904ce761fc3ac5806
74 lines
2.4 KiB
Python
74 lines
2.4 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2013 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
A temporary helper which emulates oslo.messaging.Notifier.
|
|
|
|
This helper method allows us to do the tedious porting to the new Notifier API
|
|
as a standalone commit so that the commit which switches us to oslo.messaging
|
|
is smaller and easier to review. This file will be removed as part of that
|
|
commit.
|
|
"""
|
|
|
|
from oslo.config import cfg
|
|
|
|
from nova.openstack.common.notifier import api as notifier_api
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
class Notifier(object):
|
|
|
|
def __init__(self, publisher_id):
|
|
super(Notifier, self).__init__()
|
|
self.publisher_id = publisher_id
|
|
|
|
_marker = object()
|
|
|
|
def prepare(self, publisher_id=_marker):
|
|
ret = self.__class__(self.publisher_id)
|
|
if publisher_id is not self._marker:
|
|
ret.publisher_id = publisher_id
|
|
return ret
|
|
|
|
def _notify(self, ctxt, event_type, payload, priority):
|
|
notifier_api.notify(ctxt,
|
|
self.publisher_id,
|
|
event_type,
|
|
priority,
|
|
payload)
|
|
|
|
def debug(self, ctxt, event_type, payload):
|
|
self._notify(ctxt, event_type, payload, 'DEBUG')
|
|
|
|
def info(self, ctxt, event_type, payload):
|
|
self._notify(ctxt, event_type, payload, 'INFO')
|
|
|
|
def warn(self, ctxt, event_type, payload):
|
|
self._notify(ctxt, event_type, payload, 'WARN')
|
|
|
|
def error(self, ctxt, event_type, payload):
|
|
self._notify(ctxt, event_type, payload, 'ERROR')
|
|
|
|
def critical(self, ctxt, event_type, payload):
|
|
self._notify(ctxt, event_type, payload, 'CRITICAL')
|
|
|
|
|
|
def get_notifier(service=None, host=None, publisher_id=None):
|
|
if not publisher_id:
|
|
publisher_id = "%s.%s" % (service, host or CONF.host)
|
|
return Notifier(publisher_id)
|