The last time we incremented versions for libvirt and QEMU was during
the "Pike" release (commit: b980df0, 11-Feb-2017); for "Queens" we
didn't do any.
The advertized NEXT_MIN_{LIBVIRT,QEMU} versions during
"Pike" release were set to: libvirt 1.3.1 and QEMU 2.5.0 -- but they
weren't actually bumped for "Queens". So let's actually bump them for
the "Rocky" release.
Fix the affected functional tests. And where applicable, use the
FAKE_{LIBVIRT, QEMU}_VERSION constants in tests, instead of hard-coding
versions.
Also fix the following live migration unit tests in the libvirt driver:
- test_live_migration_update_graphics_xml
- test_live_migration_update_serial_console_xml
- test_live_migration_with_valid_target_connect_addr
- test_live_migration_raises_exception
In above tests the following, two main changes were made:
- "Mock" the migrateToURI3() API instead of migrateToURI2() -- because
with the libvirt version bump, Nova's guest.migrate() method will
now call libvirt's newer API migrateToURI3() with 'params' dict. So
adjust the tests accordingly.
- Replace the usage of "Mox" with "Mock" in relevant tests. (I know
we should try to stick to the sensible rule of "one logical change
per patch". But the tests were already failing and we are
systematically removing the usage of Mox in Nova source tree anyway.
On that grounds, this seems reasonable.)
Also drop the following version constants, which are no longer needed
and adjust / remove corresponding unit tests:
- MIN_{LIBVIRT_KVM,QEMU}_S390_VERSION
- MIN_LIBVIRT_KVM_PPC64_VERSION
- Drop MIN_LIBVIRT_VIRTUOZZO_VERSION
Note that subsequent patches will handle clean up of remaining (now no
longer needed) version constants and compatibility code.
Change-Id: If0a091a7441f2c3269148e40ececc3696d69684c
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
403320bc99