nova/nova/tests/unit
Mohammed Naser ed3e27afb4 Revert "Refine waiting for vif plug events during _hard_reboot"
This reverts commit aaf37a26d6.

This gets us back to Ib0cf5d55750f13d0499a570f14024dca551ed4d4
which was meant to address an issue introduced
by Id188d48609f3d22d14e16c7f6114291d547a8986.

So we essentially had three changes:

1. Hard reboot would blow away volumes and vifs and then wait for the
   vifs to be plugged; this caused a problem for some vif types (
   linuxbridge was reported) because the event never came and we
   timed out.

2. To workaround that, a second change was made to simply not wait for
   vif plugging events.

3. Since #2 was a bit heavy-handed for a problem that didn't impact
   openvswitch, another change was made to only wait for non-bridge vif
   types, so we'd wait for OVS.

But it turns out that opendaylight is an OVS vif type and doesn't send
events for plugging the vif, only for binding the port (and we don't
re-bind the port during reboot). There is also a report of this being a
problem for other types of ports, see
If209f77cff2de00f694b01b2507c633ec3882c82.

So rather than try to special-case every possible vif type that could
be impacted by this, we are simply reverting the change so we no longer
wait for vif plugged events during hard reboot.

Note that if we went back to Id188d48609f3d22d14e16c7f6114291d547a8986
and tweaked that to not unplug/plug the vifs we wouldn't have this
problem either, and that change was really meant to deal with an
encrypted volume issue on reboot. But changing that logic is out of the
scope of this change. Alternatively, we could re-bind the port during
reboot but that could have other implications, or neutron could put
something into the port details telling us which vifs will send events
and which won't, but again that's all outside of the scope of this
patch.

Change-Id: Ib3f10706a7191c58909ec1938042ce338df4d499
Closes-Bug: #1755890
2018-03-14 21:07:17 +00:00
..
api Fix invalid UUIDs in remaining tests 2018-01-30 17:15:03 +00:00
api_samples_test_base
cells Merge "Add instance action record for snapshot instances" 2017-12-28 02:16:46 +00:00
cmd placement: enable required traits from the flavor extra specs 2018-01-24 23:35:54 +08:00
compute Merge "Compute RPC client bump to 5.0" 2018-02-09 01:43:54 +00:00
conductor Clean up reservations in migrate_task call path 2018-02-08 12:40:37 -08:00
console Fix accumulated nits 2018-01-16 14:54:04 +00:00
consoleauth Fix invalid UUIDs in remaining tests 2018-01-30 17:15:03 +00:00
db Add index(instance_uuid, updated_at) on instance_actions table 2018-01-22 01:34:20 +00:00
fake_loadables
image Workaround glanceclient bug when CONF.glance.api_servers not set 2018-02-08 09:06:48 -05:00
keymgr
monkey_patch_example
network make unit tests compatible with os-vif 1.8.0 2018-01-15 19:22:57 +00:00
notifications Transform instance.resize_prep notification 2018-01-25 09:30:50 +09:00
objects Merge "Remove instance.keypairs migration code" 2018-02-07 02:19:26 +00:00
pci Address nits in I46d483f9de6776db1b025f925890624e5e682ada 2018-01-02 15:57:50 +00:00
privsep Start moving users of parted to privsep. 2018-01-22 21:37:53 +00:00
scheduler [placement] Add sending global request ID in put (2) 2018-02-04 23:41:28 +00:00
servicegroup iso8601.is8601.Utc No Longer Exists 2017-08-29 19:26:55 -04:00
ssl_cert Update SSL cert used in testing 2017-07-31 13:09:49 +10:00
virt Revert "Refine waiting for vif plug events during _hard_reboot" 2018-03-14 21:07:17 +00:00
volume Merge "Fix bug case by none token context" 2018-02-01 08:58:27 +00:00
README.rst
__init__.py Do not monkey patch eventlet in unit tests 2017-09-28 12:22:11 +01:00
cast_as_call.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
conf_fixture.py Set wsgi.keep_alive=False globally for tests 2017-07-14 11:42:38 -04:00
fake_block_device.py Make BlockDeviceMapping object support uuid 2017-12-17 16:47:30 +00:00
fake_build_request.py Support tag instances when boot(2/4) 2017-06-06 06:16:41 +00:00
fake_console_auth_token.py Add access_url_base to console_auth_tokens table 2018-01-06 02:02:26 +00:00
fake_crypto.py
fake_diagnostics.py Added nova objects for intance diagnostics 2017-05-30 00:39:44 +04:00
fake_flavor.py Add Flavor.description attribute 2017-11-05 01:24:01 -05:00
fake_hosts.py
fake_instance.py Add tags to instance.create Notification 2017-07-24 18:05:05 -04:00
fake_ldap.py
fake_network.py
fake_network_cache_model.py
fake_notifier.py fake_notifier: Refactor wait_for_versioned_notification 2017-09-12 14:20:05 +00:00
fake_pci_device_pools.py
fake_policy.py Remove deprecated policy items from fake_policy 2018-01-27 00:01:43 +00:00
fake_processutils.py
fake_request_spec.py Don't persist could-be-stale InstanceGroup fields in RequestSpec 2017-12-13 16:00:24 -08:00
fake_server_actions.py
fake_volume.py Remove check_detach 2017-07-20 22:32:52 +02:00
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py
policy_fixture.py Reduce policy deprecation warnings in test runs 2018-01-27 00:01:43 +00:00
test_api_validation.py Enable reset keypair while rebuilding instance 2017-11-13 10:49:02 +08:00
test_availability_zones.py Avoid lazy-load error when getting instance AZ 2017-05-25 15:46:22 -04:00
test_baserpc.py Do not setup conductor in BaseAPITestCase 2017-09-28 12:22:11 +01:00
test_block_device.py
test_cache.py Do not rely on dogpile internals for mocks 2017-05-30 11:57:54 +00:00
test_cinder.py Fix bug case by none token context 2018-01-24 20:53:50 -05:00
test_conf.py
test_configdrive2.py Cleanup mount / umount and associated rmdir calls 2017-10-18 17:52:58 +11:00
test_context.py Get auth from context for glance endpoint 2017-11-21 10:26:42 -06:00
test_crypto.py
test_exception.py Use enum value instead of string service name 2017-07-25 17:36:41 +02:00
test_fixtures.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_flavors.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_hacking.py Amend uuid4 hacking rule 2017-09-04 17:34:46 +00:00
test_hooks.py
test_identity.py Use ksa adapter for keystone conf & requests 2017-11-30 22:33:01 +00:00
test_instance_types_extra_specs.py
test_iptables_network.py Use more specific asserts in tests 2017-06-20 13:27:39 +02:00
test_ipv6.py
test_json_ref.py Nits from Ic3ab7d60e4ac12b767fe70bef97b327545a86e74 2017-11-28 15:55:45 +01:00
test_loadables.py
test_matchers.py
test_metadata.py Merge "conf: Remove 'vendordata_driver' opt" 2018-01-19 11:41:15 +00:00
test_notifications.py Remove dead code of api.fault notification sending 2017-10-09 17:29:40 +02:00
test_notifier.py Replace messaging.get_transport with get_rpc_transport 2017-06-05 15:05:29 -04:00
test_nova_manage.py Fix invalid UUIDs in remaining tests 2018-01-30 17:15:03 +00:00
test_policy.py Add microversion to allow setting flavor description 2017-11-15 22:10:39 +00:00
test_profiler.py Remove nova-cert 2017-04-27 22:28:01 -04:00
test_quota.py Follow up on removing old-style quotas code 2017-12-08 22:11:24 +00:00
test_rpc.py Make TestRPC inherit from the base nova TestCase 2017-09-26 14:13:53 +00:00
test_safeutils.py Allow wrapping of closures 2017-07-20 10:07:52 +01:00
test_service.py Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 2017-09-06 15:52:51 -04:00
test_service_auth.py Fix NoneType error when [service_user] is misconfigured 2017-11-28 12:22:30 -06:00
test_test.py Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 2017-09-06 15:52:51 -04:00
test_test_utils.py
test_utils.py Use method validate_integer from oslo.utils 2018-01-05 17:28:16 +08:00
test_uuid_sentinels.py Move test_uuid_sentinels to NoDBTestCase 2017-10-12 10:58:17 -04:00
test_versions.py
test_weights.py
test_wsgi.py
utils.py Make ConductorTaskTestCase run with 2 cells 2017-09-07 09:37:21 -04:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎