nova/nova/tests/unit/virt
Mohammed Naser ed3e27afb4 Revert "Refine waiting for vif plug events during _hard_reboot"
This reverts commit aaf37a26d6.

This gets us back to Ib0cf5d55750f13d0499a570f14024dca551ed4d4
which was meant to address an issue introduced
by Id188d48609f3d22d14e16c7f6114291d547a8986.

So we essentially had three changes:

1. Hard reboot would blow away volumes and vifs and then wait for the
   vifs to be plugged; this caused a problem for some vif types (
   linuxbridge was reported) because the event never came and we
   timed out.

2. To workaround that, a second change was made to simply not wait for
   vif plugging events.

3. Since #2 was a bit heavy-handed for a problem that didn't impact
   openvswitch, another change was made to only wait for non-bridge vif
   types, so we'd wait for OVS.

But it turns out that opendaylight is an OVS vif type and doesn't send
events for plugging the vif, only for binding the port (and we don't
re-bind the port during reboot). There is also a report of this being a
problem for other types of ports, see
If209f77cff2de00f694b01b2507c633ec3882c82.

So rather than try to special-case every possible vif type that could
be impacted by this, we are simply reverting the change so we no longer
wait for vif plugged events during hard reboot.

Note that if we went back to Id188d48609f3d22d14e16c7f6114291d547a8986
and tweaked that to not unplug/plug the vifs we wouldn't have this
problem either, and that change was really meant to deal with an
encrypted volume issue on reboot. But changing that logic is out of the
scope of this change. Alternatively, we could re-bind the port during
reboot but that could have other implications, or neutron could put
something into the port details telling us which vifs will send events
and which won't, but again that's all outside of the scope of this
patch.

Change-Id: Ib3f10706a7191c58909ec1938042ce338df4d499
Closes-Bug: #1755890
2018-03-14 21:07:17 +00:00
..
disk Merge "Don't launch guestfs in a thread pool if guestfs.debug is enabled" 2018-01-31 13:30:44 +00:00
hyperv Merge "hyper-v: Deprecates support for Windows / Hyper-V Server 2012" 2018-01-17 05:15:20 +00:00
image Use assert(Not)Equal instead of assertTrue(A == X) 2016-06-03 16:53:15 +01:00
ironic Implement get_traits() for the ironic virt driver 2018-01-30 20:45:27 -05:00
libvirt Revert "Refine waiting for vif plug events during _hard_reboot" 2018-03-14 21:07:17 +00:00
powervm PowerVM Driver: SEA 2018-01-22 11:18:55 -06:00
vmwareapi Merge "VMware: add support for different firmwares" 2018-01-05 21:40:36 +00:00
xenapi Move remaining uses of parted to privsep. 2018-01-24 22:26:36 +00:00
__init__.py
fakelibosinfo.py Fix misuse of assertTrue in console and virt tests 2016-02-22 16:09:21 +09:00
test_block_device.py libvirt: fix native luks encryption failure to find volume_id 2018-02-02 15:00:30 -05:00
test_configdrive.py force_config_drive: StrOpt -> BoolOpt 2015-11-11 19:59:22 +00:00
test_driver.py Remove usage of parameter enforce_type 2017-04-17 20:23:19 +08:00
test_events.py
test_fake.py
test_firewall.py remove get_nw_info_for_instance from compute.utils 2017-06-13 13:30:06 +02:00
test_hardware.py Trim the fat from InstanceInfo 2017-07-25 10:27:23 -05:00
test_imagecache.py Remove mox from tests/unit/virt/test_imagecache.py 2016-06-16 23:40:01 +00:00
test_images.py qemu-img do not use cache=none if no O_DIRECT support 2017-11-29 22:33:39 +00:00
test_netutils.py Remove unnecessary code 2017-07-28 06:01:21 +00:00
test_osinfo.py Do not attempt to load osinfo if we do not have os_distro 2017-03-23 22:07:03 -04:00
test_virt.py Rename block_device_info_get_root 2018-01-11 20:46:13 +00:00
test_virt_drivers.py Merge "libvirt: test to make sure volume_use_multipath is properly used" 2018-01-31 14:15:54 +00:00