If an instance fails to build, which is possible for a variety of
reasons, we may end up in a situation where we have remnants of a
plugged VIF (typically files) left on the host. This is because we
cleanup from the neutron perspective but don't attempt to unplug the
VIF, a call which may have many side-effects depending on the VIF
driver. Resolve this by always attempting to unplug VIFs as part of the
network cleanup.
A now invalid note is also removed and a unit test corrected.
Conflicts:
nova/tests/unit/compute/test_compute_mgr.py
NOTE(stephenfin): Conflict is because we're missing change
Ic5cab99944df9e501ba2032eb96911c36304494d ("Port binding based on events
during live migration") which we don't want to backport.
Closes-Bug: #1831771
Related-Bug: #1830081
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Change-Id: Ibdbde4ed460a99b0cbe0d6b76e0e5b3c0650f9d9
(cherry picked from commit b3e14931d6)
(cherry picked from commit 3e935325a8)
(cherry picked from commit 265fd4f6bd)
(cherry picked from commit 85521691a8)
f50bd6e657