ea297d6ffb
By the time finish_resize runs on the dest host, the instance host/node values are already pointing at the dest (they are set by resize_instance on the source compute before casting to finish_resize on the dest). If finish_resize fails, the instance is essentially stuck on the dest host so rather than revert the allocations (which will drop the new flavor allocations against the dest host where the instance now lives) we should just drop the old flavor allocations on the source node resource provider, which is what this change does. The functional regression recreate test is updated to show this working. Change-Id: I52c8d038118c858004e17e71b2fba9e9e2714815 Closes-Bug: #1825537
75 lines
3.5 KiB
Python
75 lines
3.5 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from nova.tests.functional import integrated_helpers
|
|
|
|
|
|
class FinishResizeErrorAllocationCleanupTestCase(
|
|
integrated_helpers.ProviderUsageBaseTestCase):
|
|
"""Test for bug 1825537 introduced in Rocky and backported down to Pike.
|
|
|
|
Tests a scenario where finish_resize fails on the dest compute during a
|
|
resize and ensures resource provider allocations are properly cleaned up
|
|
in placement.
|
|
"""
|
|
|
|
compute_driver = 'fake.FakeFinishMigrationFailDriver'
|
|
|
|
def setUp(self):
|
|
super(FinishResizeErrorAllocationCleanupTestCase, self).setUp()
|
|
# Get the flavors we're going to use.
|
|
flavors = self.api.get_flavors()
|
|
self.flavor1 = flavors[0]
|
|
self.flavor2 = flavors[1]
|
|
|
|
def _resize_and_assert_error(self, server, dest_host):
|
|
# Now resize the server and wait for it to go to ERROR status because
|
|
# the finish_migration virt driver method in host2 should fail.
|
|
req = {'resize': {'flavorRef': self.flavor2['id']}}
|
|
self.api.post_server_action(server['id'], req)
|
|
# The instance is set to ERROR status before the fault is recorded so
|
|
# to avoid a race we need to wait for the migration status to change
|
|
# to 'error' which happens after the fault is recorded.
|
|
self._wait_for_migration_status(server, ['error'])
|
|
server = self._wait_for_state_change(self.admin_api, server, 'ERROR')
|
|
# The server should be pointing at $dest_host because resize_instance
|
|
# will have updated the host/node value on the instance before casting
|
|
# to the finish_resize method on the dest compute.
|
|
self.assertEqual(dest_host, server['OS-EXT-SRV-ATTR:host'])
|
|
# In this case the FakeFinishMigrationFailDriver.finish_migration
|
|
# method raises VirtualInterfaceCreateException.
|
|
self.assertIn('Virtual Interface creation failed',
|
|
server['fault']['message'])
|
|
|
|
def test_finish_resize_fails_allocation_cleanup(self):
|
|
# Start two computes so we can resize across hosts.
|
|
self._start_compute('host1')
|
|
self._start_compute('host2')
|
|
|
|
# Create a server on host1.
|
|
server = self._boot_and_check_allocations(self.flavor1, 'host1')
|
|
|
|
# Resize to host2 which should fail.
|
|
self._resize_and_assert_error(server, 'host2')
|
|
|
|
# Check the resource provider allocations. Since the server is pointed
|
|
# at the dest host in the DB now, the dest node resource provider
|
|
# allocations should still exist with the new flavor.
|
|
source_rp_uuid = self._get_provider_uuid_by_host('host1')
|
|
dest_rp_uuid = self._get_provider_uuid_by_host('host2')
|
|
self.assertFlavorMatchesAllocation(
|
|
self.flavor2, server['id'], dest_rp_uuid)
|
|
# And the source node provider should not have any usage.
|
|
source_rp_usages = self._get_provider_usages(source_rp_uuid)
|
|
no_usage = {'VCPU': 0, 'MEMORY_MB': 0, 'DISK_GB': 0}
|
|
self.assertEqual(no_usage, source_rp_usages)
|