Update patch set 6

Browse Source

Patch Set 6:

> Patch Set 6: Code-Review-1
> 
> I ran into a problem with this patch in testing.
> 
> 1. There is not help text for the TLS version field. I noticed this when I could not enter "TLSv1.2,TLSv1.3" in the field.

Ack, I will add the help text for this new field.


> 2. The required formatting on the field seems odd. My natural instinct was to put a comma separated list in this field, but it won't accept it. Can we make this field more flexible or at least document the required formatting? I had to put one version per line for it to take the change.

The next textarea uses the ng-list="
" attribute, it allows to automatically convert a string with comma-separated items into a multiline textarea (one item per line), and it does the reverse conversion when the form is submitted.
I agree that without neither help nor placeholder value, it can be confusing for someone who knowns the API.
I can reverted it to a simple comma-separated string

Patch-set: 6

...

This commit is contained in:

Gerrit User 29244 2021-03-19 15:27:22 +00:00 committed by Gerrit Code Review

parent a3e1d70592

commit 6961e24e78

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available