Fix ESLint warnings

This change fix all `consistent-return` in ESLint.

Change-Id: I8a5db7205da58f9626ca5e5c060ed2a51d700852

octavia_dashboard/static/dashboard/project/lbaasv2/healthmonitors/healthmonitors.module.spec.js

@@ -57,9 +57,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/l7policies/l7policies.module.spec.js

@@ -56,9 +56,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/l7rules/l7rules.module.spec.js

@@ -56,9 +56,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/listeners/listeners.module.spec.js

@@ -57,9 +57,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/loadbalancers/actions/delete/delete.action.service.js

@@ -147,6 +147,7 @@
       if (result.pass.length > 0) {
         return deleteModal.open(scope, result.pass.map(getEntity), context).then(deleteResult);
       }
+      return null;
     }
 
     function deleteItem(id) {

octavia_dashboard/static/dashboard/project/lbaasv2/loadbalancers/loadbalancers.module.spec.js

@@ -59,9 +59,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/loadbalancers/loadbalancers.service.js

@@ -364,6 +364,7 @@
         if (['ACTIVE', 'ERROR'].indexOf(response.data.provisioning_status) < 0) {
           return $q.reject();
         }
+        return null;
       });
     }
   }

octavia_dashboard/static/dashboard/project/lbaasv2/members/members.module.spec.js

@@ -57,9 +57,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/pools/pools.module.spec.js

@@ -57,9 +57,7 @@
       return list.filter(matchesId).length === 1;
 
       function matchesId(action) {
-        if (action.id === value) {
+        return action.id === value;
-          return true;
-        }
       }
     }
 

octavia_dashboard/static/dashboard/project/lbaasv2/workflow/modal.service.js

@@ -107,6 +107,7 @@
           $rootScope.$broadcast(events.ACTION_DONE);
           return args.handle(response);
         }
+        return null;
       }
     }