Update patch set 1
Patch Set 1: Code-Review-1 (4 comments) When I do the initial create workflow this setting is not being set. However, if I come back and edit the pool the setting gets set. The pool help content should also be updated to discuss the session persistence. Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
960cbb7923
commit
d08ce4bbc2
|
@ -0,0 +1,78 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f515b1d_c99e6ab7",
|
||||
"filename": "octavia_dashboard/static/dashboard/project/lbaasv2/workflow/model.service.js",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 640,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2017-09-25T17:49:49Z",
|
||||
"side": 1,
|
||||
"message": "We should probably validate the combination here. Cookie name can only be set if \"app_cookie\" is selected, otherwise it should always be None/null",
|
||||
"revId": "95b86f859a4f6e9d626d2fbe718cd77ecdf0924f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f515b1d_ee4a4caa",
|
||||
"filename": "octavia_dashboard/static/dashboard/project/lbaasv2/workflow/pool/pool.html",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 29,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2017-09-25T17:49:49Z",
|
||||
"side": 1,
|
||||
"message": "Can we make this \"Session Persistence\"? Type is to vague",
|
||||
"range": {
|
||||
"startLine": 29,
|
||||
"startChar": 10,
|
||||
"endLine": 29,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "95b86f859a4f6e9d626d2fbe718cd77ecdf0924f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f515b1d_6ebbfc71",
|
||||
"filename": "octavia_dashboard/static/dashboard/project/lbaasv2/workflow/pool/pool.html",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 31,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2017-09-25T17:49:49Z",
|
||||
"side": 1,
|
||||
"message": "Is there a way we can make \"None\" the default? Without None in the list it is not clear how to unselect/disable.",
|
||||
"revId": "95b86f859a4f6e9d626d2fbe718cd77ecdf0924f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f515b1d_ee548c23",
|
||||
"filename": "octavia_dashboard/static/dashboard/project/lbaasv2/workflow/pool/pool.html",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 41,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2017-09-25T17:49:49Z",
|
||||
"side": 1,
|
||||
"message": "Can we make the \"Cookie\" field appear when \"APP Cookie\" is selected? App cookie is the only one that allows a cookie name to be specified. This would be like how the TLS settings appear when a user selects \"terminated TLS\"",
|
||||
"revId": "95b86f859a4f6e9d626d2fbe718cd77ecdf0924f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue