openstack
/
octavia-dashboard
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 841 <841@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 841 2021-02-18 15:34:27 +00:00 committed by Gerrit Code Review
parent a4e4a843e4
commit e7c12c1239
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
d778c62cf68f2ce5b3e161823e2e40fdf95e2ce5 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "6d7859b6_8ee64bc4",
"filename": "octavia_dashboard/dashboards/project/load_balancer/panel.py",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 841
},
"writtenOn": "2021-02-18T15:34:27Z",
"side": 1,
"message": "A simpler way is something like https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/networks/panel.py\n\"permissions\" attribute can disable the panel if the corresponding service is not found in the keystone catalog.",
"revId": "d778c62cf68f2ce5b3e161823e2e40fdf95e2ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}