50 lines
1.7 KiB
Plaintext
50 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "116785e1_94effd2a",
|
|
"filename": "octavia_dashboard/api/rest/lbaasv2.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 263,
|
|
"author": {
|
|
"id": 29244
|
|
},
|
|
"writtenOn": "2022-10-27T08:59:21Z",
|
|
"side": 1,
|
|
"message": "it doesn\u0027t work if we also create a pool, kwargs is redefined at line 258, so loadbalancer_id no longer exists in the dict.",
|
|
"range": {
|
|
"startLine": 263,
|
|
"startChar": 29,
|
|
"endLine": 263,
|
|
"endChar": 35
|
|
},
|
|
"revId": "27c3cc481acc7bc0d49962d0a5cd226a13097542",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8541ab27_d6bac9c0",
|
|
"filename": "octavia_dashboard/api/rest/lbaasv2.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 266,
|
|
"author": {
|
|
"id": 29244
|
|
},
|
|
"writtenOn": "2022-10-27T08:59:21Z",
|
|
"side": 1,
|
|
"message": "I still think that if we create a Prometheus listener (from the LB form) and a pool, we may have a race condition, 2 threads are going to wait for the LB to switch from PENDING_UPDATE to ACTIVE, and both threads might send 2 requests at the same time (one of them will be processed, the 2nd will be denied with a 409 - Conflict).\n\nI don\u0027t see a smart solution to this pbl (supporting the fully-populated LB API would work, but it\u0027s a huge work in octavia-dashboard)",
|
|
"range": {
|
|
"startLine": 266,
|
|
"startChar": 0,
|
|
"endLine": 266,
|
|
"endChar": 12
|
|
},
|
|
"revId": "27c3cc481acc7bc0d49962d0a5cd226a13097542",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |