openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Update patch set 31 

Patch Set 31: Code-Review+1

(2 comments)

Patch-set: 31
Reviewer: Gerrit User 31664 <31664@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, ab6121d737651cab5576bc3bd566c6892592a646
Attention: {"person_ident":"Gerrit User 34429 \u003c34429@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31664 \u003c31664@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change"}
This commit is contained in:
Gerrit User 31664 2024-04-16 16:02:56 +00:00 committed by Gerrit Code Review
parent f0ebe0424a
commit 2a7020bcc7
1 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
e4728b52ebb084e3dc826002903aff60f8d84abf
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d8895e6f_982c1b34",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 31
},
"lineNbr": 0,
"author": {
"id": 31664
},
"writtenOn": "2024-04-16T16:02:56Z",
"side": 1,
"message": "Looks good to me",
"revId": "e4728b52ebb084e3dc826002903aff60f8d84abf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +63,30 @@
},
"revId": "e4728b52ebb084e3dc826002903aff60f8d84abf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "322e00df_da016524",
"filename": "octavia_tempest_plugin/tests/act_stdby_scenario/v2/test_active_standby.py",
"patchSetId": 31
},
"lineNbr": 39,
"author": {
"id": 31664
},
"writtenOn": "2024-04-16T16:02:56Z",
"side": 1,
"message": "ok, adding type annotations to the class doesn\u0027t look bad to me.",
"parentUuid": "4561fbe3_600a624d",
"range": {
"startLine": 39,
"startChar": 4,
"endLine": 39,
"endChar": 42
},
"revId": "e4728b52ebb084e3dc826002903aff60f8d84abf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}