Update patch set 3

Patch Set 3:

(4 comments)

Patch-set: 3
Label: Verified=0

59482b0cfdb3ed127e1b4b0277967d78421856ed

@@ -17,6 +17,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "9f560f44_e7105cae",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 37,
+      "author": {
+        "id": 28609
+      },
+      "writtenOn": "2020-10-06T15:06:06Z",
+      "side": 1,
+      "message": "1) Agree, I\u0027ll fix this comment.\n2) According Michael having this port as class attribute should improve time execution.\n\n### Note ###\nI\u0027ve also pushed a patch to improve our current procedure of \"maintaining tests\u0027 ports\"\nI\u0027m talking about: https://review.opendev.org/#/c/755436/ and I must say that I\u0027ll be more than happy to have the above patch merged before all other patches I\u0027m working on, including this one.\nSo once it will happen I\u0027ll simply add \"test_port \u003d self.pool_of_ports[\u0027http_range\u0027].pop(0)\" instead of \"udp_port_104 \u003d 104\"",
+      "parentUuid": "9f560f44_9c18d31e",
+      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "9f560f44_fc0e2fe2",
@@ -34,6 +52,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "9f560f44_07d110cd",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 102,
+      "author": {
+        "id": 28609
+      },
+      "writtenOn": "2020-10-06T15:06:06Z",
+      "side": 1,
+      "message": "Pep8 gates PASS and locally \"tox -e pep8\" did work for me.",
+      "parentUuid": "9f560f44_fc0e2fe2",
+      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "9f560f44_bca037a6",
@@ -51,6 +87,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "9f560f44_4780289d",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 148,
+      "author": {
+        "id": 28609
+      },
+      "writtenOn": "2020-10-06T15:06:06Z",
+      "side": 1,
+      "message": "Maybe I can simply replace \"else\" with \"if create_healtmonitor is True\" then?",
+      "parentUuid": "9f560f44_bca037a6",
+      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "9f560f44_fcb74f84",
@@ -85,6 +139,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "9f560f44_420ad61d",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 235,
+      "author": {
+        "id": 28609
+      },
+      "writtenOn": "2020-10-06T15:06:06Z",
+      "side": 1,
+      "message": "Maybe I can simply break the loop using \"break\" so once in some retry \"make_udp_request\" PASS it will break the loop.\nAgree we don\u0027t need \"success\" at all.",
+      "parentUuid": "9f560f44_bc05d77b",
+      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "9f560f44_875b6020",