Update patch set 6

Patch Set 6: Code-Review-1 (7 comments) Patch-set: 6 Reviewer: Gerrit User 6469 <6469@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2019-01-22 17:01:23 +00:00 · 2019-01-22 17:01:23 +00:00 · 527c4a7ec6
parent 5331bc4bd2
commit 527c4a7ec6
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9fdfeff1_46a146a9",
+        "filename": "octavia_tempest_plugin/config.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 183,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "This option name hints at a boolean type option, just like the others above it with similar name.",
+      "range": {
+        "startLine": 183,
+        "startChar": 16,
+        "endLine": 183,
+        "endChar": 35
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_86916e9c",
+        "filename": "octavia_tempest_plugin/tests/api/v2/test_l7policy.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 39,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "nit: when line wrapping, the standard used is to add whitespace at the end of the upper line instead.",
+      "range": {
+        "startLine": 39,
+        "startChar": 31,
+        "endLine": 39,
+        "endChar": 32
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_c669b6be",
+        "filename": "octavia_tempest_plugin/tests/api/v2/test_l7policy.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "nit: \"L7 scenario tests will be skipped.\" or \"Skipping L7 scenario tests.\"",
+      "range": {
+        "startLine": 40,
+        "startChar": 72,
+        "endLine": 40,
+        "endChar": 77
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_06a57e04",
+        "filename": "octavia_tempest_plugin/tests/api/v2/test_l7policy.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "nit: missing white space. should be \"configuration. L7\"",
+      "range": {
+        "startLine": 40,
+        "startChar": 40,
+        "endLine": 40,
+        "endChar": 56
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_86e64e44",
+        "filename": "octavia_tempest_plugin/tests/api/v2/test_l7rule.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 37,
+        "startChar": 30,
+        "endLine": 40,
+        "endChar": 44
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_866dee99",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_l7policy.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 38,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 35,
+        "startChar": 31,
+        "endLine": 38,
+        "endChar": 43
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_8602ceb3",
+        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_l7rule.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 38,
+      "author": {
+        "id": 6469
+      },
+      "writtenOn": "2019-01-22T17:01:23Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 35,
+        "startChar": 31,
+        "endLine": 38,
+        "endChar": 43
+      },
+      "revId": "5f6ca1be552027ee6cc721c1a29f9619dd548e0c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}