openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(4 comments)

Patch-set: 7
Reviewer: Gerrit User 1131 <1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 1131 2020-10-26 19:52:26 +00:00 committed by Gerrit Code Review
parent a05757ef0c
commit 628c386d3e
1 changed files with 84 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
1041e550d0254ccff2a72cf36562bf249451bd38 Normal file
View File

@ -0,0 +1,84 @@
{
"comments": [
{
"key": {
"uuid": "3f65232a_6592b44d",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
"patchSetId": 7
},
"lineNbr": 224,
"author": {
"id": 1131
},
"writtenOn": "2020-10-26T19:52:26Z",
"side": 1,
"message": "LOG.*() should be called like:\n\n LOG.info(\u0027... number: %d\u0027, retry_number)",
"range": {
"startLine": 223,
"startChar": 21,
"endLine": 224,
"endChar": 40
},
"revId": "1041e550d0254ccff2a72cf36562bf249451bd38",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f65232a_05a300a0",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
"patchSetId": 7
},
"lineNbr": 232,
"author": {
"id": 1131
},
"writtenOn": "2020-10-26T19:52:26Z",
"side": 1,
"message": "Same as above, should be (\u0027... %s\u0027, e)",
"range": {
"startLine": 232,
"startChar": 60,
"endLine": 232,
"endChar": 71
},
"revId": "1041e550d0254ccff2a72cf36562bf249451bd38",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f65232a_65e0f4cd",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
"patchSetId": 7
},
"lineNbr": 1376,
"author": {
"id": 1131
},
"writtenOn": "2020-10-26T19:52:26Z",
"side": 1,
"message": "Polarion doesn\u0027t have any meaning upstream, same below",
"revId": "1041e550d0254ccff2a72cf36562bf249451bd38",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f65232a_a5b5eccf",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
"patchSetId": 7
},
"lineNbr": 1503,
"author": {
"id": 1131
},
"writtenOn": "2020-10-26T19:52:26Z",
"side": 1,
"message": "Same as above",
"revId": "1041e550d0254ccff2a72cf36562bf249451bd38",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}